Change in osmo-bsc[master]: lchan_fsm.c: Fix misleading comment

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27856 ) Change subject: lchan_fsm.c: Fix misleading comment ...................................................................... lchan_fsm.c: Fix misleading comment From Vadim in https://gerrit.osmocom.org/c/osmo-bsc/+/27818 By checking !(link_id & 0xc0) we actually make sure that this is not SACCH. So the comment "but not if the link_id contains a TCH flag" is wrong, there is simply no such thing like "a TCH flag". Change-Id: I8f0f6d7bf952426fd2f27802f1499d6ee8981982 --- M src/osmo-bsc/lchan_fsm.c 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c index 0b23f6c..5df6c57 100644 --- a/src/osmo-bsc/lchan_fsm.c +++ b/src/osmo-bsc/lchan_fsm.c @@ -1198,8 +1198,7 @@ lchan->sapis[sapi] = LCHAN_SAPI_UNUSED; rll_indication(lchan, link_id, BSC_RLLR_IND_REL_IND); - /* Releasing SAPI 0 means the conn becomes invalid; but not if the link_id contains a TCH flag. - * (TODO: is this the correct interpretation?) */ + /* Releasing SAPI 0 means the conn becomes invalid; but not if the link_id contains a SACCH flag. */ if (lchan->conn && sapi == 0 && !(link_id & 0xc0)) { LOG_LCHAN(lchan, LOGL_DEBUG, "lchan is releasing\n"); gscon_lchan_releasing(lchan->conn, lchan); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27856 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8f0f6d7bf952426fd2f27802f1499d6ee8981982 Gerrit-Change-Number: 27856 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged