22 Nov
2024
22 Nov
'24
5:06 p.m.
Attention is currently required from: daniel, fixeria, laforge, pespin.
jolly has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/38886?usp=email )
Change subject: osmo_io: Increase default queue max_length from 32 to 1024 ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: I think there should be some handling of that issue, no matter if we select a queue length of 32 or 1024.
What happens if the queue is full? Do we get something like EAGAIN? Or will it block? What happens if the tx queue becomes empty? Can we poll/select it and proceed with filling the queue?
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38886?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I92d5369af523f6297d45d4b534bb0f349ae74485
Gerrit-Change-Number: 38886
Gerrit-PatchSet: 1
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel dwillmann@sysmocom.de
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: jolly andreas@eversberg.eu
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: daniel dwillmann@sysmocom.de
Gerrit-Comment-Date: Fri, 22 Nov 2024 16:06:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No