Attention is currently required from: neels, laforge, fixeria, dexter.
keith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/28509
)
Change subject: Change CC_CAUSE returned on unanswered MT Call
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
regarding proper CC timeout: the old cc implementation
apparently only has one overall guard timer, […]
Looking at that, and reading the
comments, that guard timeout is designed to overall protect against something becoming non
responsive:
/*NOTE: The purpose of this timer is to prevent the cc state machine
* from hanging [......]
* So if the cc state machine does not show any activity for an
* extended amount of time during call setup or teardown the guard
* timer will time out and hard-clear the connection. */
One /could/ start adding conditions to this timer, but I think that might get in the way
of it's stated purpose. It would seem that what is more needed is the proper
implementation of T301 (I think it is T301) See TS 04.08 5.2.2.3.2
--
To view, visit
https://gerrit.osmocom.org/c/osmo-msc/+/28509
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I4a9cfc388ec9ecb743d154a114a6db638eac4701
Gerrit-Change-Number: 28509
Gerrit-PatchSet: 2
Gerrit-Owner: keith <keith(a)rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 03 Oct 2022 18:07:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: comment