Attention is currently required from: falconia.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/32988
)
Change subject: refactor: replace rtppayload_is_valid() with preening before enqueue
......................................................................
Patch Set 2:
(1 comment)
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32988/comment/ff3a7524_cc81d58e
PS2, Line 1891: case PL_DECISION_ACCEPT_ASIS:
Would PL_DECISION_ACCEPT_AS_IS be acceptable? Or do
you prefer short and simple PL_DECISION_ACCEPT?
I'd go for PL_DECISION_ACCEPT.
Sounds shorter and more familiar to other systems (eg. iptables).
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/32988
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I7fc99aeecba8303b56d397b8952de5eea82b301e
Gerrit-Change-Number: 32988
Gerrit-PatchSet: 2
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Comment-Date: Thu, 25 May 2023 11:57:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia <falcon(a)freecalypso.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment