Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-gprs/+/32972 )
Change subject: rlcmac: Add APIs to decode P1/P2 Rest Octets
......................................................................
Patch Set 3:
(2 comments)
File src/rlcmac/csn1_ts_44_018.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/32972/comment/3456326c_7b4303c4
PS3, Line 132: M_UINT_LH (P1_Rest_Octets_t, Packet_Page_Indication_2, 1),
missing `M_PADDING_BITS`
https://gerrit.osmocom.org/c/libosmo-gprs/+/32972/comment/b2233069_3a6131e2
PS3, Line 155: M_UINT_LH (P2_Rest_Octets_t, Packet_Page_Indication_3, 1),
missing `M_PADDING_BITS`
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-gprs/+/32972
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I59c6723d969880a4481e3b86a172d59f0edeb1e4
Gerrit-Change-Number: 32972
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 25 May 2023 15:43:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment