Attention is currently required from: laforge, dexter.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/27777 )
Change subject: osmo-bts-trx: amr_loop: trigger the loop unconditionally
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
looking at this again, the intent of the code is quite
clear: Stop the loop if there just was a new […]
See my other comment.
File src/osmo-bts-trx/sched_lchan_tchf.c:
https://gerrit.osmocom.org/c/osmo-bts/+/27777/comment/bbfdf9ff_b0b3086c
PS1, Line 462: if (chan_state->codec[i] == cmr_codec)
To me it reads as: if the decoded CMR value is present in the list of allowed codec modes,
then we disable the loop below. Of course this is always the case. Also note that this is
the Downlink path, not Uplink.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/27777
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I09b649973d4269c4082a4fafa493c37825f95a9c
Gerrit-Change-Number: 27777
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 14 Apr 2022 15:09:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment