Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38486?usp=email )
Change subject: vlr: Add support for CS and PS timers ......................................................................
Patch Set 1:
(15 comments)
File src/libvlr/vlr_auth_fsm.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19328): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/3fc22120_5133a086?usp=... : PS1, Line 46: [VLR_SUB_AS_WAIT_RESP] = { .T = 3260 }, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19328): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/8133164c_9dea1583?usp=... : PS1, Line 47: [VLR_SUB_AS_WAIT_RESP_RESYNC] = { .T = 3260 }, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19328): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/cb3809f3_f675f913?usp=... : PS1, Line 48: [VLR_SUB_AS_WAIT_ID_IMSI] = { .T = 3270 }, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19328): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/be064cb3_7a1cbfce?usp=... : PS1, Line 52: [VLR_SUB_AS_WAIT_RESP] = { .T = 3360 }, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19328): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/e9846a9d_5fd2245c?usp=... : PS1, Line 53: [VLR_SUB_AS_WAIT_RESP_RESYNC] = { .T = 3360 }, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19328): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/b4a88ee9_a3075c4f?usp=... : PS1, Line 54: [VLR_SUB_AS_WAIT_ID_IMSI] = { .T = 3370 }, please, no spaces at the start of a line
File src/libvlr/vlr_lu_fsm.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19328): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/ad006836_4143c5f1?usp=... : PS1, Line 339: [LU_COMPL_VLR_S_WAIT_IMEI] = { .T = 3370 }, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19328): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/8c3569d0_67b6e75b?usp=... : PS1, Line 340: [LU_COMPL_VLR_S_WAIT_IMEI_TMSI] = { .T = 3370 }, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19328): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/d6bfd113_140905f4?usp=... : PS1, Line 341: [LU_COMPL_VLR_S_WAIT_TMSI_CNF] = { .T = 3350 }, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19328): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/b211d42e_6be7d338?usp=... : PS1, Line 683: [VLR_ULA_S_WAIT_IMEISV] = { .T = 3270 }, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19328): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/aef50c07_f058a9db?usp=... : PS1, Line 684: [VLR_ULA_S_WAIT_HLR_CHECK_IMEI_EARLY] = { .T = 3270 }, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19328): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/0e94095a_473aae63?usp=... : PS1, Line 685: [VLR_ULA_S_WAIT_IMSI] = { .T = 3270 }, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19328): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/b56fa36d_332ed30c?usp=... : PS1, Line 689: [VLR_ULA_S_WAIT_IMEISV] = { .T = 3370 }, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19328): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/6d58c513_45775484?usp=... : PS1, Line 690: [VLR_ULA_S_WAIT_HLR_CHECK_IMEI_EARLY] = { .T = 3370 }, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19328): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/0ddb6b6c_df02a871?usp=... : PS1, Line 691: [VLR_ULA_S_WAIT_IMSI] = { .T = 3370 }, please, no spaces at the start of a line