Attention is currently required from: lynxis lazus, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-gprs/+/37724?usp=email )
Change subject: gmm: Introduce interface GMMBSSGP
......................................................................
Patch Set 1:
(1 comment)
File include/osmocom/gprs/gmm/gmm_prim.h:
https://gerrit.osmocom.org/c/libosmo-gprs/+/37724/comment/f4c46b05_fdd8dfc9
PS1, Line 369: /* Alloc primitive for GMMBSSGP SAP: */
As was discussed, let's just expose a generic alloc API and let the user fill prim
specific fields using designated initializers (or whatever they like). Long function names
with dozens of params are not nice, and it gets even worse when you add new fields to
prims.
AFAIR, we wanted to rework the existing API, so let's not add even more APIs which are
to be removed.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-gprs/+/37724?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I39045833fd43cfe98cb1a3812fbce3fdcaae6dc6
Gerrit-Change-Number: 37724
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Sat, 03 Aug 2024 11:56:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment