Change in osmo-bsc[master]: Add BTS setup ramping to prevent BSC overloading

Attention is currently required from: neels, fixeria, pespin, lynxis lazus. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29788 ) Change subject: Add BTS setup ramping to prevent BSC overloading ...................................................................... Patch Set 15: (4 comments) File src/osmo-bsc/bts_setup_ramp.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/e7235419_98adc791 PS4, Line 98: && net->bts_setup_ramp.step_size > 0 Ack https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/1b8ffa98_c313ee44 PS4, Line 101: net->bts_setup_ramp.active Ack https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/0c6aa072_4c9dd25d PS4, Line 201: INIT_LLIST_HEAD(&bts->bts_setup_ramp.list); The Linux kernel llist API has always worked in the way that you cannot llist_del() a llist_entry that was never added to a list via llist_add(). I don't really see why this is suddently becoming a problem. It's simply not safe. Just like you cannot unlock a pthread mutex that was never initialized, or whatever other API or interface you can come up with where you cannot undo something you never did in the first place. File src/osmo-bsc/bts_setup_ramp.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/2b5d26c5_77307955 PS15, Line 74: net->bts_setup_ramp.count >= net->bts_setup_ramp.step_size) Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id56dde6d58f3d0d20352f6c306598d2cccc6345d Gerrit-Change-Number: 29788 Gerrit-PatchSet: 15 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 11 Nov 2022 11:01:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: comment