Attention is currently required from: laforge.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/31687
)
Change subject: pcu_sock: only allow Ericsson RBS to connect to external PCU
......................................................................
Patch Set 1:
(1 comment)
File src/osmo-bsc/pcu_sock.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31687/comment/91b6809e_83623d53
PS1, Line 66: /* BSC co-located PCU
this is a non-static function, so I assume there are
other callers in the codebase? If so, are we s […]
Yes there are other callers but
it is safe to remove the is_ericsson_bts() call since this patch effectively prevents that
no other BTS type than Ericsson RBS can have a PCU connection, it will keep working.
(I have added this check in change I9ea0c53a5e68a51c781ef43bae71f947cdb95678, but adding
more and more is_ericsson_bts() checks here and there got messy. This patch cleans this
up.)
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/31687
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I18d190d661b06015419078382915c4606be01b04
Gerrit-Change-Number: 31687
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 07 Mar 2023 08:42:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment