20 Jun
2025
20 Jun
'25
3:43 p.m.
Attention is currently required from: Hoernchen.
dexter has posted comments on this change by Hoernchen. (
https://gerrit.osmocom.org/c/pysim/+/40467?usp=email )
Change subject: smdpp: validate eid
......................................................................
Patch Set 5: Code-Review+2 Verified+1
(3 comments)
Patchset:
PS5:
This looks ok to me. I have tried it out and it works fine. I would suggest to put the
verification code into a separate module.
Commit Message:
https://gerrit.osmocom.org/c/pysim/+/40467/comment/ca988042_3cd6771e?usp=em… :
PS5, Line 7: smdpp: validate eid
This is quite a complex patch. Maybe it would be helpful to write one or two lines on what
it does and why it is needed? (I know this but maybe others who read the commit log have
no clue.)
File osmo-smdpp.py:
https://gerrit.osmocom.org/c/pysim/+/40467/comment/356bd6af_df41c0be?usp=em… :
PS5, Line 133: print(f"Found GSMA permittedEins extension:
{ext.oid}")
Interesting, never saw this print(f"... thing before.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/40467?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ice704548cb62f14943927b5295007db13c807031
Gerrit-Change-Number: 40467
Gerrit-PatchSet: 5
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 20 Jun 2025 13:43:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes