Attention is currently required from: iedemam, neels.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/28165
)
Change subject: stats: new trackers for lchan life duration (v2)
......................................................................
Patch Set 3:
(1 comment)
File src/osmo-bsc/lchan_fsm.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/28165/comment/6b68def6_757c98bf
PS3, Line 519: .active_start = { .tv_sec = 0, .tv_nsec = 0 },
The purpose of this was to initialize the timestamps
to zero values so I can tell when they've been […]
My point is simply that this
struct initializer is already zeroing all fields in the struct unless otherwise specified,
that's why most of the struct fields don't appear here.
So there's no need to set them to 0 explicitly, they are set to zero anyway, so they
can be removed.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/28165
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ie3771233ecbd4bc24a24fb22c1064a18e7b8b2b0
Gerrit-Change-Number: 28165
Gerrit-PatchSet: 3
Gerrit-Owner: iedemam <michael(a)kapsulate.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: iedemam <michael(a)kapsulate.com>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 23 May 2022 08:48:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: iedemam <michael(a)kapsulate.com>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment