Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-pcap/+/39774?usp=email )
Change subject: pcap-server: Introduce VTY cmd file-write-queue-max-length
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/osmo_pcap_wr_file.c:
https://gerrit.osmocom.org/c/osmo-pcap/+/39774/comment/47cd67a6_e861e4d4?us… :
PS1, Line 100: osmo_pcap_wr_file_write_queue_max_length
Maybe add _set for consistency with osmo_pcap_wr_file_set_flush_completed_cb above?
```suggestion
void osmo_pcap_wr_file_set_write_queue_max_length(struct osmo_pcap_wr_file *wrf, size_t
max_len)
```
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcap/+/39774?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-Change-Id: I137f13481c03f82d11a2d38ba4fd5691a55535ce
Gerrit-Change-Number: 39774
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 12 Mar 2025 07:33:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes