Change in osmo-iuh[master]: asn1tostruct: fix defines getting redefined

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/30088 ) Change subject: asn1tostruct: fix defines getting redefined ...................................................................... Patch Set 3: (2 comments) Patchset: PS3: Yes. Here is the diff of the generated files with this patch: https://gitea.osmocom.org/osmith/osmo-iuh-generated-files/commit/8012927035… File asn1/utils/asn1tostruct.py: https://gerrit.osmocom.org/c/osmo-iuh/+/30088/comment/37a3bf1a_6ba209a1 PS3, Line 84: use the same type multiple times, in that case we use the actual name If somebody needs to actually use them / or debug the generated code for whatever reason, I think it's more useful to have the name of the field instead of a number. Because then you would need to look up the number again to know which field it actually is. -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/30088 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I2ecae6789899952d1dc5691ab76907abeaa71c12 Gerrit-Change-Number: 30088 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Nov 2022 12:47:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment