Attention is currently required from: falconia.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/32988
)
Change subject: refactor: replace rtppayload_is_valid() with preening before enqueue
......................................................................
Patch Set 1:
(1 comment)
File src/common/osmux.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32988/comment/dcfcc077_15f56f7a
PS1, Line 413: /* We have to apply the same checks as in l1sap_rtp_rx_cb(), in case
Question: the AMR encoding format check done in
rtppayload_is_octet_aligned(), is it needed for Osmu […]
osmux implementation always
generates octet-aligned AMR RTP.
See libosmo-netif:
./src/osmux.c
./src/osmux_input.c
./src/osmux_output.c
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/32988
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I7fc99aeecba8303b56d397b8952de5eea82b301e
Gerrit-Change-Number: 32988
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Comment-Date: Thu, 25 May 2023 09:59:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia <falcon(a)freecalypso.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment