Attention is currently required from: laforge, pespin, fixeria, dexter.
Jenkins Builder has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/31417 )
Change subject: l1sap: Accept RFC5993 and TS 101.318 HR GSM payload
......................................................................
Patch Set 4:
(3 comments)
File src/common/l1sap.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4942):
https://gerrit.osmocom.org/c/osmo-bts/+/31417/comment/ffeb95cd_aa9062a6
PS4, Line 1267: } else
else is not generally useful after a break or return
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4942):
https://gerrit.osmocom.org/c/osmo-bts/+/31417/comment/58353208_a134f7a7
PS4, Line 1267: } else
suspect code indent for conditional statements (16, 20)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4942):
https://gerrit.osmocom.org/c/osmo-bts/+/31417/comment/0a32fa84_553c9109
PS4, Line 1268: if (OSMO_UNLIKELY
Statements should start on a tabstop
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/31417
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I453562da412fde5b928bd2b588129c58ec8e2a7e
Gerrit-Change-Number: 31417
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 10 Mar 2023 11:55:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment