Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39254?usp=email )
Change subject: SGSN: TC_attach_gmm_attach_req_while_gmm_attach: fix test case ......................................................................
Patch Set 2: Code-Review-1
(4 comments)
File sgsn/BSSGP_ConnHdlr.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39254/comment/fa700165_4bcb0... : PS2, Line 534: function f_random_ptmsi(OCT1 suffix := '00'O) return OCT4 { library/Osmocom_Gb_Types.ttcn 3872: function f_gprs_tlli_random() return OCT4 { 3873- var OCT4 tlli := f_rnd_octstring(4); 3874- return tlli or4b 'c0000000'O; 3875- } 3876- 3877-} with { encode "RAW" };
File sgsn/SGSN_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39254/comment/69a635d3_8b81f... : PS2, Line 2088: f_vty_config(SGSNVTY, "sgsn", "auth-policy accept-all"); why was this removed?
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39254/comment/b5e74039_ffe6e... : PS2, Line 2044: /* send out a second GMM_Attach Request. this comment no longer matches the code, you moved the second attach above... I wonder why did you move it.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39254/comment/26f7e967_9af52... : PS2, Line 2050: [] as_gmm_auth(umts_aka_challenge := true, expect_sai := true) {}; AFAIU the auth is exected to happen at the end of the whole alt? maybe simply move it outside to expect it to happen after the other messages.