Attention is currently required from: laforge, pespin, lynxis lazus.
matanp has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/32712 )
Change subject: Add FPLMN read and program
......................................................................
Patch Set 6:
(1 comment)
File pysim-testdata/sysmoUSIM-SJS1.ok:
https://gerrit.osmocom.org/c/pysim/+/32712/comment/fbd00340_45447728
PS5, Line 108: 62f201 # MCC: 262 MNC: 010
the fix is not mandatory before merging this commit.
[…]
The only solution I can see is changing `derive_mcc` and `derive_mnc` to return
a 'str' instead of 'int' (thus preserving leading 0) - is it an acceptable
solution?
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/32712
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I9ce8c1af691c28ea9ed69e7b5f03f0c02d1f029b
Gerrit-Change-Number: 32712
Gerrit-PatchSet: 6
Gerrit-Owner: matanp <matan1008(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Sun, 28 May 2023 04:59:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
Comment-In-Reply-To: matanp <matan1008(a)gmail.com>
Gerrit-MessageType: comment