[XS] Change in osmo-hnbgw[master]: kpi: Fix wrong counters incremented in RAB Release Failed List

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40279?usp=email ) Change subject: kpi: Fix wrong counters incremented in RAB Release Failed List ...................................................................... kpi: Fix wrong counters incremented in RAB Release Failed List Thouse counters are already incremented somewhere else, when Setup-or-modify is answered with a failure. This list is for RABs which failed to release, and the correct counter is already being incremented above. Change-Id: I0bcb70ca18078bb9201ce6cbf4ea81c05ae4ea68 --- M src/osmo-hnbgw/kpi_ranap.c 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/79/40279/1 diff --git a/src/osmo-hnbgw/kpi_ranap.c b/src/osmo-hnbgw/kpi_ranap.c index 640f838..cbaa61d 100644 --- a/src/osmo-hnbgw/kpi_ranap.c +++ b/src/osmo-hnbgw/kpi_ranap.c @@ -382,11 +382,9 @@ /* differentiate modify / activate */ switch (map->rab_state[rab_id]) { case RAB_STATE_ACT_REQ: - HNBP_CTR_INC(hnbp, map->is_ps ? HNB_CTR_RANAP_PS_RAB_ACT_FAIL : HNB_CTR_RANAP_CS_RAB_ACT_FAIL); map->rab_state[rab_id] = RAB_STATE_INACTIVE; break; case RAB_STATE_ACTIVE: - HNBP_CTR_INC(hnbp, map->is_ps ? HNB_CTR_RANAP_PS_RAB_MOD_FAIL : HNB_CTR_RANAP_CS_RAB_MOD_FAIL); // FIXME: does it remain active after modification failure? break; default: -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40279?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I0bcb70ca18078bb9201ce6cbf4ea81c05ae4ea68 Gerrit-Change-Number: 40279 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>