Attention is currently required from: lynxis lazus.
Jenkins Builder has posted comments on this change by lynxis lazus. (
https://gerrit.osmocom.org/c/osmo-ggsn/+/40436?usp=email )
Change subject: gsn: fix coding style issue
......................................................................
Patch Set 3:
(9 comments)
File include/osmocom/gtp/gsn.h:
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/5950c9ec_1e32457f?us… :
PS3, Line 141: int (*cb_data_ind)(struct pdp_t * pdp,
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/d228c651_915a2253?us… :
PS3, Line 150: int (*cb)(struct sockaddr_in * peer));
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/f2465b6d_b908b996?us… :
PS3, Line 153: int (*cb)(struct sockaddr_in * peer));
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/a63452a6_beeb94ea?us… :
PS3, Line 156: int (*cb)(struct sockaddr_in * peer, union gtpie_member **ie));
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/decc9119_478a19cb?us… :
PS3, Line 159: int (*cb)(int type, int cause, struct pdp_t * pdp,
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/a617a413_f11ac614?us… :
PS3, Line 163: int (*cb)(struct sockaddr_in * peer,
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/2fee8f8d_8803629c?us… :
PS3, Line 167: int (*cb)(struct sockaddr_in * peer,
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/f3a5ec93_a1e12d6a?us… :
PS3, Line 172: int (*cb)(struct gsn_t * gsn, struct sockaddr_in * peer,
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/99e81dbf_04a00282?us… :
PS3, Line 172: int (*cb)(struct gsn_t * gsn, struct sockaddr_in * peer,
"foo * bar" should be "foo *bar"
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ggsn/+/40436?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I1d978ed32619b626e82aa70887ac94b82c4de378
Gerrit-Change-Number: 40436
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 04 Jun 2025 17:16:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No