Attention is currently required from: pespin.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/30119
)
Change subject: [codecs filter] MO call: apply BSS codec list
......................................................................
Patch Set 2:
(2 comments)
File src/libmsc/gsm_04_08_cc.c:
https://gerrit.osmocom.org/c/osmo-msc/+/30119/comment/1bcc085a_8d9f5358
PS1, Line 619: codec_filter_run(&trans->cc.codecs);
For the sake of clarity understanding what is needed
when I 'd prefer to get rid of it here and appl […]
Done
https://gerrit.osmocom.org/c/osmo-msc/+/30119/comment/d34f5efe_b1007521
PS1, Line 623: ec_filte
actually it is used here. The filter result should make sense for this log line, hence
above run().
But correct, it will be run every time the result is used (or logged).
--
To view, visit
https://gerrit.osmocom.org/c/osmo-msc/+/30119
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I062268406ae3f3a63a7f413db51c509c9eaf9e8a
Gerrit-Change-Number: 30119
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 07 Mar 2023 01:39:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment