Change in osmo-trx[master]: ill-fated ipcv2 for mstrx

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30414 ) Change subject: ill-fated ipcv2 for mstrx ...................................................................... Patch Set 1: (232 comments) File Transceiver52M/device/ipc2/IPCDevice.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/faf18f78_3b209a88 PS1, Line 40: protected: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/da8d7c47_5fd8a540 PS1, Line 41: std::vector<smpl_buf *> rx_buffers; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f69eb1be_69eaf196 PS1, Line 41: std::vector<smpl_buf *> rx_buffers; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b9107110_710b313e PS1, Line 41: std::vector<smpl_buf *> rx_buffers; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/cbbd83e0_d13e25d2 PS1, Line 41: std::vector<smpl_buf *> rx_buffers; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/72a2874e_a3f1954f PS1, Line 48: std::vector<double> tx_gains, rx_gains; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6979dd75_8841521b PS1, Line 48: std::vector<double> tx_gains, rx_gains; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d05158dd_fb2c4e9e PS1, Line 48: std::vector<double> tx_gains, rx_gains; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/7db861c9_8de7fd5f PS1, Line 57: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9e90e2aa_c0d4de9f PS1, Line 60: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/88e59e92_82680afd PS1, Line 60: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e73d2cce_f61ca6c4 PS1, Line 60: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e0507434_8aadde25 PS1, Line 60: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/08c161e8_bb98c15d PS1, Line 64: virtual int open(const std::string &args, int ref, bool swap_channels) override; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/67482bc7_a94fb6e3 PS1, Line 67: virtual bool start() override; Bad function definition - virtual bool start() should probably be virtual bool start(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e878f243_24916a65 PS1, Line 70: virtual bool stop() override; Bad function definition - virtual bool stop() should probably be virtual bool stop(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/7df02f44_d668940e PS1, Line 73: enum TxWindowType getWindowType() override Bad function definition - enum TxWindowType getWindowType() should probably be enum TxWindowType getWindowType(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/992891d8_db1f3c9a PS1, Line 87: virtual int readSamples(std::vector<short *> &buf, int len, bool *overrun, TIMESTAMP timestamp = 0xffffffff, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/507b7ee6_79626fcf PS1, Line 87: virtual int readSamples(std::vector<short *> &buf, int len, bool *overrun, TIMESTAMP timestamp = 0xffffffff, need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/caa4c961_e0b82ea9 PS1, Line 87: virtual int readSamples(std::vector<short *> &buf, int len, bool *overrun, TIMESTAMP timestamp = 0xffffffff, spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/41d143a0_80f7ded6 PS1, Line 97: virtual int writeSamples(std::vector<short *> &bufs, int len, bool *underrun, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/27ea8225_ec0d95cd PS1, Line 97: virtual int writeSamples(std::vector<short *> &bufs, int len, bool *underrun, need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/666021b0_eccdcd2e PS1, Line 97: virtual int writeSamples(std::vector<short *> &bufs, int len, bool *underrun, spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/49d88170_f87ddf0a PS1, Line 98: TIMESTAMP timestamp = 0xffffffff) override; Statements should start on a tabstop Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/3351f992_ffd7be67 PS1, Line 116: virtual double fullScaleInputValue() override Bad function definition - virtual double fullScaleInputValue() should probably be virtual double fullScaleInputValue(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/93771c33_90a1f643 PS1, Line 122: virtual double fullScaleOutputValue() override Bad function definition - virtual double fullScaleOutputValue() should probably be virtual double fullScaleOutputValue(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a161827f_06e035fd PS1, Line 154: virtual bool setRxAntenna(const std::string &ant, size_t chan = 0) override; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/4f0cb189_c3bd5331 PS1, Line 160: virtual bool setTxAntenna(const std::string &ant, size_t chan = 0) override; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a2b65b79_834023a0 PS1, Line 166: virtual bool requiresRadioAlign() override; Bad function definition - virtual bool requiresRadioAlign() should probably be virtual bool requiresRadioAlign(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/03bedd64_63b903c6 PS1, Line 180: virtual inline double getSampleRate() override Bad function definition - virtual inline double getSampleRate() should probably be virtual inline double getSampleRate(void) File Transceiver52M/device/ipc2/ipcif.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/1b4d5bbd_29008425 PS1, Line 35: using sample_t = std::complex<int16_t>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/1b2b40b0_699fd266 PS1, Line 35: using sample_t = std::complex<int16_t>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/48cb7dde_91a4b7c2 PS1, Line 37: std::atomic<bool> ms_connected; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a3fbf5c4_9313d15b PS1, Line 37: std::atomic<bool> ms_connected; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9d885201_4dc2bf4a PS1, Line 37: std::atomic<bool> ms_connected; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a8e81637_e3113ace PS1, Line 39: shm::sema r; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b692d8e5_30a41e2b PS1, Line 40: shm::sema w; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6cac1365_2d9e0cab PS1, Line 41: std::atomic<uint64_t> ts; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/603a594a_36f213e5 PS1, Line 41: std::atomic<uint64_t> ts; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2f59e436_fe52c740 PS1, Line 41: std::atomic<uint64_t> ts; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b7f1fc7a_69b1c861 PS1, Line 42: std::atomic<uint64_t> ts_req; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/7e7ba404_581d44fa PS1, Line 42: std::atomic<uint64_t> ts_req; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/48f357b6_912a4f3a PS1, Line 42: std::atomic<uint64_t> ts_req; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/12ec6fd1_6ef7ee5f PS1, Line 43: std::atomic<size_t> len_written_sps; // -> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/3564acc8_ebdd6fcf PS1, Line 43: std::atomic<size_t> len_written_sps; // -> spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d59929e4_6c981aca PS1, Line 43: std::atomic<size_t> len_written_sps; // -> labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f682e3dc_f23fb5ca PS1, Line 47: shm::sema r; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/47c17d48_8e5fa5fb PS1, Line 48: shm::sema w; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b930362b_8721c36e PS1, Line 49: std::atomic<uint64_t> ts; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9f982104_deeec94a PS1, Line 49: std::atomic<uint64_t> ts; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b8074b27_515476bf PS1, Line 49: std::atomic<uint64_t> ts; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/c4f0433a_2a4a6394 PS1, Line 50: std::atomic<uint64_t> ts_req; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/5e4c73e8_82739732 PS1, Line 50: std::atomic<uint64_t> ts_req; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/62830640_67a1c69d PS1, Line 50: std::atomic<uint64_t> ts_req; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/590e9e5c_da6c4596 PS1, Line 51: std::atomic<size_t> len_written_sps; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9ad3d947_9b8fda3c PS1, Line 51: std::atomic<size_t> len_written_sps; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/032ab91f_f574d9aa PS1, Line 51: std::atomic<size_t> len_written_sps; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6f137bf4_7a1585c7 PS1, Line 58: template <typename A> auto unsigned_diff(A a, A b) -> typename std::make_signed<A>::type spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/89bb5ddb_d9b18b04 PS1, Line 58: template <typename A> auto unsigned_diff(A a, A b) -> typename std::make_signed<A>::type spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/54d96d29_df6d3e34 PS1, Line 58: template <typename A> auto unsigned_diff(A a, A b) -> typename std::make_signed<A>::type spaces prohibited around that '->' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/5a6c5c6e_4d8a0841 PS1, Line 58: template <typename A> auto unsigned_diff(A a, A b) -> typename std::make_signed<A>::type spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9c61ab70_a8449ad0 PS1, Line 58: template <typename A> auto unsigned_diff(A a, A b) -> typename std::make_signed<A>::type spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f34afbd6_a839699a PS1, Line 60: using stype = typename std::make_signed<A>::type; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/36db1e31_f6681fab PS1, Line 60: using stype = typename std::make_signed<A>::type; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/7ece2b1d_4f899fb8 PS1, Line 61: return (a > b) ? static_cast<stype>(a - b) : -static_cast<stype>(b - a); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b001c953_7656615f PS1, Line 61: return (a > b) ? static_cast<stype>(a - b) : -static_cast<stype>(b - a); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ff41568e_d7fd9071 PS1, Line 61: return (a > b) ? static_cast<stype>(a - b) : -static_cast<stype>(b - a); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2e69f945_32b57171 PS1, Line 61: return (a > b) ? static_cast<stype>(a - b) : -static_cast<stype>(b - a); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/c3a56e88_be00741e PS1, Line 90: template <unsigned int num_bursts> class ulburstprovider { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/310e18b9_633a28e2 PS1, Line 90: template <unsigned int num_bursts> class ulburstprovider { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/975d32e8_d6acda13 PS1, Line 91: std::mutex ul_q_m; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/8c6ff45c_7a7398e3 PS1, Line 98: void cur_buf_done() Bad function definition - void cur_buf_done() should probably be void cur_buf_done(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/abe16f1d_66a88857 PS1, Line 98: void cur_buf_done() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/99e0c51a_1dd96696 PS1, Line 103: bool is_empty() Bad function definition - bool is_empty() should probably be bool is_empty(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/98a2aa1c_27d25c70 PS1, Line 103: bool is_empty() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/de023be0_d76497e8 PS1, Line 107: void reset() Bad function definition - void reset() should probably be void reset(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/57c93392_307d6a96 PS1, Line 107: void reset() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/cd616170_033aaccb PS1, Line 109: for (auto &i : foo) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/96f7b2bd_3b06f62d PS1, Line 113: ulentry &find_free_at_end() need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9cb1d4fe_bd0fbddf PS1, Line 123: void push_back(ulentry &e) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f4c3864a_cd39c420 PS1, Line 123: void push_back(ulentry &e) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/75a0769a_a22c2094 PS1, Line 130: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/673db00e_ce570434 PS1, Line 131: void add(ulentry &e) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/39da4ffa_71b81bcc PS1, Line 131: void add(ulentry &e) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/c785a7e0_498f33d0 PS1, Line 133: std::lock_guard<std::mutex> foo(ul_q_m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d714364e_44e3059b PS1, Line 133: std::lock_guard<std::mutex> foo(ul_q_m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/49418a20_21c97e5b PS1, Line 133: std::lock_guard<std::mutex> foo(ul_q_m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/deb7feac_97c57f8d PS1, Line 136: void get(uint64_t requested_ts, unsigned int req_len_in_sps, sample_t *buf, unsigned int max_buf_write_len) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/0afc5520_5c14c39f PS1, Line 138: std::lock_guard<std::mutex> g(ul_q_m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/5cb43d88_00d8b808 PS1, Line 138: std::lock_guard<std::mutex> g(ul_q_m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e94aae72_ce5fccdf PS1, Line 138: std::lock_guard<std::mutex> g(ul_q_m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/c995a2a1_b3a813bd PS1, Line 203: shm::shm<shm_if> m; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e50c228d_f4bb6911 PS1, Line 203: shm::shm<shm_if> m; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/78164afb_a2619e0e PS1, Line 203: shm::shm<shm_if> m; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/cd209117_38482000 PS1, Line 206: ulburstprovider<10> p; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/783d6c2d_b32df518 PS1, Line 206: ulburstprovider<10> p; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/136259d0_54500fb7 PS1, Line 208: template <typename T> void read(T &direction, size_t howmany_sps, uint64_t *read_ts, sample_t *outbuf) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/46bfa34c_21bacf57 PS1, Line 208: template <typename T> void read(T &direction, size_t howmany_sps, uint64_t *read_ts, sample_t *outbuf) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/56a7c510_8c1402bb PS1, Line 208: template <typename T> void read(T &direction, size_t howmany_sps, uint64_t *read_ts, sample_t *outbuf) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/3f08fdbd_df063cbe PS1, Line 217: shm::mtx_log::print_guard() << "\tr @" << direction.ts.load() << " " << readoffset_sps << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/5deb2d8e_bdcb2b5d PS1, Line 235: shm::mtx_log::print_guard() << "\tr+ " << *read_ts << " " << howmany_sps << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/56c7c09f_37751282 PS1, Line 247: shm::mtx_log::print_guard() << "\tr++ " << *read_ts << " " << howmany_sps << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/81437850_877af9b7 PS1, Line 249: } else { else is not generally useful after a break or return Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/95d532c2_9ba61f3e PS1, Line 263: shm::mtx_log::print_guard() labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e1bd5e81_5f0fe87d PS1, Line 270: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ab367ed9_735f408d PS1, Line 275: bool create() Bad function definition - bool create() should probably be bool create(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/c1f7f3f3_24ee5f6d PS1, Line 275: bool create() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/99d97af4_c10dfc68 PS1, Line 281: bool connect() Bad function definition - bool connect() should probably be bool connect(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/8a569ff6_0ad86d1b PS1, Line 281: bool connect() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f60377a1_0fc6fdc9 PS1, Line 289: bool good() Bad function definition - bool good() should probably be bool good(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6353524e_0c0bd3e3 PS1, Line 289: bool good() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/80475acb_8ed1ec9b PS1, Line 293: bool is_connected() Bad function definition - bool is_connected() should probably be bool is_connected(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/c7155efd_5931a8f7 PS1, Line 293: bool is_connected() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/38122db5_c4a32d88 PS1, Line 299: void read_dl(size_t howmany_sps, uint64_t *read_ts, sample_t *outbuf) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/418406bb_06ce036a PS1, Line 305: void read_ul(size_t howmany_sps, uint64_t *read_ts, sample_t *outbuf) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f0f33af9_290941f5 PS1, Line 309: // return; please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/54a026bc_a08db990 PS1, Line 314: void write_dl(size_t howmany_sps, uint64_t write_ts, sample_t *inbuf) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/0a0cc41d_b082e43e PS1, Line 316: auto &dl = ptr->dl; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e2c028bf_9be23356 PS1, Line 325: shm::sema_wait_guard g(dl.w, dl.r); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/03b0fc44_b8f56c2b PS1, Line 331: shm::mtx_log::print_guard() << std::endl labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/50c3d639_1a937ad2 PS1, Line 336: void write_ul(size_t howmany_sps_sps, uint64_t write_ts, sample_t *inbuf) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b049e060_0a12ff93 PS1, Line 338: auto &ul = ptr->ul; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/794dac31_79323e42 PS1, Line 351: shm::mtx_log::print_guard() << std::endl labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/fd9b08bb_e5225a11 PS1, Line 356: void drive_tx() Bad function definition - void drive_tx() should probably be void drive_tx(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/61488fb1_bba7f263 PS1, Line 356: void drive_tx() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/c4bd8fba_ed7fd4dc PS1, Line 358: auto &ul = ptr->ul; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6b54fe19_23780f4a PS1, Line 384: void signal_read_start() Bad function definition - void signal_read_start() should probably be void signal_read_start(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a4da10c3_f74d5e2b PS1, Line 384: void signal_read_start() open brace '{' following function definitions go on the next line File Transceiver52M/device/ipc2/shmif.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/1b7dbc6a_2d4f9e8f PS1, Line 46: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/8c083523_82714d9b PS1, Line 49: std::lock_guard<std::mutex> guard(thread_print_lock); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/591ce811_b64ba584 PS1, Line 49: std::lock_guard<std::mutex> guard(thread_print_lock); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/022a0800_235c9a1b PS1, Line 49: std::lock_guard<std::mutex> guard(thread_print_lock); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2cb0a9f6_be0a9126 PS1, Line 50: std::cerr << str(); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/72933e3a_24cd22d4 PS1, Line 57: template <typename T> constexpr print_guard operator<<(const print_guard dummy, T &&value) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/96f42e91_3d10bb14 PS1, Line 57: template <typename T> constexpr print_guard operator<<(const print_guard dummy, T &&value) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/02eb618e_74874020 PS1, Line 57: template <typename T> constexpr print_guard operator<<(const print_guard dummy, T &&value) spaces required around that '&&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/79d2b144_36b28c4c PS1, Line 62: constexpr print_guard operator<<(const print_guard &dummy, std::ostream &(*f)(std::ostream &)) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/5b9516d2_3a29038a PS1, Line 62: constexpr print_guard operator<<(const print_guard &dummy, std::ostream &(*f)(std::ostream &)) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b608f401_5d461917 PS1, Line 73: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/3c72ab1d_b46c6541 PS1, Line 89: void lock() Bad function definition - void lock() should probably be void lock(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6168b6f6_4d5cd647 PS1, Line 89: void lock() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/8082436a_e82146a0 PS1, Line 94: bool try_lock() Bad function definition - bool try_lock() should probably be bool try_lock(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9eb03bf6_daa5a3ce PS1, Line 94: bool try_lock() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/813b617d_bb0810b5 PS1, Line 99: void unlock() Bad function definition - void unlock() should probably be void unlock(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6bbc2f6a_411cf0d0 PS1, Line 99: void unlock() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/def2b641_14fc2dd4 PS1, Line 104: pthread_mutex_t *p() Bad function definition - pthread_mutex_t *p() should probably be pthread_mutex_t *p(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/df47252f_076a8602 PS1, Line 104: pthread_mutex_t *p() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/564a05c0_fcddf8bd PS1, Line 109: shmmutex &operator=(const shmmutex &) = delete; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9039e2e5_e026b35e PS1, Line 109: shmmutex &operator=(const shmmutex &) = delete; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/47f1348e_f41ef512 PS1, Line 115: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/c12647c3_a69ff939 PS1, Line 130: void wait(shmmutex *lock) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/817489f5_f3742b53 PS1, Line 135: void signal() Bad function definition - void signal() should probably be void signal(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/72f3323f_713e300b PS1, Line 135: void signal() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/da823f35_64c3271f PS1, Line 140: void signal_all() Bad function definition - void signal_all() should probably be void signal_all(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ef8323e7_7a935b3f PS1, Line 140: void signal_all() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ba8b3c75_7fa86b2f PS1, Line 145: shmcond &operator=(const shmcond &) = delete; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/712164c8_b2de9079 PS1, Line 145: shmcond &operator=(const shmcond &) = delete; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/1d29dca2_b85af691 PS1, Line 149: shmmutex &m; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6f9dd390_d74f1a12 PS1, Line 150: shmcond &s; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/af20f095_f52d6222 PS1, Line 152: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/76139a73_55e8ee36 PS1, Line 154: explicit signal_guard(shmmutex &m, shmcond &wait_for, shmcond &to_signal) : m(m), s(to_signal) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ca08be2f_47f41cf7 PS1, Line 154: explicit signal_guard(shmmutex &m, shmcond &wait_for, shmcond &to_signal) : m(m), s(to_signal) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/631d17b5_d496185f PS1, Line 154: explicit signal_guard(shmmutex &m, shmcond &wait_for, shmcond &to_signal) : m(m), s(to_signal) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/61331542_bca4d452 PS1, Line 165: signal_guard &operator=(const signal_guard &) = delete; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/143d0c12_df9be473 PS1, Line 165: signal_guard &operator=(const signal_guard &) = delete; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/140c1c80_8900a9f9 PS1, Line 169: shmmutex &m; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/78512a2d_c31bf64b PS1, Line 171: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/db6dab36_89a9406f PS1, Line 173: explicit mutex_guard(shmmutex &m) : m(m) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d4d22ab8_1fb85e1b PS1, Line 182: mutex_guard &operator=(const mutex_guard &) = delete; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a8e03339_5da0763a PS1, Line 182: mutex_guard &operator=(const mutex_guard &) = delete; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/701b2f6d_1cf99a77 PS1, Line 186: std::atomic<int> value; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/854190c8_6e5e987a PS1, Line 186: std::atomic<int> value; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/93503d51_ba408a55 PS1, Line 186: std::atomic<int> value; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/7721f677_8a237cff PS1, Line 190: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ce064d68_e8213f4a PS1, Line 198: void wait() Bad function definition - void wait() should probably be void wait(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f651b64d_11bd25a4 PS1, Line 198: void wait() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2259fecb_442146bc PS1, Line 202: void wait(int v) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/fdba8b0a_00a6ad2a PS1, Line 204: mtx_log::print_guard() << __FUNCTION__ << value << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/45dbaaab_da28562f PS1, Line 204: mtx_log::print_guard() << __FUNCTION__ << value << std::endl; __func__ should be used instead of gcc specific __FUNCTION__ Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/1abede98_ca99a563 PS1, Line 205: mutex_guard g(m); function definition argument 'm' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/80952fea_25547cb1 PS1, Line 210: void wait_and_reset() Bad function definition - void wait_and_reset() should probably be void wait_and_reset(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6ea7712a_38e72f42 PS1, Line 210: void wait_and_reset() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/595bbe7b_6cfba558 PS1, Line 214: void wait_and_reset(int v) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/157d4220_2d5c47d7 PS1, Line 216: mtx_log::print_guard() << __FUNCTION__ << value << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/dd063074_14221f5e PS1, Line 216: mtx_log::print_guard() << __FUNCTION__ << value << std::endl; __func__ should be used instead of gcc specific __FUNCTION__ Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/cc84898d_20baf114 PS1, Line 217: mutex_guard g(m); function definition argument 'm' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f4400fd8_d06be084 PS1, Line 223: void set() Bad function definition - void set() should probably be void set(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e70912a4_4629ec31 PS1, Line 223: void set() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/01aa0533_7b069011 PS1, Line 227: void set(int v) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/0282c5de_60b08046 PS1, Line 229: mtx_log::print_guard() << __FUNCTION__ << value << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/c5676052_f0b4fd61 PS1, Line 229: mtx_log::print_guard() << __FUNCTION__ << value << std::endl; __func__ should be used instead of gcc specific __FUNCTION__ Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d004ea89_93e83d9c PS1, Line 230: mutex_guard g(m); function definition argument 'm' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/3d65daef_d35a76d9 PS1, Line 234: void reset_unsafe() Bad function definition - void reset_unsafe() should probably be void reset_unsafe(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/23fa7cfb_86288edb PS1, Line 234: void reset_unsafe() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6020f137_521133fd PS1, Line 238: bool check_unsafe(int v) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/8af80bdc_8687baed PS1, Line 243: sema &operator=(const sema &) = delete; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/81d5d6c8_2b443de6 PS1, Line 243: sema &operator=(const sema &) = delete; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/69a924e9_8b2dafd8 PS1, Line 247: sema &a; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/cfbbe01d_32e26ff2 PS1, Line 248: sema &b; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/995dd13e_5957bcf1 PS1, Line 250: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a0315420_729979e4 PS1, Line 252: explicit sema_wait_guard(sema &wait, sema &signal) : a(wait), b(signal) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9c09e1ff_32fbd6cf PS1, Line 252: explicit sema_wait_guard(sema &wait, sema &signal) : a(wait), b(signal) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/89c213e4_f9242f39 PS1, Line 261: sema_wait_guard &operator=(const sema_wait_guard &) = delete; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/999672fc_5e31a25a PS1, Line 261: sema_wait_guard &operator=(const sema_wait_guard &) = delete; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/7c630848_2193cf4b PS1, Line 265: sema &a; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a74e400b_ea4b3e69 PS1, Line 266: sema &b; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/10b57a15_4a4479c4 PS1, Line 268: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/afc3dd65_953719c4 PS1, Line 270: explicit sema_signal_guard(sema &wait, sema &signal) : a(wait), b(signal) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a3b06361_b9300cae PS1, Line 270: explicit sema_signal_guard(sema &wait, sema &signal) : a(wait), b(signal) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2f7d5271_57395807 PS1, Line 279: sema_signal_guard &operator=(const sema_signal_guard &) = delete; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9e3d3262_f923306d PS1, Line 279: sema_signal_guard &operator=(const sema_signal_guard &) = delete; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d4edb02b_409eb610 PS1, Line 282: template <typename IFT> class shm { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/00a7e5a6_69b1d24d PS1, Line 282: template <typename IFT> class shm { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b18896f4_6e759e1e PS1, Line 287: int ipc_shm_setup(const char *shm_name) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/1a0503dc_9dd1f393 PS1, Line 293: if ((fd = shm_open(shm_name, O_CREAT | O_RDWR | O_TRUNC, S_IRUSR | S_IWUSR)) < 0) { Symbolic permissions 'S_IRUSR | S_IWUSR' are not preferred. Consider using octal permissions '0600'. Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/29dc7ec8_e2a85cbd PS1, Line 310: shmptr = new (ptr) IFT(); //static_cast<IFT *>(ptr); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/96430888_d69dbf40 PS1, Line 315: int ipc_shm_connect(const char *shm_name) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/99bd7396_b995416b PS1, Line 321: if ((fd = shm_open(shm_name, O_CREAT | O_RDWR, S_IRUSR | S_IWUSR)) < 0) { Symbolic permissions 'S_IRUSR | S_IWUSR' are not preferred. Consider using octal permissions '0600'. Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/93482a09_4be20edf PS1, Line 339: shmptr = static_cast<IFT *>(ptr); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/5f50bb97_4450ea8f PS1, Line 339: shmptr = static_cast<IFT *>(ptr); need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d735996c_a35a65ba PS1, Line 339: shmptr = static_cast<IFT *>(ptr); spaces required around that '>' (ctx:OxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ab39457b_0ece9f1f PS1, Line 344: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/7840db88_5ce8d4ca PS1, Line 348: strncpy((char *)shmname, name, 512); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b7cc284a_d9bfb239 PS1, Line 350: void create() Bad function definition - void create() should probably be void create(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a48f2fd9_8b9db6b1 PS1, Line 350: void create() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d10aa3e7_1993c519 PS1, Line 355: void open() Bad function definition - void open() should probably be void open(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/186221ff_5aa1f0ce PS1, Line 355: void open() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/c2e3cabd_4e83605d PS1, Line 360: bool isgood() const Bad function definition - bool isgood() should probably be bool isgood(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/87617113_0c31b708 PS1, Line 364: void close() Bad function definition - void close() should probably be void close(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b4456f6b_48c15615 PS1, Line 364: void close() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ad6daf91_32144a1e PS1, Line 369: IFT *p() Bad function definition - IFT *p() should probably be IFT *p(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/fd443659_128f8239 PS1, Line 369: IFT *p() open brace '{' following function definitions go on the next line -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30414 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I8f582c7c06fed8d1dcc5ea52472a97dc313fdde5 Gerrit-Change-Number: 30414 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen &lt;ewild(a)sysmocom.de&gt; Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 01 Dec 2022 11:01:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment