6 Jun
2023
6 Jun
'23
5:07 p.m.
Jenkins Builder has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/33197 )
Change subject: stream: Add server-side (segmentation) support for IPAC
......................................................................
Patch Set 1:
(4 comments)
File tests/stream/stream_test.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7904):
https://gerrit.osmocom.org/c/libosmo-netif/+/33197/comment/6408b110_1817eac9
PS1, Line 397: #define ipac_msg_idreq_half (sizeof (ipac_msg_idreq)/2)
space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7904):
https://gerrit.osmocom.org/c/libosmo-netif/+/33197/comment/23185ed9_3f62419c
PS1, Line 398: #define ipac_msg_idreq_other_half (sizeof (ipac_msg_idreq) -
ipac_msg_idreq_half)
space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7904):
https://gerrit.osmocom.org/c/libosmo-netif/+/33197/comment/3050c289_80756db9
PS1, Line 408: (unsigned_char_ptr) = msgb_put(struct_msgb_ptr, sizeof (byte_array));\
space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7904):
https://gerrit.osmocom.org/c/libosmo-netif/+/33197/comment/6827917f_e9a3ff6e
PS1, Line 409: memcpy(unsigned_char_ptr, byte_array, sizeof (byte_array));\
space prohibited between function name and open parenthesis '('
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33197
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I6c91ff385cb5f36ab6b6c96d0e44997995d0d24c
Gerrit-Change-Number: 33197
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Tue, 06 Jun 2023 15:07:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment