[L] Change in pysim[master]: pySim/transport add support for T=1 protocol and fix APDU/TPDU layer ...

Attention is currently required from: laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38657?usp=email ) Change subject: pySim/transport add support for T=1 protocol and fix APDU/TPDU layer conflicts ...................................................................... Patch Set 2: (2 comments) File pySim/transport/__init__.py: https://gerrit.osmocom.org/c/pysim/+/38657/comment/2193af2f_e7b49cf0?usp=em… : PS1, Line 243: cl Sure we can do that. Then let's have a LinkBase base class and a class LinkBaseTpdu that inherits from it. We inherit LinkBase directly in cases where the transport layer implementation works on APDU level. In cases where the transport layer implementation requires TPDUs, would inherit a class LinkBaseTpdu. https://gerrit.osmocom.org/c/pysim/+/38657/comment/9f95ca15_28441478?usp=em… : PS1, Line 320: __send_apdu_T1 Yes, this is true, there is no T=1 specific stuff happening in the method. It just passes the APDUs as TPDUs transparently. we may call this method differently so that it is more generic. So should we add T15 support one day, we won't have to add a __send_apdu_T15 method which would be just a copy of __send_apdu_T1 then. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38657?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8b56d7804a2b4c392f43f8540e0b6e70001a8970 Gerrit-Change-Number: 38657 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 12 Nov 2024 15:26:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>