Attention is currently required from: jolly.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/32931 )
Change subject: ASCI: Add IE transcoding according to 3GPP TS 48.008
......................................................................
Patch Set 1:
(3 comments)
File include/osmocom/gsm/gsm0808_utils.h:
https://gerrit.osmocom.org/c/libosmocore/+/32931/comment/cee021ca_b443b47a
PS1, Line 26: stru
unrelated removal?
https://gerrit.osmocom.org/c/libosmocore/+/32931/comment/26cd2555_a6a620ee
PS1, Line 66: struct gsm0808_priority {
here the gsm0808_ prefix is fine ,as
a) we use that anyway for lots of existing code
b) you are extending existing code (unlike gcc where it's completely new code)
https://gerrit.osmocom.org/c/libosmocore/+/32931/comment/46ff55c2_a0f48340
PS1, Line 67: /* Preemtion Capability indicator */
Preemption ?(also below)
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/32931
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic1fc714bb04228a7f32e9925811e21c8efc610bd
Gerrit-Change-Number: 32931
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Tue, 23 May 2023 15:15:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment