Attention is currently required from: falconia, laforge, dexter.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/32968
)
Change subject: all models, HR1 codec: accept both TS101318 and RFC5993 formats
......................................................................
Patch Set 3:
(1 comment)
File src/common/rtp_input_preen.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32968/comment/23edaa4e_75b40d26
PS3, Line 93: return PL_DECISION_STRIP_HDR_OCTET;
my question here is: we are dropping some ToC information. Won't we need that
information later on in the path? looks like we are losing/discarding this kind of
information here. (disclaimer: I don't know what the ToC byte contains, a summary
would be welcome).
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/32968
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I702e26c3ad5b9d8347e73c6cd23efa38a3a3407e
Gerrit-Change-Number: 32968
Gerrit-PatchSet: 3
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 25 May 2023 11:29:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment