Attention is currently required from: laforge, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/32575 )
Change subject: trxcon: get rid of the timer driven clock module
......................................................................
Patch Set 3:
(3 comments)
File src/host/trxcon/src/trx_if.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/32575/comment/4c47b592_63016590
PS2, Line 707: .fn = bi.fn,
the trx_fn_advance may still make sense to be possible
to apply it here?
I like the idea, thanks! Implemented in the new patchset.
https://gerrit.osmocom.org/c/osmocom-bb/+/32575/comment/27b22f13_1b5ac0ef
PS2, Line 711: trxcon_phyif_handle_rts_ind(trx->priv, &rts);
does that mean that now if we don't receive DL
data, we'll never to UL RTS.ind?
Correct.
Is that supposed to work because the BTS is expected
to always send data?
Ack.
File src/host/trxcon/src/trxcon_main.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/32575/comment/be6edbc7_acd9a0a6
PS2, Line 244: XXX: no-op
Ack
Not needed, this param will remain
operational.
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/32575
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ic8a5b6277c6b16392026e0557376257d71c9d230
Gerrit-Change-Number: 32575
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 04 Jun 2023 21:31:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment