Change in osmocom-bb[master]: layer23: Introduce netdev.{c,h}

Attention is currently required from: pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30993 ) Change subject: layer23: Introduce netdev.{c,h} ...................................................................... Patch Set 2: (42 comments) File src/host/layer23/include/osmocom/bb/common/netdev.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/64e27442_179cee72 PS2, Line 33: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/999145ab_69e4914c PS2, Line 33: { open brace '{' following struct go on the same line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/1c86fad6_960062b9 PS2, Line 35: unsigned int ihl:4; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/74ec1f06_8c6c2823 PS2, Line 36: unsigned int version:4; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/15c1f615_66d169c8 PS2, Line 38: unsigned int version:4; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/a0e25071_6f50b0cc PS2, Line 39: unsigned int ihl:4; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/f71e5075_cff6a1ee PS2, Line 43: u_int8_t tos; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/9867f050_fd762fea PS2, Line 44: u_int16_t tot_len; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/e187b552_bade468f PS2, Line 45: u_int16_t id; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/42c22df0_b9b3d2a4 PS2, Line 46: u_int16_t frag_off; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/8302801e_dbb0329f PS2, Line 47: u_int8_t ttl; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/5f6791c0_f4f2f2bf PS2, Line 48: u_int8_t protocol; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/f2ed034f_01b1d5d6 PS2, Line 49: u_int16_t check; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/2331b886_2fb9fb4d PS2, Line 50: u_int32_t saddr; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/91d581e4_e8997f47 PS2, Line 51: u_int32_t daddr; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/8ea9c984_3ecfeb5b PS2, Line 53: }; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/5f9086ef_84854b9f PS2, Line 57: struct osmo_sockaddr addr; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/07a1b548_aaea6acf PS2, Line 58: uint8_t prefixlen; please, no spaces at the start of a line File src/host/layer23/src/common/netdev.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/f062a5ce_306cbeed PS2, Line 45: #elif defined (__FreeBSD__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/2c8f8e72_0395be2e PS2, Line 49: #elif defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/68126dfd_269ff956 PS2, Line 61: #define SYS_ERR(sub, pri, en, fmt, args...) \ Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/8ceb15ae_cd23f90f PS2, Line 97: strncpy(ifr.ifr_name, devname, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/63958b21_1ce5dfcb PS2, Line 125: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/fe4e7a7b_a6774d28 PS2, Line 132: strncpy(ifr.ifr_name, devname, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/aff87f7a_24759175 PS2, Line 160: if (ioctl(fd, SIOCSIFDSTADDR, (caddr_t) & ifr) < 0) { space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/d38f0191_826d1f83 PS2, Line 172: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/06555899_f1a1e524 PS2, Line 191: #if defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/c1efc235_ff76550a PS2, Line 213: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/1157a443_56d19b1d PS2, Line 214: strncpy(ifr.ifr_name, devname, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/9ea3b1c8_cb9d31d3 PS2, Line 249: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/bf9e92cc_efe0a2ef PS2, Line 381: #elif defined (__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/f3f8fc7b_df50acbc PS2, Line 381: #elif defined (__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/2907c4cb_86a2abc2 PS2, Line 387: strncpy(areq.ifra_name, devname, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/12da3787_7fe0c2ab PS2, Line 530: #elif defined (__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/d8cdbc34_35624d39 PS2, Line 530: #elif defined (__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/e031a659_8b34c9f1 PS2, Line 536: strncpy(areq.ifra_name, devname, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/07bcdae2_fa99c4d0 PS2, Line 608: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/7e7c0559_b5fb91c9 PS2, Line 677: strncpy(ifr.ifr_name, gw_iface, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/f4926312_d5cfba4e PS2, Line 751: static const uint8_t ll_prefix[] = { 0xfe,0x80, 0,0, 0,0, 0,0 }; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/d7101aeb_70903e17 PS2, Line 751: static const uint8_t ll_prefix[] = { 0xfe,0x80, 0,0, 0,0, 0,0 }; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/93753615_2e48fef6 PS2, Line 751: static const uint8_t ll_prefix[] = { 0xfe,0x80, 0,0, 0,0, 0,0 }; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/8ff44a7e_ea90999e PS2, Line 751: static const uint8_t ll_prefix[] = { 0xfe,0x80, 0,0, 0,0, 0,0 }; space required after that ',' (ctx:VxV) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30993 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I6085dc6861687bd4e9c32e86221c0375ad95ba22 Gerrit-Change-Number: 30993 Gerrit-PatchSet: 2 Gerrit-Owner: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Comment-Date: Tue, 17 Jan 2023 10:04:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment