Attention is currently required from: osmith.
pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/docker-playground/+/40260?usp=email )
Change subject: nplab: don't use deprecated git.osmocom.org
......................................................................
Patch Set 1:
(1 comment)
File nplab-sua-test/Dockerfile:
https://gerrit.osmocom.org/c/docker-playground/+/40260/comment/bfeb6894_a75… :
PS1, Line 6: RUN cd /tmp && git clone https://gitea.osmocom.org/nplab/sua-testtool
it rings a bell that I was able to get some sort of URL to check the cache with gitea in the past, but I don't recall exactly tbh.
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/40260?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: If6859323b5af3bd13a974cd1d676d4f19aa16773
Gerrit-Change-Number: 40260
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 08 May 2025 10:28:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: laforge, pespin.
clufn has posted comments on this change by clufn. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255?usp=email )
Change subject: Add required conversions for IPv6 and IPv4v6 support
......................................................................
Patch Set 7:
(1 comment)
File src/conv.erl:
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255/comment/9e8c14e6_d515… :
PS5, Line 136: ipv6 = remove_prefix(Addr)};
> Ok, so IIUC you are removing the "IPv6 Prefix Length" byte, not an ipv6 prefix. […]
Done
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I2426e0dcee3ca92075b845f6b21a175a3d047c08
Gerrit-Change-Number: 40255
Gerrit-PatchSet: 7
Gerrit-Owner: clufn <callumfarrbennett(a)yahoo.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 08 May 2025 10:15:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: clufn <callumfarrbennett(a)yahoo.com>
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/40260?usp=email )
Change subject: nplab: don't use deprecated git.osmocom.org
......................................................................
nplab: don't use deprecated git.osmocom.org
Update the git clones to point to gitea. With gitea we apparently don't
have a way to get the current commit's patch via HTTP, as it was
previously done with cgit. This means that the we can't automatically
invalidate the cache when rebuilding the container if the commit
changed.
However given that we very rarely touch the nplab sources, this
should be fine here.
At some future point we could rework this to not clone sources while
building the container.
Change-Id: If6859323b5af3bd13a974cd1d676d4f19aa16773
---
M nplab-m3ua-test/Dockerfile
M nplab-sua-test/Dockerfile
2 files changed, 4 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/60/40260/1
diff --git a/nplab-m3ua-test/Dockerfile b/nplab-m3ua-test/Dockerfile
index 9e4f7c4..2b55871 100644
--- a/nplab-m3ua-test/Dockerfile
+++ b/nplab-m3ua-test/Dockerfile
@@ -1,9 +1,8 @@
ARG USER=osmocom-build
FROM $USER/sigtran-tests
-
-RUN cd /tmp && git clone https://git.osmocom.org/nplab/m3ua-testtool
-ADD http://git.osmocom.org/nplab/m3ua-testtool/patch/?h=laforge/python3 /tmp/commit
+# FIXME: cache doesn't get invalidated when commits change
+RUN cd /tmp && git clone https://gitea.osmocom.org/nplab/m3ua-testtool
RUN cd /tmp/m3ua-testtool && \
git fetch && \
git checkout -f laforge/python3 && \
diff --git a/nplab-sua-test/Dockerfile b/nplab-sua-test/Dockerfile
index 5957c26..f82bcdc 100644
--- a/nplab-sua-test/Dockerfile
+++ b/nplab-sua-test/Dockerfile
@@ -2,8 +2,8 @@
FROM $USER/sigtran-tests
-RUN cd /tmp && git clone https://git.osmocom.org/nplab/sua-testtool
-ADD http://git.osmocom.org/nplab/sua-testtool/patch/?h=laforge/python3 /tmp/commit
+# FIXME: cache doesn't get invalidated when commits change
+RUN cd /tmp && git clone https://gitea.osmocom.org/nplab/sua-testtool
RUN cd /tmp/sua-testtool && \
git fetch && \
git checkout -f laforge/python3 && \
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/40260?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: If6859323b5af3bd13a974cd1d676d4f19aa16773
Gerrit-Change-Number: 40260
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Attention is currently required from: laforge, pespin.
clufn has posted comments on this change by clufn. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255?usp=email )
Change subject: Add required conversions for IPv6 and IPv4v6 support
......................................................................
Patch Set 6:
(1 comment)
File src/conv.erl:
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255/comment/129f340d_c8c0… :
PS5, Line 136: ipv6 = remove_prefix(Addr)};
> Will break my setup to find out what the problem was, cant remember as fixed it 11 months ago, think […]
3GPP TS 29.274 Table 8.14-1: PDN Address Allocation,
If PDN type value indicates IPv6, octet 6 contains the IPv6 Prefix Length. Octets 7
through 22 contain an IPv6 Prefix and Interface Identifier. Bit 8 of octet 7 represents the most significant bit of the IPv6 Prefix and Interface Identifier and bit 1 of octet 22 the least significant bit.
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I2426e0dcee3ca92075b845f6b21a175a3d047c08
Gerrit-Change-Number: 40255
Gerrit-PatchSet: 6
Gerrit-Owner: clufn <callumfarrbennett(a)yahoo.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 08 May 2025 09:50:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: clufn <callumfarrbennett(a)yahoo.com>
Attention is currently required from: laforge, pespin.
clufn has posted comments on this change by clufn. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255?usp=email )
Change subject: Add required conversions for IPv6 and IPv4v6 support
......................................................................
Patch Set 6:
(1 comment)
File src/conv.erl:
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255/comment/411be856_1857… :
PS5, Line 69: remove_prefix(<<A:8, Rest/binary>>) when is_binary(Rest) ->
> can we have a more descriptive name for this one?
Done
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I2426e0dcee3ca92075b845f6b21a175a3d047c08
Gerrit-Change-Number: 40255
Gerrit-PatchSet: 6
Gerrit-Owner: clufn <callumfarrbennett(a)yahoo.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 08 May 2025 09:30:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: laforge, pespin.
clufn has posted comments on this change by clufn. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255?usp=email )
Change subject: Add required conversions for IPv6 and IPv4v6 support
......................................................................
Patch Set 6:
(2 comments)
File src/conv.erl:
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255/comment/c834af81_30ee… :
PS5, Line 72: add_prefix(<<A:8, B:8, C:8, D:8, E:8, F:8, G:8, H:8, I:8, J:8, K:8, L:8, M:8, N:8, O:8, P:8>>) ->
> Then please submit this function when it is needed, not here 😊
Done
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255/comment/ff074784_eafd… :
PS5, Line 136: ipv6 = remove_prefix(Addr)};
> can you point to the related spec, or open a ticket in redmine with a pcap file or similar?
Will break my setup to find out what the problem was, cant remember as fixed it 11 months ago, think it has something to do with GSUP or strongswan
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I2426e0dcee3ca92075b845f6b21a175a3d047c08
Gerrit-Change-Number: 40255
Gerrit-PatchSet: 6
Gerrit-Owner: clufn <callumfarrbennett(a)yahoo.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 08 May 2025 09:29:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: clufn <callumfarrbennett(a)yahoo.com>