May 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: testenv: podman_install: show checked out commits

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40303?usp=email ) Change subject: testenv: podman_install: show checked out commits ...................................................................... testenv: podman_install: show checked out commits When running with --podman --binary-repo and a testsuite needs a component for which we don't have a binary package (such as sccp_demo_user), we need to clone the source and build it. Show the commit from which we are building / have already built the component. Suggested-by: Pau Espin Pedrol <pespin(a)sysmocom.de> Change-Id: I2837a41c919a9f7ef8c315ce5aa48fb4fe3f9a85 --- M _testenv/testenv/podman_install.py 1 file changed, 12 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/_testenv/testenv/podman_install.py b/_testenv/testenv/podman_install.py index 66777a6..a8293ef 100644 --- a/_testenv/testenv/podman_install.py +++ b/_testenv/testenv/podman_install.py @@ -96,9 +96,17 @@ testenv.cmd.run(["apt-get", "-q", "install", "-y", "--no-install-recommends"] + pkgs) +def show_commit(project, cwd): + cmd = ["git", "-P", "-C", cwd, "-c", "color.ui=always", "log", "-1", "--oneline"] + logging.info(f"{project}: showing current commit") + testenv.cmd.run(cmd, no_podman=True) + + def clone_project(project): - if os.path.exists(os.path.join(git_dir, project)): + git_dir_project = os.path.join(git_dir, project) + if os.path.exists(git_dir_project): logging.debug(f"{project}: already cloned") + show_commit(project, git_dir_project) return branch = "master" @@ -129,6 +137,7 @@ url, ] ) + show_commit(project, git_dir_project) def from_source_sccp_demo_user(): @@ -144,8 +153,8 @@ ] ) + clone_project("libosmo-sigtran") if not os.path.exists(sccp_demo_user_path): - clone_project("libosmo-sigtran") logging.info("Building sccp_demo_user") testenv.cmd.run(["autoreconf", "-fi"], cwd=sccp_dir) @@ -170,8 +179,8 @@ libosmocore_dir = os.path.join(git_dir, "libosmocore") osmo_ns_dummy_path = os.path.join(libosmocore_dir, "utils/osmo-ns-dummy") + clone_project("libosmocore") if not os.path.exists(osmo_ns_dummy_path): - clone_project("libosmocore") logging.info("Building osmo-ns-dummy") testenv.cmd.run(["autoreconf", "-fi"], cwd=libosmocore_dir) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40303?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2837a41c919a9f7ef8c315ce5aa48fb4fe3f9a85 Gerrit-Change-Number: 40303 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 month, 1 week

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: podman_install: tweak git commands

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40304?usp=email ) Change subject: testenv: podman_install: tweak git commands ...................................................................... testenv: podman_install: tweak git commands * Do not run them in podman: git is required to run testenv, by not running it through podman the command in the log is shorter. * Set advice.detachedHead=false for the git clone to avoid printing the "You are in 'detached HEAD' state. You can look around ..." text block that isn't useful in this context. Change-Id: I2ee26764d1471e54eff748e11ec2cce6fb662667 --- M _testenv/testenv/podman_install.py 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/_testenv/testenv/podman_install.py b/_testenv/testenv/podman_install.py index a8293ef..130085c 100644 --- a/_testenv/testenv/podman_install.py +++ b/_testenv/testenv/podman_install.py @@ -112,7 +112,7 @@ branch = "master" url = f"https://gerrit.osmocom.org/{project}" if testenv.args.binary_repo.endswith(":latest"): - ls_remote = testenv.cmd.run(["git", "ls-remote", "--tags", url], capture_output=True, text=True) + ls_remote = testenv.cmd.run(["git", "ls-remote", "--tags", url], capture_output=True, text=True, no_podman=True) tags = [] pattern = re.compile("^\d+\.\d+\.\d+$") for line in ls_remote.stdout.split("\n"): @@ -127,6 +127,8 @@ testenv.cmd.run( [ "git", + "-c", + "advice.detachedHead=false", "-C", git_dir, "clone", @@ -135,7 +137,8 @@ "--branch", branch, url, - ] + ], + no_podman=True, ) show_commit(project, git_dir_project) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40304?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2ee26764d1471e54eff748e11ec2cce6fb662667 Gerrit-Change-Number: 40304 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 month, 1 week

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: podman_install: tweak git commands

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40304?usp=email ) Change subject: testenv: podman_install: tweak git commands ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40304?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2ee26764d1471e54eff748e11ec2cce6fb662667 Gerrit-Change-Number: 40304 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 May 2025 08:50:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 1 week

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: podman_install: show checked out commits

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40303?usp=email ) Change subject: testenv: podman_install: show checked out commits ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40303?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2837a41c919a9f7ef8c315ce5aa48fb4fe3f9a85 Gerrit-Change-Number: 40303 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 May 2025 08:31:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 1 week

1
0
0 0

[XS] Change in libosmo-sigtran[master]: sccp_scoc.c: assert value of sua_addr_parse()

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40298?usp=email ) Change subject: sccp_scoc.c: assert value of sua_addr_parse() ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: also, we have 13 instances of invoking sua_addr_parse without checking the return value, by far the majority of the calls. The function itself logs any error code paths. from what I can tell, I'd rather have a wrongly-routed message and that error log than a process crashing. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40298?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I008ee6f9024247c14d986a2baba061cc12bf68ec Gerrit-Change-Number: 40298 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 May 2025 06:51:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 month, 1 week

1
0
0 0

[XS] Change in libosmo-sigtran[master]: sccp_scoc: Match local conn by src_ref, not dest_ref

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40302?usp=email ) Change subject: sccp_scoc: Match local conn by src_ref, not dest_ref ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40302?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I0090f4088de407b476cfb0a6d652b384af714306 Gerrit-Change-Number: 40302 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 May 2025 06:48:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 1 week

1
0
0 0

[XS] Change in libosmo-sigtran[master]: sccp_demo_use: Log rx N-PCSTATE.ind

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40301?usp=email ) Change subject: sccp_demo_use: Log rx N-PCSTATE.ind ...................................................................... Patch Set 1: (1 comment) File examples/sccp_test_server.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/40301/comment/bf33aecd_1844d… : PS1, Line 76: sp_status same here, use osmo_ss7_pointcode_print or friends -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40301?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I19ff96c5892af412333ae413d95416c592e87f5c Gerrit-Change-Number: 40301 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 May 2025 06:48:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 month, 1 week

1
0
0 0

[XS] Change in libosmo-sigtran[master]: sccp_scoc.c: Log SCRC Routing Failure return cause

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40300?usp=email ) Change subject: sccp_scoc.c: Log SCRC Routing Failure return cause ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40300?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I75ce13de26c443ca5b496a00618f44e82fcf1cfa Gerrit-Change-Number: 40300 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 May 2025 06:47:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 1 week

1
0
0 0

[XS] Change in libosmo-sigtran[master]: sccp: Log remote PC in LOGPSCC

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40299?usp=email ) Change subject: sccp: Log remote PC in LOGPSCC ...................................................................... Patch Set 1: (1 comment) File src/sccp_scoc.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/40299/comment/e438cf2f_16206… : PS1, Line 131: _LOGPSCU((scc)->user, subsys, level, "CONN(%d,rpc=%u) " fmt, (conn)->conn_id, (conn)->remote_pc, ## args) whenever we print point codes, we should use osmo_ss7_pointcode_print() or related. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40299?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ifa3670f3f0894c3334299c6c9826a17bd63dd9ae Gerrit-Change-Number: 40299 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 May 2025 06:47:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 month, 1 week

1
0
0 0

[XS] Change in libosmo-sigtran[master]: sccp_scoc.c: assert value of sua_addr_parse()

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40298?usp=email ) Change subject: sccp_scoc.c: assert value of sua_addr_parse() ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: should we assert if the SCCP user hands us incorrect data? I would hope we're not venturing into open5gs-assert-style here? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40298?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I008ee6f9024247c14d986a2baba061cc12bf68ec Gerrit-Change-Number: 40298 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 May 2025 06:46:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 month, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2025