Attention is currently required from: lynxis lazus, osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40305?usp=email )
Change subject: epdg: introduce testenv support
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> (open thread)
as mentioned in private, feel free to take over it.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40305?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5063e6ef55e8918653e9634237103790f47784a2
Gerrit-Change-Number: 40305
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Fri, 16 May 2025 11:14:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Attention is currently required from: laforge, osmith.
pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40307?usp=email )
Change subject: scripts/kernel/fragment: enable osmo-epdg options
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> with this I can get the tests we currently have in osmo-ttcn3-hacks to pass.
ttcn3-epdg-test doesn't test the strongswan part, TTCN3 emulates strongswan by sending GSUP to osmo-epdg, so we are only testing *after* the ipsec part.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40307?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ia60d5c1f5ade31e37293b40340e789f04ea86287
Gerrit-Change-Number: 40307
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 16 May 2025 11:13:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Attention is currently required from: laforge.
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40307?usp=email )
Change subject: scripts/kernel/fragment: enable osmo-epdg options
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> are you sure yet those are all that's required, like the ipsec + related support needed for strongsw […]
with this I can get the tests we currently have in osmo-ttcn3-hacks to pass.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40307?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ia60d5c1f5ade31e37293b40340e789f04ea86287
Gerrit-Change-Number: 40307
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 16 May 2025 09:41:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40306?usp=email )
Change subject: sccp: sccp_addr_to_str_buf(): Use osmo_ss7_pointcode_print_buf()
......................................................................
sccp: sccp_addr_to_str_buf(): Use osmo_ss7_pointcode_print_buf()
During logging, the logging macro may already be using the static buffer
API to log context about a related PC. Hence, calling it here may
overwrite it.
Instead, use osmo_ss7_pointcode_print_buf(). It specially makes sense in
this API which is already a _buf() API, where the user precisely expects
no use of static buffers.
Change-Id: Ib54984e755dca16d5be4d3d5dac82faa38e83c79
---
M src/sccp_helpers.c
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
osmith: Looks good to me, but someone else must approve
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/src/sccp_helpers.c b/src/sccp_helpers.c
index 6643e4e..39099fd 100644
--- a/src/sccp_helpers.c
+++ b/src/sccp_helpers.c
@@ -355,11 +355,12 @@
{
struct osmo_strbuf sb = { .buf = buf, .len = buf_len };
char ipbuf[INET6_ADDRSTRLEN];
+ char buf_pc[MAX_PC_STR_LEN];
OSMO_STRBUF_PRINTF(sb, "RI=%s", osmo_sccp_routing_ind_name(addr->ri));
if (addr->presence & OSMO_SCCP_ADDR_T_PC)
- OSMO_STRBUF_PRINTF(sb, "%cPC=%s", sep_char, osmo_ss7_pointcode_print(ss7, addr->pc));
+ OSMO_STRBUF_PRINTF(sb, "%cPC=%s", sep_char, osmo_ss7_pointcode_print_buf(buf_pc, sizeof(buf_pc), ss7, addr->pc));
if (addr->presence & OSMO_SCCP_ADDR_T_SSN)
OSMO_STRBUF_PRINTF(sb, "%cSSN=%s", sep_char, osmo_sccp_ssn_name(addr->ssn));
if (addr->presence & OSMO_SCCP_ADDR_T_IPv4)
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40306?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ib54984e755dca16d5be4d3d5dac82faa38e83c79
Gerrit-Change-Number: 40306
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40302?usp=email )
Change subject: sccp_scoc: Match local conn by src_ref, not dest_ref
......................................................................
sccp_scoc: Match local conn by src_ref, not dest_ref
SCRC Routing Failure is dispatched when a local SCCP Connection Oriented
message fails to be routed to a peer.
Hence, in order to figure out if the msg belons to a local conn, we need
to use the src_ref (the sender), not the dst_ref (the peer's id).
As a result, event SCOC_E_RCOC_ROUT_FAIL_IND was potentially being set
to the wrong connection FSM.
Change-Id: I0090f4088de407b476cfb0a6d652b384af714306
---
M src/sccp_scoc.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
osmith: Looks good to me, but someone else must approve
diff --git a/src/sccp_scoc.c b/src/sccp_scoc.c
index c977110..a725a02 100644
--- a/src/sccp_scoc.c
+++ b/src/sccp_scoc.c
@@ -1608,7 +1608,7 @@
xua_hdr_dump(xua, &xua_dialect_sua));
/* try to dispatch to connection FSM (if any) */
- conn_id = xua_msg_get_u32(xua, SUA_IEI_DEST_REF);
+ conn_id = xua_msg_get_u32(xua, SUA_IEI_SRC_REF);
conn = conn_find_by_id(inst, conn_id);
if (conn) {
osmo_fsm_inst_dispatch(conn->fi,
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40302?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I0090f4088de407b476cfb0a6d652b384af714306
Gerrit-Change-Number: 40302
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>