pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40189?usp=email )
Change subject: M3UA_Templates: Allow passing multiple Routing Context values
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
See "Routing Context" in rfc4666 for those messages.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40189?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I117c63786d71aea683b554cf294fee0ceed665e0
Gerrit-Change-Number: 40189
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Fri, 02 May 2025 13:29:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: jolly.
pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40188?usp=email )
Change subject: VTY: Initialize fields of struct cmd_element in order of declaration
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40188?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ifaa31980f149f9c1f1a9b28f318a4850f6855472
Gerrit-Change-Number: 40188
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Fri, 02 May 2025 11:16:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: jolly.
fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40188?usp=email )
Change subject: VTY: Initialize fields of struct cmd_element in order of declaration
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40188?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ifaa31980f149f9c1f1a9b28f318a4850f6855472
Gerrit-Change-Number: 40188
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Fri, 02 May 2025 08:55:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: laforge.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/40187?usp=email )
Change subject: vty: remove broken 'show startup-config' command
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/libosmocore/+/40187/comment/4bc1a658_0d812e58?… :
PS1, Line 9: Saving the current configuration by doing 'write file [FILE]' breaks
: the 'show startup-config' command. If write succeeds, this command
: will be showing contents of the new (potentially modified) file.
> e.g. https://blog.netwrix.com/copy-running-config-to-startup-config-cisco/ […]
Ok, then I misunderstood the purpose of this command. My [incorrect] understanding was that this command is supposed to show the initial configuration that was effective when the process started. This might be useful, for instance, to see difference from the current (running) configuration.
https://gerrit.osmocom.org/c/libosmocore/+/40187/comment/92a19250_c367c263?… :
PS1, Line 12: If
> Doesn't that mean that the write is then broken?
In the ticket I gave an example of writing the configuration to *another* file, which is not the same as the one that the current process loaded. The problem occurs when you do `write file some_file`: `show startup-config` will be showing contents of that new `some_file` even if it's not the one that was given to the process via `-c` (and thus will not be used if you restart the process).
Another problem occurs when you try writing to a location in which you don't have the write permissions: the `write file /forbidden/some_file` fails, but yet alters the VTY state, so `show startup-config` would be trying to `open()` that `/forbidden/some_file` and obviously would fail.
Maybe we should change the `write file [PATH]` command to not alter the state, i.e. remove invocation of `host_config_set()` in `config_write_file_cmd`. This would solve both problems I described above. What do you think?
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40187?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If0b4a79052c060cad963e6458b29000a979f95ba
Gerrit-Change-Number: 40187
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 02 May 2025 08:53:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Attention is currently required from: jolly.
laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40188?usp=email )
Change subject: VTY: Initialize fields of struct cmd_element in order of declaration
......................................................................
Patch Set 1: Code-Review+1 Verified+1
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40188?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ifaa31980f149f9c1f1a9b28f318a4850f6855472
Gerrit-Change-Number: 40188
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Fri, 02 May 2025 07:33:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria.
laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/40187?usp=email )
Change subject: vty: remove broken 'show startup-config' command
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/libosmocore/+/40187/comment/15abf817_13208d49?… :
PS1, Line 9: Saving the current configuration by doing 'write file [FILE]' breaks
: the 'show startup-config' command. If write succeeds, this command
: will be showing contents of the new (potentially modified) file.
e.g. https://blog.netwrix.com/copy-running-config-to-startup-config-cisco/
> show running-config — Displays the current active configuration of the device.
> show startup-config — Shows the configuration _that will be loaded the next time the device restarts_.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40187?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If0b4a79052c060cad963e6458b29000a979f95ba
Gerrit-Change-Number: 40187
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 02 May 2025 07:32:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Attention is currently required from: fixeria.
laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/40187?usp=email )
Change subject: vty: remove broken 'show startup-config' command
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/libosmocore/+/40187/comment/46cf8e4d_8390990f?… :
PS1, Line 9: Saving the current configuration by doing 'write file [FILE]' breaks
: the 'show startup-config' command. If write succeeds, this command
: will be showing contents of the new (potentially modified) file.
this is exactly how it would behave on a cisco device, isn't it? If you write to the file (basically `copy running-config startup-config`, then the [next] startup config is exactly the same as what you're running right now. I don't see a bug here.
https://gerrit.osmocom.org/c/libosmocore/+/40187/comment/81449ac8_285ba68d?… :
PS1, Line 12: If
Doesn't that mean that the write is then broken? The write should probably always write to a newly-created file, and only after that succeeds unlink the old file and rename the new file, to ensure we always have either the old (unsuccesful write) or the new (successful write) config. If there is a related bug, it should be fixed in the write, and not worked around here?
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40187?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If0b4a79052c060cad963e6458b29000a979f95ba
Gerrit-Change-Number: 40187
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 02 May 2025 07:29:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No