February 2025 - gerrit-log - lists.osmocom.org

[M] Change in osmo-hnbgw[master]: peek_l3_ul_nas: Split parsing logic based on PS/CS ctx

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/39479?usp=email ) Change subject: peek_l3_ul_nas: Split parsing logic based on PS/CS ctx ...................................................................... peek_l3_ul_nas: Split parsing logic based on PS/CS ctx It makes no sense to receive an MM message over PS context or a GMM message over a CS context, hence better clearly split the parsing code paths to avoid unintended logic execution. Related: OS#6717 Change-Id: I198f2fd14952362c4d189663d067c7f9dae2ed05 --- M src/osmo-hnbgw/hnbgw_l3.c 1 file changed, 52 insertions(+), 54 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/osmo-hnbgw/hnbgw_l3.c b/src/osmo-hnbgw/hnbgw_l3.c index 1fd3398..0ed628f 100644 --- a/src/osmo-hnbgw/hnbgw_l3.c +++ b/src/osmo-hnbgw/hnbgw_l3.c @@ -156,60 +156,34 @@ return 0; } -static int peek_l3_ul_nas(struct hnbgw_context_map *map, const uint8_t *nas_pdu, size_t len, - const struct osmo_plmn_id *local_plmn) +/* CS MM: Determine mobile identity, from_other_plmn, is_emerg. */ +static int peek_l3_ul_nas_cs(struct hnbgw_context_map *map, const uint8_t *nas_pdu, size_t len, + const struct osmo_plmn_id *local_plmn) { - const struct gsm48_hdr *gh; - int8_t pdisc; - uint8_t mtype; + const struct gsm48_hdr *gh = (const struct gsm48_hdr *)nas_pdu; + struct osmo_location_area_id old_lai; const struct gsm48_loc_upd_req *lu; struct gsm48_service_request *cm; - struct osmo_location_area_id old_lai; - struct osmo_routing_area_id old_ra = {}; - int nri = -1; - map->l3 = (struct hnbgw_l3_peek){ - .gmm_nri_container = -1, - }; + osmo_mobile_identity_decode_from_l3_buf(&map->l3.mi, nas_pdu, len, false); - /* Get the mobile identity from CS MM -- the PS GMM happens further down. - * This will return an error for GMM messages, ignore that. */ - if (!map->is_ps) - osmo_mobile_identity_decode_from_l3_buf(&map->l3.mi, nas_pdu, len, false); - - /* Get is_emerg and from_other_plmn */ - if (len < sizeof(*gh)) { - LOGP(DCN, LOGL_ERROR, "Layer 3 message too short for header\n"); - return -EINVAL; - } - - gh = (void *)nas_pdu; - pdisc = gsm48_hdr_pdisc(gh); - mtype = gsm48_hdr_msg_type(gh); - - map->l3.gsm48_pdisc = pdisc; - map->l3.gsm48_msg_type = mtype; - - /* Determine from_other_plmn and is_emerg */ - switch (pdisc) { + switch (map->l3.gsm48_pdisc) { case GSM48_PDISC_MM: - - switch (mtype) { + /* Get is_emerg and from_other_plmn */ + switch (map->l3.gsm48_msg_type) { case GSM48_MT_MM_LOC_UPD_REQUEST: if (len < sizeof(*gh) + sizeof(*lu)) { LOGP(DCN, LOGL_ERROR, "LU Req message too short\n"); break; } - lu = (struct gsm48_loc_upd_req *)gh->data; gsm48_decode_lai2(&lu->lai, &old_lai); - map->l3.from_other_plmn = (osmo_plmn_cmp(&old_lai.plmn, local_plmn) != 0); if (map->l3.from_other_plmn) LOGP(DRUA, LOGL_INFO, "LU from other PLMN: old LAI=%s my PLMN=%s\n", osmo_plmn_name_c(OTC_SELECT, &old_lai.plmn), osmo_plmn_name_c(OTC_SELECT, local_plmn)); - break; + return 0; case GSM48_MT_MM_CM_SERV_REQ: if (len < sizeof(*gh) + sizeof(*cm)) { @@ -219,64 +193,88 @@ cm = (struct gsm48_service_request *)&gh->data[0]; map->l3.is_emerg = (cm->cm_service_type == GSM48_CMSERV_EMERGENCY); LOGP(DRUA, LOGL_DEBUG, "CM Service is_emerg=%d\n", map->l3.is_emerg); - break; - - default: - break; + return 0; } break; + } + return 0; +} + +/* PS GMM: Determine mobile identity, gmm_nri_container, from_other_plmn and is_emerg */ +static int peek_l3_ul_nas_ps(struct hnbgw_context_map *map, const uint8_t *nas_pdu, size_t len, + const struct osmo_plmn_id *local_plmn) +{ + struct osmo_routing_area_id old_ra = {}; + int nri = -1; + + switch (map->l3.gsm48_pdisc) { case GSM48_PDISC_MM_GPRS: - switch (mtype) { + switch (map->l3.gsm48_msg_type) { case GSM48_MT_GMM_ATTACH_REQ: mobile_identity_decode_from_gmm_att_req(&map->l3.mi, &old_ra, &nri, nas_pdu, len, false); - LOGP(DRUA, LOGL_DEBUG, "GMM Attach Req mi=%s old_ra=%s nri:%d=0x%x\n", osmo_mobile_identity_to_str_c(OTC_SELECT, &map->l3.mi), osmo_rai_name2_c(OTC_SELECT, &old_ra), nri, nri); - if (old_ra.lac.plmn.mcc && osmo_plmn_cmp(&old_ra.lac.plmn, local_plmn)) { map->l3.from_other_plmn = true; LOGP(DRUA, LOGL_INFO, "GMM Attach Req from other PLMN: old RAI=%s my PLMN=%s\n", osmo_rai_name2_c(OTC_SELECT, &old_ra), osmo_plmn_name_c(OTC_SELECT, local_plmn)); } - if (nri >= 0) map->l3.gmm_nri_container = nri; - - break; + return 0; case GSM48_MT_GMM_RA_UPD_REQ: mobile_identity_decode_from_gmm_rau_req(&map->l3.mi, &old_ra, &nri, nas_pdu, len, false); - LOGP(DRUA, LOGL_DEBUG, "GMM Routing Area Upd Req mi=%s old_ra=%s nri:%d=0x%x\n", osmo_mobile_identity_to_str_c(OTC_SELECT, &map->l3.mi), osmo_rai_name2_c(OTC_SELECT, &old_ra), nri, nri); - if (old_ra.lac.plmn.mcc && osmo_plmn_cmp(&old_ra.lac.plmn, local_plmn)) { map->l3.from_other_plmn = true; LOGP(DRUA, LOGL_INFO, "GMM Routing Area Upd Req from other PLMN: old RAI=%s my PLMN=%s\n", osmo_rai_name2_c(OTC_SELECT, &old_ra), osmo_plmn_name_c(OTC_SELECT, local_plmn)); } - if (nri >= 0) map->l3.gmm_nri_container = nri; - - break; + return 0; } break; - - default: - break; } return 0; } +static int peek_l3_ul_nas(struct hnbgw_context_map *map, const uint8_t *nas_pdu, size_t len, + const struct osmo_plmn_id *local_plmn) +{ + const struct gsm48_hdr *gh = (const struct gsm48_hdr *)nas_pdu; + + map->l3 = (struct hnbgw_l3_peek){ + .gmm_nri_container = -1, + .mi = { + .type = GSM_MI_TYPE_NONE, + .tmsi = GSM_RESERVED_TMSI, + }, + }; + + if (len < sizeof(*gh)) { + LOGP(DCN, LOGL_ERROR, "Layer 3 message too short for header\n"); + return -EINVAL; + } + + map->l3.gsm48_pdisc = gsm48_hdr_pdisc(gh); + map->l3.gsm48_msg_type = gsm48_hdr_msg_type(gh); + + if (map->is_ps) + return peek_l3_ul_nas_ps(map, nas_pdu, len, local_plmn); + return peek_l3_ul_nas_cs(map, nas_pdu, len, local_plmn); +} + static int peek_l3_ul_initial_ue(struct hnbgw_context_map *map, const RANAP_InitialUE_MessageIEs_t *ies) { struct osmo_plmn_id local_plmn; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/39479?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I198f2fd14952362c4d189663d067c7f9dae2ed05 Gerrit-Change-Number: 39479 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[S] Change in osmo-hnbgw[master]: peek_l3_ul_nas: Improve GMM Attach Req parsing checks

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/39481?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: peek_l3_ul_nas: Improve GMM Attach Req parsing checks ...................................................................... peek_l3_ul_nas: Improve GMM Attach Req parsing checks Related: OS#6717 Change-Id: Ic9815215d40d7bb59709dcbffa0a4673f1e0e710 --- M src/osmo-hnbgw/hnbgw_l3.c 1 file changed, 13 insertions(+), 7 deletions(-) Approvals: lynxis lazus: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/osmo-hnbgw/hnbgw_l3.c b/src/osmo-hnbgw/hnbgw_l3.c index 363f1ce..5ff1602 100644 --- a/src/osmo-hnbgw/hnbgw_l3.c +++ b/src/osmo-hnbgw/hnbgw_l3.c @@ -68,6 +68,7 @@ } } +/* Parse 3GPP TS 24.008 § 9.4.1 Attach request */ static int mobile_identity_decode_from_gmm_att_req(struct osmo_mobile_identity *mi, struct osmo_routing_area_id *old_ra, int *nri, @@ -82,11 +83,16 @@ uint8_t ms_ra_acc_cap_len; int rc; + if (l3_len < 26) + return -ENOSPC; + /* MS network capability 10.5.5.12 */ msnc_len = *cur++; + if (l3_len < (msnc_len + (cur - l3_data))) + return -ENOSPC; cur += msnc_len; - /* aTTACH Type 10.5.5.2 */ + /* aTTACH Type 10.5.5.2 + Ciphering key sequence number 10.5.1.2 */ cur++; /* DRX parameter 10.5.5.6 */ @@ -95,10 +101,9 @@ /* Mobile Identity (P-TMSI or IMSI) 10.5.1.4 */ mi_len = *cur++; mi_data = cur; - cur += mi_len; - - if (cur >= end) + if (l3_len < (mi_len + (cur - l3_data))) return -ENOSPC; + cur += mi_len; rc = osmo_mobile_identity_decode(mi, mi_data, mi_len, allow_hex); if (rc) @@ -112,11 +117,12 @@ /* MS Radio Access Capability 10.5.5.12a */ ms_ra_acc_cap_len = *cur++; + if (l3_len < (ms_ra_acc_cap_len + (cur - l3_data))) + return -ENOSPC; cur += ms_ra_acc_cap_len; - if (cur > end) - return -ENOSPC; - + if (l3_len == (cur - l3_data)) + return 0; /* No Optional TLV section */ decode_gmm_tlv(mi, old_ra, nri, cur, end - cur, allow_hex); return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/39481?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ic9815215d40d7bb59709dcbffa0a4673f1e0e710 Gerrit-Change-Number: 39481 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[S] Change in osmo-hnbgw[master]: peek_l3_ul_nas: Parse PTMSI MI from GMM RAU req

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/39482?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: peek_l3_ul_nas: Parse PTMSI MI from GMM RAU req ...................................................................... peek_l3_ul_nas: Parse PTMSI MI from GMM RAU req old_ra param in decode_gmm_tlv() is dropped since it was not really used, and all callers already parse old_ra in the manual mandatory parsing step. Related: OS#6717 Change-Id: I570eb31dcee94a3ebef25e15ac7cd7199ec9a79e --- M src/osmo-hnbgw/hnbgw_l3.c 1 file changed, 11 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved lynxis lazus: Looks good to me, but someone else must approve diff --git a/src/osmo-hnbgw/hnbgw_l3.c b/src/osmo-hnbgw/hnbgw_l3.c index 5ff1602..a6c44f7 100644 --- a/src/osmo-hnbgw/hnbgw_l3.c +++ b/src/osmo-hnbgw/hnbgw_l3.c @@ -50,10 +50,8 @@ }, }; -static void decode_gmm_tlv(struct osmo_mobile_identity *mi, - struct osmo_routing_area_id *old_ra, - int *nri, - const uint8_t *tlv_data, size_t tlv_len, bool allow_hex) +static void decode_gmm_tlv(struct osmo_mobile_identity *mi, int *nri, + const uint8_t *tlv_data, size_t tlv_len, bool allow_hex) { struct tlv_parsed tp; struct tlv_p_entry *e; @@ -66,6 +64,11 @@ *nri <<= 2; *nri |= e->val[1] >> 6; } + + /* RAU Req: 9.4.14.5 P-TMSI (Iu mode only): "This IE shall be included by the MS." */ + e = TLVP_GET(&tp, GSM48_IE_GMM_ALLOC_PTMSI); + if (mi && e) + osmo_mobile_identity_decode(mi, e->val, e->len, allow_hex); } /* Parse 3GPP TS 24.008 § 9.4.1 Attach request */ @@ -123,7 +126,9 @@ if (l3_len == (cur - l3_data)) return 0; /* No Optional TLV section */ - decode_gmm_tlv(mi, old_ra, nri, cur, end - cur, allow_hex); + + /* Mobile identity = NULL: already obtained from Mandatory IE above.*/ + decode_gmm_tlv(NULL, nri, cur, end - cur, allow_hex); return 0; } @@ -163,7 +168,7 @@ if (l3_len == (cur - l3_data)) return 0; /* No Optional TLV section */ - decode_gmm_tlv(mi, old_ra, nri, cur, end - cur, allow_hex); + decode_gmm_tlv(mi, nri, cur, end - cur, allow_hex); return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/39482?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I570eb31dcee94a3ebef25e15ac7cd7199ec9a79e Gerrit-Change-Number: 39482 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[M] Change in osmo-hnbgw[master]: peek_l3_ul_nas: Split parsing logic based on PS/CS ctx

by pespin

Attention is currently required from: laforge, lynxis lazus, neels. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/39479?usp=email ) Change subject: peek_l3_ul_nas: Split parsing logic based on PS/CS ctx ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/39479?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I198f2fd14952362c4d189663d067c7f9dae2ed05 Gerrit-Change-Number: 39479 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 10 Feb 2025 13:09:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 3 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: SGSN: add TC_attach_gmm_attach_req_while_gmm_attach_retransmit

by lynxis lazus

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39255?usp=email ) Change subject: SGSN: add TC_attach_gmm_attach_req_while_gmm_attach_retransmit ...................................................................... Patch Set 4: Code-Review+2 (4 comments) Patchset: PS4: 1+1=2 Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39255/comment/535fbd15_6009… : PS3, Line 10: by "loosing" an ID Req message. > losing Done File sgsn/SGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39255/comment/0c588afa_0692… : PS3, Line 2125: /* send out a second GMM_Attach Request. > removed it. Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39255/comment/2168f4ca_3555… : PS3, Line 2125: /* send out a second GMM_Attach Request. > removed it. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39255?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8d208c0a98675238dba439ab3e75758293928588 Gerrit-Change-Number: 39255 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Feb 2025 11:27:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

4 months, 3 weeks

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: osmo_s1gw.app.src: set 'vsn' to 'semver'

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39490?usp=email ) Change subject: osmo_s1gw.app.src: set 'vsn' to 'semver' ...................................................................... osmo_s1gw.app.src: set 'vsn' to 'semver' This way the app version is automatically generated using git. Change-Id: I8a39e632556c75648cef0fb79f47e61043a4149a --- M src/osmo_s1gw.app.src 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo_s1gw.app.src b/src/osmo_s1gw.app.src index 363d6d6..743a5d5 100644 --- a/src/osmo_s1gw.app.src +++ b/src/osmo_s1gw.app.src @@ -2,7 +2,7 @@ {application, osmo_s1gw, [ {description, "Osmocom S1AP Gateway"}, - {vsn, "1"}, + {vsn, semver}, {registered, []}, {applications, [ kernel, -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39490?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I8a39e632556c75648cef0fb79f47e61043a4149a Gerrit-Change-Number: 39490 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: rebar.config: cosmetic: use spaces, not tabs

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39491?usp=email ) Change subject: rebar.config: cosmetic: use spaces, not tabs ...................................................................... rebar.config: cosmetic: use spaces, not tabs Change-Id: Ia6a026b51a0219353b1e898d9fc643381e985dc7 --- M rebar.config 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/rebar.config b/rebar.config index e124ac4..0a62c76 100644 --- a/rebar.config +++ b/rebar.config @@ -41,9 +41,9 @@ {escript_name, "osmo-s1gw"}. {relx, [{release, {"osmo-s1gw", "0.2.0"}, [osmo_s1gw]}, - {sys_config, "./config/sys.config"}, - {dev_mode, true}, - {include_erts, false}, - {extended_start_script, true}]}. + {sys_config, "./config/sys.config"}, + {dev_mode, true}, + {include_erts, false}, + {extended_start_script, true}]}. %% vim:set ts=4 sw=4 et: -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39491?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ia6a026b51a0219353b1e898d9fc643381e985dc7 Gerrit-Change-Number: 39491 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: rebar.config: relx: generate the version automatically

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39493?usp=email ) Change subject: rebar.config: relx: generate the version automatically ...................................................................... rebar.config: relx: generate the version automatically Change-Id: I7a4ed74416d4eef3c3befc0605d1857e147324e7 --- M rebar.config 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: osmith: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/rebar.config b/rebar.config index b4fd1fd..0100f17 100644 --- a/rebar.config +++ b/rebar.config @@ -40,7 +40,7 @@ {escript_main_app, osmo_s1gw}. {escript_name, "osmo-s1gw"}. -{relx, [{release, {'osmo-s1gw', "0.2.0"}, [osmo_s1gw]}, +{relx, [{release, {'osmo-s1gw', semver}, [osmo_s1gw]}, {sys_config, "./config/sys.config"}, {dev_mode, true}, {include_erts, false}, -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39493?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I7a4ed74416d4eef3c3befc0605d1857e147324e7 Gerrit-Change-Number: 39493 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: rebar.config: relx: fix release name (must be an atom)

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39492?usp=email ) Change subject: rebar.config: relx: fix release name (must be an atom) ...................................................................... rebar.config: relx: fix release name (must be an atom) https://rebar3.org/docs/deployment/releases/ states it must be an atom. Change-Id: Ic788ebb1c78c890939bd8dfd9bc34b06fe5c26fd --- M rebar.config 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/rebar.config b/rebar.config index 0a62c76..b4fd1fd 100644 --- a/rebar.config +++ b/rebar.config @@ -40,7 +40,7 @@ {escript_main_app, osmo_s1gw}. {escript_name, "osmo-s1gw"}. -{relx, [{release, {"osmo-s1gw", "0.2.0"}, [osmo_s1gw]}, +{relx, [{release, {'osmo-s1gw', "0.2.0"}, [osmo_s1gw]}, {sys_config, "./config/sys.config"}, {dev_mode, true}, {include_erts, false}, -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39492?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ic788ebb1c78c890939bd8dfd9bc34b06fe5c26fd Gerrit-Change-Number: 39492 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Submit proper L3 PDUs during CR

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39489?usp=email ) Change subject: hnbgw: Submit proper L3 PDUs during CR ...................................................................... hnbgw: Submit proper L3 PDUs during CR Generating random PDU values makes hnbgw act on it, since it looks up higher layers to figure out NRI steering. Change-Id: I725c35a3584b7d2d162c24ab2b662cfb80e539d7 Related: OS#6717 --- M hnbgw/ConnHdlr.ttcn 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/hnbgw/ConnHdlr.ttcn b/hnbgw/ConnHdlr.ttcn index 47c25a7..efba060 100644 --- a/hnbgw/ConnHdlr.ttcn +++ b/hnbgw/ConnHdlr.ttcn @@ -493,7 +493,17 @@ var octetstring nas; if (pars.tx_sccp_cr_data_len == 0) { - nas := f_rnd_octstring(10); + var octetstring tmsi := f_gen_tmsi(suffix := 0); + var MobileIdentityLV mi_lv := valueof(ts_MI_IMSI_LV(pars.imsi)); + if (pars.ps_domain) { + var PDU_L3_MS_SGSN l3_pdu; + l3_pdu := valueof(ts_GMM_ATTACH_REQ(mi_lv, f_RAI('001'H, '01'H, '2a2a'O, '17'O))); + nas := enc_PDU_L3_MS_SGSN(l3_pdu); + } else { + var PDU_ML3_MS_NW l3_pdu; + l3_pdu := valueof(ts_LU_REQ(LU_Type_IMSI_Attach, mi_lv, '00F110'O)); + nas := enc_PDU_ML3_MS_NW(l3_pdu); + } } else { /* The test asks for an exact number of Optional Data bytes. */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39489?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I725c35a3584b7d2d162c24ab2b662cfb80e539d7 Gerrit-Change-Number: 39489 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2025