February 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-sgsn[pespin/base]: jenkins.sh: No need to build libosmo-sigtran with doxygen

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39546?usp=email ) Change subject: jenkins.sh: No need to build libosmo-sigtran with doxygen ...................................................................... jenkins.sh: No need to build libosmo-sigtran with doxygen Change-Id: Iab3d1b2e1591e66702a01def6c322f4a11970ead (cherry picked from commit df44350b4b6fbc3922308fae18501ff11d546d9a) --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/46/39546/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index ced8367..d3c7616 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -38,7 +38,7 @@ osmo-build-dep.sh osmo-hlr if [ "x$IU" = "x--enable-iu" ]; then - osmo-build-dep.sh libosmo-sigtran + osmo-build-dep.sh libosmo-sigtran "" --disable-doxygen osmo-build-dep.sh libasn1c #osmo-build-dep.sh asn1c aper-prefix # only needed for make regen in osmo-iuh osmo-build-dep.sh osmo-iuh -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39546?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sgsn Gerrit-Branch: pespin/base Gerrit-Change-Id: Iab3d1b2e1591e66702a01def6c322f4a11970ead Gerrit-Change-Number: 39546 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[M] Change in osmo-sgsn[pespin/base]: GMM: rework PDP context status

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39547?usp=email ) Change subject: GMM: rework PDP context status ...................................................................... GMM: rework PDP context status Use an uint16 instead of an pointer with an unknown length. Also encode the current active PDP context (e.g. on 2G/4G mobilty this could change). It resynchronizes the UE with the SGSN state. Change-Id: I12d3110c9365132f96ef7ff8a1be22a431682c81 (cherry picked from commit 0e8f05563112eadc0ed50dc273cf9a723e8f99ac) --- M src/sgsn/gprs_gmm.c M tests/sgsn/sgsn_test.c 2 files changed, 77 insertions(+), 55 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/47/39547/1 diff --git a/src/sgsn/gprs_gmm.c b/src/sgsn/gprs_gmm.c index 7f70260..9aae62b 100644 --- a/src/sgsn/gprs_gmm.c +++ b/src/sgsn/gprs_gmm.c @@ -214,6 +214,61 @@ sgsn_mm_ctx_cleanup_free(ctx); } + +/* 3GPP TS 24.008 § 10.5.7.1 Process PDP context status value, bit 0 corresponds to nsapi 0 */ +static void process_ms_ctx_status(struct sgsn_mm_ctx *mmctx, + uint16_t pdp_status) +{ + struct sgsn_pdp_ctx *pdp, *pdp2; + /* 24.008 4.7.5.1.3: If the PDP context status information element is + * included in ROUTING AREA UPDATE REQUEST message, then the network + * shall deactivate all those PDP contexts locally (without peer to + * peer signalling between the MS and the network), which are not in SM + * state PDP-INACTIVE on network side but are indicated by the MS as + * being in state PDP-INACTIVE. */ + + /* NSAPI 0 - 4 are spare, ignore these */ + pdp_status &= 0xffe0; + + llist_for_each_entry_safe(pdp, pdp2, &mmctx->pdp_list, list) { + bool active = (pdp_status & (1 << pdp->nsapi)); + if (active) + continue; + + LOGMMCTXP(LOGL_NOTICE, mmctx, "Dropping PDP context for NSAPI=%u " + "due to PDP CTX STATUS IE=0x%02x\n", + pdp->nsapi, pdp_status); + pdp->ue_pdp_active = false; + if (pdp->ggsn) + sgsn_delete_pdp_ctx(pdp); + else /* GTP side already detached, freeing */ + sgsn_pdp_ctx_free(pdp); + } +} + +/* 3GPP TS 24.008 § 10.5.7.1 Encode PDP context status value, bit 0 correspond to nsapi 0 */ +uint16_t encode_ms_ctx_status(struct sgsn_mm_ctx *mmctx) +{ + struct sgsn_pdp_ctx *pdp; + + uint16_t pdp_status = 0; + + llist_for_each_entry(pdp, &mmctx->pdp_list, list) { + if (pdp->ue_pdp_active) + pdp_status |= (1 << pdp->nsapi); + } + + return pdp_status; +} + +/* 3GPP TS 24.008 § 4.7.13.4/10.5.7.1 Service request procedure not accepted by the + * network. Returns true if MS has active PDP contexts in pdp_status */ +bool pdp_status_has_active_nsapis(uint16_t pdp_status) +{ + /* NSAPI 0 - 4 are spare and should be ignored 0 */ + return (pdp_status >> 5) != 0; +} + /* Chapter 9.4.18 */ static int _tx_status(struct msgb *msg, uint8_t cause, struct sgsn_mm_ctx *mmctx) @@ -1512,6 +1567,8 @@ rua = (struct gsm48_ra_upd_ack *) msgb_put(msg, sizeof(*rua)); rua->force_stby = 0; /* not indicated */ rua->upd_result = 0; /* RA updated */ + + /* Periodic RA update timer */ t = osmo_tdef_get(sgsn->cfg.T_defs, 3312, OSMO_TDEF_S, -1); rua->ra_upd_timer = gprs_secs_to_tmr_floor(t); @@ -1540,12 +1597,19 @@ } *l = rc; #endif + /* MS identity */ + /* List of Received N-PDU */ /* Optional: Negotiated READY timer value */ t = osmo_tdef_get(sgsn->cfg.T_defs, 3314, OSMO_TDEF_S, -1); msgb_tv_put(msg, GSM48_IE_GMM_TIMER_READY, gprs_secs_to_tmr_floor(t)); - /* Option: MS ID, ... */ + /* GMM cause */ + /* PDP Context Status */ + uint16_t pdp_ctx_status = encode_ms_ctx_status(mm); + msgb_tlv_put(msg, GSM48_IE_GMM_PDP_CTX_STATUS, 2, (uint8_t *) &pdp_ctx_status); + + /* MS ID, ... */ return gsm48_gmm_sendmsg(msg, 0, mm, true); } @@ -1570,48 +1634,6 @@ return gsm48_gmm_sendmsg(msg, 0, NULL, false); } -static void process_ms_ctx_status(struct sgsn_mm_ctx *mmctx, - const uint8_t *pdp_status) -{ - struct sgsn_pdp_ctx *pdp, *pdp2; - /* 24.008 4.7.5.1.3: If the PDP context status information element is - * included in ROUTING AREA UPDATE REQUEST message, then the network - * shall deactivate all those PDP contexts locally (without peer to - * peer signalling between the MS and the network), which are not in SM - * state PDP-INACTIVE on network side but are indicated by the MS as - * being in state PDP-INACTIVE. */ - - llist_for_each_entry_safe(pdp, pdp2, &mmctx->pdp_list, list) { - bool inactive = (pdp->nsapi < 8) ? - !(pdp_status[0] & (1 << pdp->nsapi)) : - !(pdp_status[1] & (1 << (pdp->nsapi - 8))); - if (!inactive) - continue; - - LOGMMCTXP(LOGL_NOTICE, mmctx, "Dropping PDP context for NSAPI=%u " - "due to PDP CTX STATUS IE=0x%02x%02x\n", - pdp->nsapi, pdp_status[1], pdp_status[0]); - pdp->ue_pdp_active = false; - if (pdp->ggsn) - sgsn_delete_pdp_ctx(pdp); - else /* GTP side already detached, freeing */ - sgsn_pdp_ctx_free(pdp); - } -} - -/* 3GPP TS 24.008 § 4.7.13.4 Service request procedure not accepted by the - * network. Returns true if MS has active PDP contexts in pdp_status */ -bool pdp_status_has_active_nsapis(const uint8_t *pdp_status, const size_t pdp_status_len) -{ - size_t i; - - for (i = 0; i < pdp_status_len; i++) - if (pdp_status[i] != 0) - return true; - - return false; -} - /* Chapter 9.4.14: Routing area update request */ static int gsm48_rx_gmm_ra_upd_req(struct sgsn_mm_ctx *mmctx, struct msgb *msg, struct gprs_llc_llme *llme) @@ -1824,7 +1846,7 @@ /* Look at PDP Context Status IE and see if MS's view of * activated/deactivated NSAPIs agrees with our view */ if (TLVP_PRESENT(&tp, GSM48_IE_GMM_PDP_CTX_STATUS)) { - const uint8_t *pdp_status = TLVP_VAL(&tp, GSM48_IE_GMM_PDP_CTX_STATUS); + uint16_t pdp_status = osmo_load16le(TLVP_VAL(&tp, GSM48_IE_GMM_PDP_CTX_STATUS)); process_ms_ctx_status(mmctx, pdp_status); } @@ -1983,8 +2005,7 @@ /* Look at PDP Context Status IE and see if MS's view of * activated/deactivated NSAPIs agrees with our view */ if (TLVP_PRESENT(&tp, GSM48_IE_GMM_PDP_CTX_STATUS)) { - const uint8_t *pdp_status = TLVP_VAL(&tp, GSM48_IE_GMM_PDP_CTX_STATUS); - const size_t pdp_status_len = TLVP_LEN(&tp, GSM48_IE_GMM_PDP_CTX_STATUS); + uint16_t pdp_status = tlvp_val16be(&tp, GSM48_IE_GMM_PDP_CTX_STATUS); process_ms_ctx_status(ctx, pdp_status); @@ -1993,7 +2014,7 @@ * Active state in pdp_status but there is no PDP contexts on * SGSN side then Reject with the cause will force the mobile to * reset PDP contexts */ - if (llist_empty(&ctx->pdp_list) && pdp_status_has_active_nsapis(pdp_status, pdp_status_len)) { + if (llist_empty(&ctx->pdp_list) && pdp_status_has_active_nsapis(pdp_status)) { reject_cause = GMM_CAUSE_NO_PDP_ACTIVATED; goto rejected; } diff --git a/tests/sgsn/sgsn_test.c b/tests/sgsn/sgsn_test.c index 29dad74..6dcda84 100644 --- a/tests/sgsn/sgsn_test.c +++ b/tests/sgsn/sgsn_test.c @@ -1582,20 +1582,21 @@ cleanup_test(); } -bool pdp_status_has_active_nsapis(const uint8_t *pdp_status, const size_t pdp_status_len); +bool pdp_status_has_active_nsapis(uint16_t pdp_status); static void test_pdp_status_has_active_nsapis(void) { - const size_t pdp_status_len = 2; - const uint8_t pdp_status1[] = { 0b00100000, 0b00000000 }; /* PDP NSAPI 5 active */ - const uint8_t pdp_status2[] = { 0b00000000, 0b00000000 }; /* no active PDP NSAPI */ - const uint8_t pdp_status3[] = { 0b00000000, 0b00000001 }; /* PDP NSAPI 8 active */ + uint16_t pdp_status1 = 0b0000000000100000; /* PDP NSAPI 5 active */ + uint16_t pdp_status2 = 0b0000000000000000; /* no active PDP NSAPI */ + uint16_t pdp_status3 = 0b0000000100000000; /* PDP NSAPI 8 active */ + uint16_t pdp_status4 = 0b0000000000000001; /* reserved NSAPI 0 active -> no active */ printf("Testing pdp_status_has_active_nsapis\n"); - OSMO_ASSERT(pdp_status_has_active_nsapis(pdp_status1, pdp_status_len)); - OSMO_ASSERT(!pdp_status_has_active_nsapis(pdp_status2, pdp_status_len)); - OSMO_ASSERT(pdp_status_has_active_nsapis(pdp_status3, pdp_status_len)); + OSMO_ASSERT(pdp_status_has_active_nsapis(pdp_status1)); + OSMO_ASSERT(!pdp_status_has_active_nsapis(pdp_status2)); + OSMO_ASSERT(pdp_status_has_active_nsapis(pdp_status3)); + OSMO_ASSERT(!pdp_status_has_active_nsapis(pdp_status4)); } static struct log_info_cat gprs_categories[] = { -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39547?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sgsn Gerrit-Branch: pespin/base Gerrit-Change-Id: I12d3110c9365132f96ef7ff8a1be22a431682c81 Gerrit-Change-Number: 39547 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[XS] Change in osmo-sgsn[pespin/base]: sgsn_vty: Drop unneeded use of abis/ipa.h header

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39545?usp=email ) Change subject: sgsn_vty: Drop unneeded use of abis/ipa.h header ...................................................................... sgsn_vty: Drop unneeded use of abis/ipa.h header The header is not needed and will eventually be deprecated. Change-Id: I48a513b8ea63dadbc6d6d571380980f55ff04a06 (cherry picked from commit 7a45b5748582594d8113c24d7de03dd4740ccb4e) --- M src/sgsn/sgsn_vty.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/45/39545/1 diff --git a/src/sgsn/sgsn_vty.c b/src/sgsn/sgsn_vty.c index 113fdd1..2d41009 100644 --- a/src/sgsn/sgsn_vty.c +++ b/src/sgsn/sgsn_vty.c @@ -53,7 +53,6 @@ #include <osmocom/vty/misc.h> #include <osmocom/crypt/gprs_cipher.h> #include <osmocom/crypt/utran_cipher.h> -#include <osmocom/abis/ipa.h> #include <osmocom/gprs/gprs_bssgp.h> -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39545?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sgsn Gerrit-Branch: pespin/base Gerrit-Change-Id: I48a513b8ea63dadbc6d6d571380980f55ff04a06 Gerrit-Change-Number: 39545 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[XS] Change in osmo-sgsn[pespin/base]: gprs_ms_net_cap_gea_mask(): protect against empty MS Network Capabili...

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39548?usp=email ) Change subject: gprs_ms_net_cap_gea_mask(): protect against empty MS Network Capabilities ...................................................................... gprs_ms_net_cap_gea_mask(): protect against empty MS Network Capabilities When the MS Network Capability is empty, expect to support at least unencrypted communications. This shouldn't be empty at all, as the minimum length of it is 2 when the MS/UE is doing an Attach Request. But when receiving a MS/UE SGSN Context via Gn, the field is optional. The MS/UE shall include it into the Routing Area Request, but not must. Change-Id: Ieef2e3eeaaadc90c35fff6f20d47bd36aaa4b9e6 (cherry picked from commit d3b037ccfae542807b7602c2163f11fa0eb3b885) --- M src/sgsn/gprs_gmm.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/48/39548/1 diff --git a/src/sgsn/gprs_gmm.c b/src/sgsn/gprs_gmm.c index 9aae62b..7a4ea20 100644 --- a/src/sgsn/gprs_gmm.c +++ b/src/sgsn/gprs_gmm.c @@ -1229,6 +1229,10 @@ static uint8_t gprs_ms_net_cap_gea_mask(const uint8_t *ms_net_cap, uint8_t cap_len) { uint8_t mask = (1 << GPRS_ALGO_GEA0); + + if (cap_len == 0) + return mask; + mask |= (0x80 & ms_net_cap[0]) ? (1 << GPRS_ALGO_GEA1) : 0; if (cap_len < 2) -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39548?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sgsn Gerrit-Branch: pespin/base Gerrit-Change-Id: Ieef2e3eeaaadc90c35fff6f20d47bd36aaa4b9e6 Gerrit-Change-Number: 39548 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[M] Change in osmo-sgsn[pespin/base]: Bump version: 1.12.0.23-dc62-dirty → 1.13.0

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39549?usp=email ) Change subject: Bump version: 1.12.0.23-dc62-dirty → 1.13.0 ...................................................................... Bump version: 1.12.0.23-dc62-dirty → 1.13.0 This release was made on top of commit 6213201b ("ranap: Reject ActivatePDPCtx from UE if RABAssResp parsing fails") instead of master as master is currently too much in WIP state for making a release, as discussed with Alexander and Pau. The release also has several fixes from master backported. Change-Id: I9b37f6354d3f6343ac5befbd6944c1a5786d2b48 --- M TODO-RELEASE M configure.ac M debian/changelog M debian/control 4 files changed, 51 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/49/39549/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index 02149e5..0ed7189 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,6 +7,3 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line -libgtp >1.12.0 new field dir_tun_flags in struct pdp_t -libgtp >1.12.0 gtp_set_cb_update_context_ind(), gtp_update_context_resp() -libosmo-gsup-client >1.8.0 osmo_gsup_client_is_connected(), osmo_gsup_client_get_rem_addr(), osmo_gsup_client_get_rem_port() diff --git a/configure.ac b/configure.ac index 5286d2e..f9f6220 100644 --- a/configure.ac +++ b/configure.ac @@ -38,22 +38,22 @@ CFLAGS="$CFLAGS -std=gnu11" dnl checks for libraries -PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.10.0) -PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.10.0) -PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.10.0) -PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.10.0) -PKG_CHECK_MODULES(LIBOSMOGB, libosmogb >= 1.10.0) -PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 1.6.0) -PKG_CHECK_MODULES(LIBOSMOGSUPCLIENT, libosmo-gsup-client >= 1.8.0) -PKG_CHECK_MODULES(LIBGTP, libgtp >= 1.12.0) +PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.11.0) +PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.11.0) +PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.11.0) +PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.11.0) +PKG_CHECK_MODULES(LIBOSMOGB, libosmogb >= 1.11.0) +PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 2.0.0) +PKG_CHECK_MODULES(LIBOSMOGSUPCLIENT, libosmo-gsup-client >= 1.9.0) +PKG_CHECK_MODULES(LIBGTP, libgtp >= 1.13.0) # Enable/disable 3G aka IuPS + IuCS support? AC_ARG_ENABLE([iu], [AS_HELP_STRING([--enable-iu], [Build 3G support, aka IuPS and IuCS interfaces])], [osmo_ac_iu="$enableval"],[osmo_ac_iu="no"]) if test "x$osmo_ac_iu" = "xyes" ; then - PKG_CHECK_MODULES(LIBOSMOSIGTRAN, libosmo-sigtran >= 1.9.0) + PKG_CHECK_MODULES(LIBOSMOSIGTRAN, libosmo-sigtran >= 2.1.0) PKG_CHECK_MODULES(LIBASN1C, libasn1c >= 0.9.30) - PKG_CHECK_MODULES(LIBOSMORANAP, libosmo-ranap >= 1.6.0) + PKG_CHECK_MODULES(LIBOSMORANAP, libosmo-ranap >= 1.7.0) AC_DEFINE(BUILD_IU, 1, [Define if we want to build IuPS and IuCS interfaces support]) fi AM_CONDITIONAL(BUILD_IU, test "x$osmo_ac_iu" = "xyes") diff --git a/debian/changelog b/debian/changelog index a1f0216..7bc1351 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,38 @@ +osmo-sgsn (1.13.0) unstable; urgency=medium + + [ Pau Espin Pedrol ] + * Fix DeactPDPCtxAcc when UE goes PMM ENABLED but lost its PDP context + * gtp: Set Direct Tunnel Flags DTI during UpdatePDPCtx + * Announce SGSN own TEID during UpdatePDPCtxReq after UE goes PMM-IDLE + * Handle rx UpdatePDPCtxReq with Tunnel Direct Flags EI=1 + * Fix double free during RAU with unexpected Old RAI + * llc: Mark old/current tlli as all 1's when unassigning LLME + * ranap: Fix decoding of padded ITU X.213 IPv4 TLA in Rab Ass Resp + * ranap: Reject ActivatePDPCtx from UE if RABAssResp parsing fails + * jenkins.sh: libosmo-netif no longer depends on libosmo-abis + * vty: Avoid accessing gsupclient object fields directly + * sgsn_vty: Drop unneeded use of abis/ipa.h header + * jenkins.sh: No need to build libosmo-sigtran with doxygen + + [ Alexander Couzens ] + * includes: sgsn.h: use full path include for gtp.h + * includes: add forward declartion of external types + * Replace gprs_ra_id with modern osmo_routing_area_id + * GTP: CreatePDPContext: only use IMEISV IE when IMEISV is known + * GMM: rework PDP context status + * gprs_ms_net_cap_gea_mask(): protect against empty MS Network Capabilities + + [ Vadim Yanitskiy ] + * build: remove indirect libosmo-netif dependency + * build: do not link against libosmo-abis + * sm: pdpctx_timer_stop(): warn about timer not running + + [ Oliver Smith ] + * debian/control: remove build-dep: libosmo-sccp-dev + * contrib/jenkins: libosmo-sccp -> libosmo-sigtran + + -- Oliver Smith <osmith(a)sysmocom.de> Thu, 13 Feb 2025 15:10:23 +0100 + osmo-sgsn (1.12.0) unstable; urgency=medium [ Andreas Eversberg ] diff --git a/debian/control b/debian/control index 2a3d427..acb4230 100644 --- a/debian/control +++ b/debian/control @@ -11,13 +11,13 @@ pkg-config, libtalloc-dev, libc-ares-dev, - libgtp-dev (>= 1.12.0), - libosmocore-dev (>= 1.10.0), - libosmo-abis-dev (>= 1.6.0), - libosmo-gsup-client-dev (>= 1.8.0), + libgtp-dev (>= 1.13.0), + libosmocore-dev (>= 1.11.0), + libosmo-abis-dev (>= 2.0.0), + libosmo-gsup-client-dev (>= 1.9.0), libasn1c-dev (>= 0.9.30), - libosmo-ranap-dev (>= 1.6.0), - libosmo-sigtran-dev (>= 1.9.0), + libosmo-ranap-dev (>= 1.7.0), + libosmo-sigtran-dev (>= 2.1.0), osmo-gsm-manuals-dev (>= 1.6.0) Standards-Version: 3.9.8 Vcs-Git: https://gitea.osmocom.org/cellular-infrastructure/osmo-sgsn -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39549?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sgsn Gerrit-Branch: pespin/base Gerrit-Change-Id: I9b37f6354d3f6343ac5befbd6944c1a5786d2b48 Gerrit-Change-Number: 39549 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[XS] Change in libosmocore[master]: gsmtap: fix outdated header version in comment

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/39540?usp=email ) Change subject: gsmtap: fix outdated header version in comment ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39540?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iee4cbd5f8699ed7da28a0f9ac5856b435e76b86a Gerrit-Change-Number: 39540 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Feb 2025 14:09:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 3 weeks

1
0
0 0

[M] Change in meta-telephony[201705]: Update Osmocom recipes to latest tags (release 202502)

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/meta-telephony/+/39541?usp=email ) Change subject: Update Osmocom recipes to latest tags (release 202502) ...................................................................... Update Osmocom recipes to latest tags (release 202502) Related: SYS#7299 Change-Id: I33a8a5e787716e3a9366d6f0539d65e238427339 --- M recipes-osmocom/libosmo-abis/libosmo-abis.inc M recipes-osmocom/libosmo-abis/libosmo-abis_git.bb M recipes-osmocom/libosmo-netif/libosmo-netif.inc M recipes-osmocom/libosmo-netif/libosmo-netif_git.bb M recipes-osmocom/libosmo-sigtran/libosmo-sigtran_git.bb M recipes-osmocom/libosmocore/libosmocore_git.bb M recipes-osmocom/osmo-bsc/osmo-bsc_git.bb M recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb M recipes-osmocom/osmo-hlr/osmo-hlr_git.bb M recipes-osmocom/osmo-hnbgw/osmo-hnbgw_git.bb M recipes-osmocom/osmo-iuh/osmo-iuh_git.bb M recipes-osmocom/osmo-mgw/osmo-mgw.inc M recipes-osmocom/osmo-mgw/osmo-mgw_git.bb M recipes-osmocom/osmo-msc/osmo-msc_git.bb M recipes-osmocom/osmo-pcap/osmo-pcap.inc M recipes-osmocom/osmo-pcap/osmo-pcap_git.bb M recipes-osmocom/osmo-sip-connector/osmo-sip-connector_git.bb 17 files changed, 30 insertions(+), 30 deletions(-) git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/41/39541/1 diff --git a/recipes-osmocom/libosmo-abis/libosmo-abis.inc b/recipes-osmocom/libosmo-abis/libosmo-abis.inc index 955ebe3..7ddd30e 100644 --- a/recipes-osmocom/libosmo-abis/libosmo-abis.inc +++ b/recipes-osmocom/libosmo-abis/libosmo-abis.inc @@ -4,7 +4,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=73f1eb20517c55bf9493b7dd6e480788" INC_PR="r1.${META_TELEPHONY_OSMO_INC}" -DEPENDS = "libosmocore ortp libtalloc" +DEPENDS = "libosmocore libosmo-netif ortp libtalloc" inherit autotools pkgconfig diff --git a/recipes-osmocom/libosmo-abis/libosmo-abis_git.bb b/recipes-osmocom/libosmo-abis/libosmo-abis_git.bb index b6a1aa2..5a4b8d0 100644 --- a/recipes-osmocom/libosmo-abis/libosmo-abis_git.bb +++ b/recipes-osmocom/libosmo-abis/libosmo-abis_git.bb @@ -1,7 +1,7 @@ require ${PN}.inc S = "${WORKDIR}/git" -SRCREV = "1.6.0" +SRCREV = "2.0.0" SRC_URI = "git://gerrit.osmocom.org/libosmo-abis.git;protocol=https;tag=${SRCREV};nobr…" -PV = "1.6.0+gitr${SRCPV}" +PV = "${SRCREV}+gitr${SRCPV}" PR = "${INC_PR}.0" diff --git a/recipes-osmocom/libosmo-netif/libosmo-netif.inc b/recipes-osmocom/libosmo-netif/libosmo-netif.inc index 3b5ef19..875118b 100644 --- a/recipes-osmocom/libosmo-netif/libosmo-netif.inc +++ b/recipes-osmocom/libosmo-netif/libosmo-netif.inc @@ -5,7 +5,7 @@ INC_PR="r1.${META_TELEPHONY_OSMO_INC}" -DEPENDS = "libosmo-abis libtalloc" +DEPENDS = "libosmocore libtalloc" PACKAGECONFIG ??= "\ libsctp \ diff --git a/recipes-osmocom/libosmo-netif/libosmo-netif_git.bb b/recipes-osmocom/libosmo-netif/libosmo-netif_git.bb index 036745f..83e4fa8 100644 --- a/recipes-osmocom/libosmo-netif/libosmo-netif_git.bb +++ b/recipes-osmocom/libosmo-netif/libosmo-netif_git.bb @@ -1,7 +1,7 @@ require ${PN}.inc S = "${WORKDIR}/git" -SRCREV = "1.5.1" +SRCREV = "1.6.0" SRC_URI = "git://gerrit.osmocom.org/libosmo-netif.git;protocol=https;tag=${SRCREV};nob…" -PV = "1.5.1+gitr${SRCPV}" +PV = "${SRCREV}+gitr${SRCPV}" PR = "${INC_PR}.0" diff --git a/recipes-osmocom/libosmo-sigtran/libosmo-sigtran_git.bb b/recipes-osmocom/libosmo-sigtran/libosmo-sigtran_git.bb index bd5ef0f..002aa66 100644 --- a/recipes-osmocom/libosmo-sigtran/libosmo-sigtran_git.bb +++ b/recipes-osmocom/libosmo-sigtran/libosmo-sigtran_git.bb @@ -1,7 +1,7 @@ require ${PN}.inc S = "${WORKDIR}/git" -SRCREV = "2.0.0" +SRCREV = "2.1.0" SRC_URI = "git://gerrit.osmocom.org/libosmo-sigtran.git;protocol=https;tag=${SRCREV};n…" -PV = "2.0.0+gitr${SRCPV}" +PV = "${SRCREV}+gitr${SRCPV}" PR = "${INC_PR}.0" diff --git a/recipes-osmocom/libosmocore/libosmocore_git.bb b/recipes-osmocom/libosmocore/libosmocore_git.bb index 0d66c74..276f528 100644 --- a/recipes-osmocom/libosmocore/libosmocore_git.bb +++ b/recipes-osmocom/libosmocore/libosmocore_git.bb @@ -1,9 +1,9 @@ require ${PN}.inc S = "${WORKDIR}/git" -SRCREV = "1.10.0" +SRCREV = "1.11.0" SRC_URI = "git://gerrit.osmocom.org/libosmocore.git;protocol=https;tag=${SRCREV};nobra…" -PV = "1.10.0+gitr${SRCPV}" +PV = "${SRCREV}+gitr${SRCPV}" PR = "${INC_PR}.0" PACKAGES =+ "libosmoctrl libosmocodec libosmogb libosmogsm libosmovty osmo-arfcn osmo-auc-gen osmo-config-merge" diff --git a/recipes-osmocom/osmo-bsc/osmo-bsc_git.bb b/recipes-osmocom/osmo-bsc/osmo-bsc_git.bb index 83904f7..c083a62 100644 --- a/recipes-osmocom/osmo-bsc/osmo-bsc_git.bb +++ b/recipes-osmocom/osmo-bsc/osmo-bsc_git.bb @@ -1,7 +1,7 @@ require ${PN}.inc S = "${WORKDIR}/git" -SRCREV = "1.12.2" +SRCREV = "1.13.0" SRC_URI = "git://gerrit.osmocom.org/osmo-bsc.git;protocol=https;tag=${SRCREV};nobranch…" -PV = "1.12.2+gitr${SRCPV}" +PV = "${SRCREV}+gitr${SRCPV}" PR = "${INC_PR}.0" diff --git a/recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb b/recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb index 49d3e53..9fe3780 100644 --- a/recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb +++ b/recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb @@ -1,9 +1,9 @@ require ${PN}.inc S = "${WORKDIR}/git" -SRCREV = "1.12.0" +SRCREV = "1.13.0" SRC_URI = "git://gerrit.osmocom.org/osmo-ggsn;protocol=https;tag=${SRCREV};nobranch=1 \ file://0001-libgtp-set-PDP_MAX-to-128.patch \ " -PV = "1.12.0+gitr${SRCPV}" +PV = "${SRCREV}+gitr${SRCPV}" PR = "${INC_PR}.0" diff --git a/recipes-osmocom/osmo-hlr/osmo-hlr_git.bb b/recipes-osmocom/osmo-hlr/osmo-hlr_git.bb index cd5d6dd..23dbd93 100644 --- a/recipes-osmocom/osmo-hlr/osmo-hlr_git.bb +++ b/recipes-osmocom/osmo-hlr/osmo-hlr_git.bb @@ -1,7 +1,7 @@ require ${PN}.inc S = "${WORKDIR}/git" -SRCREV = "1.8.0" +SRCREV = "1.9.0" SRC_URI = "git://gerrit.osmocom.org/osmo-hlr.git;protocol=https;tag=${SRCREV};nobranch…" -PV = "1.8.0+gitr${SRCPV}" +PV = "${SRCREV}+gitr${SRCPV}" PR = "${INC_PR}.0" diff --git a/recipes-osmocom/osmo-hnbgw/osmo-hnbgw_git.bb b/recipes-osmocom/osmo-hnbgw/osmo-hnbgw_git.bb index b44d5a7..2b5aa02 100644 --- a/recipes-osmocom/osmo-hnbgw/osmo-hnbgw_git.bb +++ b/recipes-osmocom/osmo-hnbgw/osmo-hnbgw_git.bb @@ -1,7 +1,7 @@ require ${PN}.inc S = "${WORKDIR}/git" -SRCREV = "1.6.2" +SRCREV = "1.7.0" SRC_URI = "git://gerrit.osmocom.org/osmo-hnbgw.git;protocol=https;tag=${SRCREV};nobran…" -PV = "1.6.2+gitr${SRCPV}" +PV = "${SRCREV}+gitr${SRCPV}" PR = "${INC_PR}.0" diff --git a/recipes-osmocom/osmo-iuh/osmo-iuh_git.bb b/recipes-osmocom/osmo-iuh/osmo-iuh_git.bb index f289654..fff88d5 100644 --- a/recipes-osmocom/osmo-iuh/osmo-iuh_git.bb +++ b/recipes-osmocom/osmo-iuh/osmo-iuh_git.bb @@ -1,7 +1,7 @@ require ${PN}.inc S = "${WORKDIR}/git" -SRCREV = "1.6.0" +SRCREV = "1.7.0" SRC_URI = "git://gerrit.osmocom.org/osmo-iuh.git;protocol=https;tag=${SRCREV};nobranch…" -PV = "1.6.0+gitr${SRCPV}" +PV = "${SRCREV}+gitr${SRCPV}" PR = "${INC_PR}.0" diff --git a/recipes-osmocom/osmo-mgw/osmo-mgw.inc b/recipes-osmocom/osmo-mgw/osmo-mgw.inc index 5e740db..863d13a 100644 --- a/recipes-osmocom/osmo-mgw/osmo-mgw.inc +++ b/recipes-osmocom/osmo-mgw/osmo-mgw.inc @@ -3,7 +3,7 @@ LICENSE = "AGPLv3" LIC_FILES_CHKSUM = "file://COPYING;md5=73f1eb20517c55bf9493b7dd6e480788" -DEPENDS = "libosmocore libosmo-netif" +DEPENDS = "libosmocore libosmo-netif libosmo-abis" INC_PR="r4.${META_TELEPHONY_OSMO_INC}" diff --git a/recipes-osmocom/osmo-mgw/osmo-mgw_git.bb b/recipes-osmocom/osmo-mgw/osmo-mgw_git.bb index cca5ee4..e7ffd06 100644 --- a/recipes-osmocom/osmo-mgw/osmo-mgw_git.bb +++ b/recipes-osmocom/osmo-mgw/osmo-mgw_git.bb @@ -1,7 +1,7 @@ require ${PN}.inc S = "${WORKDIR}/git" -SRCREV = "1.13.1" +SRCREV = "1.14.0" SRC_URI = "git://gerrit.osmocom.org/osmo-mgw.git;protocol=https;tag=${SRCREV};nobranch…" -PV = "1.13.1+gitr${SRCPV}" +PV = "${SRCREV}+gitr${SRCPV}" PR = "${INC_PR}.0" diff --git a/recipes-osmocom/osmo-msc/osmo-msc_git.bb b/recipes-osmocom/osmo-msc/osmo-msc_git.bb index 89327d4..bbe85e9 100644 --- a/recipes-osmocom/osmo-msc/osmo-msc_git.bb +++ b/recipes-osmocom/osmo-msc/osmo-msc_git.bb @@ -1,7 +1,7 @@ require ${PN}.inc S = "${WORKDIR}/git" -SRCREV = "1.12.2" +SRCREV = "1.13.0" SRC_URI = "git://gerrit.osmocom.org/osmo-msc.git;protocol=https;tag=${SRCREV};nobranch…" -PV = "1.12.2+gitr${SRCPV}" +PV = "${SRCREV}+gitr${SRCPV}" PR = "${INC_PR}.0" diff --git a/recipes-osmocom/osmo-pcap/osmo-pcap.inc b/recipes-osmocom/osmo-pcap/osmo-pcap.inc index e64ca88..bef1101 100644 --- a/recipes-osmocom/osmo-pcap/osmo-pcap.inc +++ b/recipes-osmocom/osmo-pcap/osmo-pcap.inc @@ -3,7 +3,7 @@ LICENSE = "AGPLv3+" LIC_FILES_CHKSUM = "file://COPYING;md5=73f1eb20517c55bf9493b7dd6e480788" -DEPENDS = "libosmocore zeromq libpcap gnutls" +DEPENDS = "libosmocore zeromq libpcap gnutls libosmo-netif" INC_PR="r2.${META_TELEPHONY_OSMO_INC}" diff --git a/recipes-osmocom/osmo-pcap/osmo-pcap_git.bb b/recipes-osmocom/osmo-pcap/osmo-pcap_git.bb index d674f6f..8b75a47 100644 --- a/recipes-osmocom/osmo-pcap/osmo-pcap_git.bb +++ b/recipes-osmocom/osmo-pcap/osmo-pcap_git.bb @@ -1,7 +1,7 @@ require ${PN}.inc S = "${WORKDIR}/git" -SRCREV = "0.5.0" +SRCREV = "0.6.0" SRC_URI = "git://gerrit.osmocom.org/osmo-pcap.git;protocol=https;tag=${SRCREV};nobranc…" -PV = "0.5.0+gitr${SRCPV}" +PV = "${SRCREV}+gitr${SRCPV}" PR = "${INC_PR}.0" diff --git a/recipes-osmocom/osmo-sip-connector/osmo-sip-connector_git.bb b/recipes-osmocom/osmo-sip-connector/osmo-sip-connector_git.bb index 70bb346..09e8324 100644 --- a/recipes-osmocom/osmo-sip-connector/osmo-sip-connector_git.bb +++ b/recipes-osmocom/osmo-sip-connector/osmo-sip-connector_git.bb @@ -1,7 +1,7 @@ require ${PN}.inc S = "${WORKDIR}/git" -SRCREV = "1.7.0" +SRCREV = "1.7.1" SRC_URI = "git://gerrit.osmocom.org/osmo-sip-connector.git;protocol=https;tag=${SRCREV…" -PV = "1.7.0+gitr${SRCPV}" +PV = "${SRCREV}+gitr${SRCPV}" PR = "${INC_PR}.0" -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/39541?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: I33a8a5e787716e3a9366d6f0539d65e238427339 Gerrit-Change-Number: 39541 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: s1gw: f_ConnHdlr_session_delete(): invalidate peer's SEID

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39538?usp=email ) Change subject: s1gw: f_ConnHdlr_session_delete(): invalidate peer's SEID ...................................................................... s1gw: f_ConnHdlr_session_delete(): invalidate peer's SEID Change-Id: If8027e2bdb5822eb7555cd02a72be900a1f18880 --- M s1gw/S1GW_ConnHdlr.ttcn 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/s1gw/S1GW_ConnHdlr.ttcn b/s1gw/S1GW_ConnHdlr.ttcn index e84c3ab..be9f9d7 100644 --- a/s1gw/S1GW_ConnHdlr.ttcn +++ b/s1gw/S1GW_ConnHdlr.ttcn @@ -745,7 +745,7 @@ } } -function f_ConnHdlr_session_delete(in ERabList erabs) +function f_ConnHdlr_session_delete(inout ERabList erabs) runs on ConnHdlr { for (var integer i := 0; i < lengthof(erabs); i := i + 1) { log("UPF <- S1GW: PFCP Session Deletion Request for E-RAB ID ", erabs[i].erab_id); @@ -754,6 +754,8 @@ f_ConnHdlr_tx_session_delete_resp(erabs[i], pdu); /* ask PFCPEM to *not* route PDUs with this SEID to us */ f_PFCPEM_unsubscribe_seid(erabs[i].pfcp_loc_seid); + /* peer's SEID is no longer valid, invalidate it */ + erabs[i].pfcp_rem_seid := omit; } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39538?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If8027e2bdb5822eb7555cd02a72be900a1f18880 Gerrit-Change-Number: 39538 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: s1gw: f_ConnHdlr_session_delete(): respect any order

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39539?usp=email ) Change subject: s1gw: f_ConnHdlr_session_delete(): respect any order ...................................................................... s1gw: f_ConnHdlr_session_delete(): respect any order It's not guranteed (nor required) that PFCP Session Deletion Request PDUs are sent in the same order as their respective ERab records are organized in the given ERabList. They can be emitted in any order. Make f_ConnHdlr_session_delete() more flexible: * Expect to receive N PFCP Session Deletion Request PDUs; * For each received PFCP PDU, find the matching E-RAB; * Make sure that an E-RAB is never released twice; * Send PFCP Session Deletion Response. This patch fixes the following TCs: * TC_ue_ctx_release_req3 * TC_ue_ctx_release_cmd_compl3 Change-Id: I93d3d38829b1f425d18d59464894da239e3511eb Related: 75cb01b7 ("s1gw: add TCs for UE CONTEXT RELEASE procedures") Related: SYS#7310 --- M s1gw/S1GW_ConnHdlr.ttcn 1 file changed, 34 insertions(+), 8 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve diff --git a/s1gw/S1GW_ConnHdlr.ttcn b/s1gw/S1GW_ConnHdlr.ttcn index be9f9d7..3f79e47 100644 --- a/s1gw/S1GW_ConnHdlr.ttcn +++ b/s1gw/S1GW_ConnHdlr.ttcn @@ -302,6 +302,20 @@ private const LIN4_BO_LAST c_PFCP_FAR_ID_C2A := 1; /* Core -> Access */ private const LIN4_BO_LAST c_PFCP_FAR_ID_A2C := 2; /* Access -> Core */ +/* look-up an E-RAB in the given list by SEID of the received PFCP PDU */ +private function f_ERabList_find_by_pdu(in ERabList erabs, in PDU_PFCP rsp) +return integer { + for (var integer i := 0; i < lengthof(erabs); i := i + 1) { + if (erabs[i].pfcp_loc_seid == rsp.seid) { + return i; + } + } + + setverdict(fail, __SCOPE__, "(): no matching E-RAB found"); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); + return -1; /* make compiler happy */ +} + function f_ConnHdlr_tx_erab_setup_req(in ERabList erabs) runs on ConnHdlr { var template (value) E_RABToBeSetupListBearerSUReq items; @@ -747,15 +761,27 @@ function f_ConnHdlr_session_delete(inout ERabList erabs) runs on ConnHdlr { - for (var integer i := 0; i < lengthof(erabs); i := i + 1) { - log("UPF <- S1GW: PFCP Session Deletion Request for E-RAB ID ", erabs[i].erab_id); - var PDU_PFCP pdu := f_ConnHdlr_rx_session_delete_req(erabs[i]); - log("UPF -> S1GW: PFCP Session Deletion Response for E-RAB ID ", erabs[i].erab_id); - f_ConnHdlr_tx_session_delete_resp(erabs[i], pdu); - /* ask PFCPEM to *not* route PDUs with this SEID to us */ - f_PFCPEM_unsubscribe_seid(erabs[i].pfcp_loc_seid); + var integer pending_erabs := lengthof(erabs); + + while (pending_erabs > 0) { + var PDU_PFCP pdu := f_ConnHdlr_pfcp_expect(tr_PFCP_Session_Del_Req); + var integer idx := f_ERabList_find_by_pdu(erabs, pdu); + + log("UPF <- S1GW: PFCP Session Deletion Request for E-RAB ID ", erabs[idx].erab_id); + /* make sure that an E-RAB is never released twice */ + if (not ispresent(erabs[idx].pfcp_rem_seid)) { + setverdict(fail, __SCOPE__, "(): PFCP Session Deletion Request ", + "was not expected for E-RAB ID ", erabs[idx].erab_id); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); + } + log("UPF -> S1GW: PFCP Session Deletion Response for E-RAB ID ", erabs[idx].erab_id); + f_ConnHdlr_tx_session_delete_resp(erabs[idx], pdu); + /* ask PFCPEM to *not* route PDUs with the local SEID to us */ + f_PFCPEM_unsubscribe_seid(erabs[idx].pfcp_loc_seid); /* peer's SEID is no longer valid, invalidate it */ - erabs[i].pfcp_rem_seid := omit; + erabs[idx].pfcp_rem_seid := omit; + + pending_erabs := pending_erabs - 1; } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39539?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I93d3d38829b1f425d18d59464894da239e3511eb Gerrit-Change-Number: 39539 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: s1gw: f_ConnHdlr_session_delete(): respect any order

by fixeria

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39539?usp=email ) Change subject: s1gw: f_ConnHdlr_session_delete(): respect any order ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39539?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I93d3d38829b1f425d18d59464894da239e3511eb Gerrit-Change-Number: 39539 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Feb 2025 11:03:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2025