February 2025 - gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: euicc: Add euicc_memory_reset shell command

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/39409?usp=email ) Change subject: euicc: Add euicc_memory_reset shell command ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39409?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib462f5b7de3e500e51c0f3d6e2b9b0c2d3ba7e20 Gerrit-Change-Number: 39409 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Feb 2025 11:49:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 3 weeks

1
0
0 0

[M] Change in ...osmo-s1gw[master]: erab_fsm: implement E-RAB MODIFY Ind/Cnf procedure

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39147?usp=email ) Change subject: erab_fsm: implement E-RAB MODIFY Ind/Cnf procedure ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39147?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I750ada0a5a21edc8bc06d567c8000b6304966474 Gerrit-Change-Number: 39147 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Feb 2025 11:15:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 3 weeks

1
0
0 0

[M] Change in ...osmo-s1gw[master]: erab_fsm: implement E-RAB MODIFY Req/Rsp procedure

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39116?usp=email ) Change subject: erab_fsm: implement E-RAB MODIFY Req/Rsp procedure ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39116?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I24d57ea390d71b640cb42046a8658e9d30670682 Gerrit-Change-Number: 39116 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Feb 2025 11:11:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 3 weeks

1
0
0 0

[S] Change in ...osmo-s1gw[master]: erab_fsm: handle RELEASE.{cmd,ind} in state erab_wait_setup_rsp

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39524?usp=email ) Change subject: erab_fsm: handle RELEASE.{cmd,ind} in state erab_wait_setup_rsp ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39524?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I91a010f304456c1593ef257051a912f0fe8ae2a1 Gerrit-Change-Number: 39524 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Feb 2025 11:06:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 3 weeks

1
0
0 0

[M] Change in osmocom-bb[master]: trx_toolkit/*: Try to avoid copying burst data where possible

by kirr

Attention is currently required from: pespin. kirr has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39537?usp=email ) Change subject: trx_toolkit/*: Try to avoid copying burst data where possible ...................................................................... Patch Set 2: (1 comment) File src/target/trx_toolkit/data_msg.py: https://gerrit.osmocom.org/c/osmocom-bb/+/39537/comment/7ef9a2d0_e46bcac8?u… : PS2, Line 336: burst = memoryview(burst)[:EDGE_BURST_LEN] > I never used memoryview nor read about the details, but in line "burst = memoryview(burst)[:EDGE_BUR […] ah, now I see. So memoryview(burst) creates only a view of original burst object data. This is basically a small object that points to another base object to know where to get the data without copying them. Then slice operation of memoryview returns another memoryview without copying the data - that adjusted memoryview refers to base object, but knows to view not the whole data of it, but only some range. It is still a small object that does not copy base's data. ``` In [7]: burst = bytearray(range(10)) In [8]: burst Out[8]: bytearray(b'\x00\x01\x02\x03\x04\x05\x06\x07\x08\t') In [9]: burst *= 100 In [10]: burst Out[10]: bytearray(b'\x00\x01\x02\x03\x04\x05\x06\x07\x08\t...\x00\x01\x02\x03\x04\x05\x06\x07\x08\t') In [11]: len(burst) Out[11]: 1000 In [12]: sys.getsizeof(burst) Out[12]: 1057 In [13]: m = memoryview(burst) In [14]: len(m) Out[14]: 1000 In [15]: sys.getsizeof(m) Out[15]: 184 In [16]: m[0] Out[16]: 0 In [17]: burst[0] Out[17]: 0 In [18]: burst[1] Out[18]: 1 In [19]: m[1] Out[19]: 1 In [20]: m[2] Out[20]: 2 In [21]: burst[2] Out[21]: 2 In [22]: mm = m[2:] In [23]: len(mm) Out[23]: 998 In [24]: sys.getsizeof(mm) Out[24]: 184 In [25]: mm[0] Out[25]: 2 In [26]: m[2] Out[26]: 2 In [27]: mm[1] Out[27]: 3 In [28]: m[3] Out[28]: 3 In [29]: burst[3] Out[29]: 3 ``` Please see https://docs.python.org/3/library/stdtypes.html#memoryview for details. P.S. Unfortunately constant-size of memoryview structure turned out to be not so small, so it still contributes to overhead for not so small bursts. https://github.com/python/cpython/blob/v3.11.9-9-g1b0e63c81b5/Include/memor… -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/39537?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I147da2f110dedc863361059c931f609c28a69e9c Gerrit-Change-Number: 39537 Gerrit-PatchSet: 2 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Feb 2025 20:22:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: kirr <kirr(a)nexedi.com> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[M] Change in osmocom-bb[master]: trx_toolkit/*: Try to avoid copying burst data where possible

by pespin

Attention is currently required from: kirr. pespin has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39537?usp=email ) Change subject: trx_toolkit/*: Try to avoid copying burst data where possible ...................................................................... Patch Set 2: (1 comment) File src/target/trx_toolkit/data_msg.py: https://gerrit.osmocom.org/c/osmocom-bb/+/39537/comment/c9b0f578_e15f2838?u… : PS2, Line 336: burst = memoryview(burst)[:EDGE_BURST_LEN] > Could you please clarify? Do you mean here that we create a copy via `self. […] I never used memoryview nor read about the details, but in line "burst = memoryview(burst)[:EDGE_BURST_LEN]" I'd expect 2 steps: 1- "memoryview(burst)" Generate a memory view of burst 2- "[:EDGE_BURST_LEN]" Generate a slice (potentialy a copy?) of the burst memory view you just created So as mentioned, I have no real knowledge, just mentioning in case "memoryview(memoryview(burst)[:EDGE_BURST_LEN])" makes sense. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/39537?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I147da2f110dedc863361059c931f609c28a69e9c Gerrit-Change-Number: 39537 Gerrit-PatchSet: 2 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: kirr <kirr(a)nexedi.com> Gerrit-Comment-Date: Thu, 13 Feb 2025 19:50:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: kirr <kirr(a)nexedi.com> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[M] Change in osmocom-bb[master]: trx_toolkit/*: Try to avoid copying burst data where possible

by kirr

Attention is currently required from: pespin. kirr has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39537?usp=email ) Change subject: trx_toolkit/*: Try to avoid copying burst data where possible ...................................................................... Patch Set 2: (1 comment) File src/target/trx_toolkit/data_msg.py: https://gerrit.osmocom.org/c/osmocom-bb/+/39537/comment/729d63f9_41a26f6c?u… : PS2, Line 336: burst = memoryview(burst)[:EDGE_BURST_LEN] > Just speculating here, but with the new version you posted you are still potentially creating a copy […] Could you please clarify? Do you mean here that we create a copy via `self.burst = bytearray(burst)` later? Or do you mean that we create a copy somewhere else? The copy in `self.burst = bytearray(burst)` is necessarry in current data model where we want .burst to be a bytearray or bytes. In theory we could keep it as memoryview as well, but memoryview does not have .translate method and so then conversion from unpacked bits to soft bits will become much slower again. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/39537?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I147da2f110dedc863361059c931f609c28a69e9c Gerrit-Change-Number: 39537 Gerrit-PatchSet: 2 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Feb 2025 19:11:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: sgsn: remove osmo-sgsn <= 1.12.0 code path

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39551?usp=email ) Change subject: sgsn: remove osmo-sgsn <= 1.12.0 code path ...................................................................... sgsn: remove osmo-sgsn <= 1.12.0 code path Now that 1.13.0 has been released, we can run this test in latest too. Change-Id: I4ead7b05d7d956303584ccbfe1e13692f54341af --- M sgsn/SGSN_Tests.ttcn 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn index 62856ff..b2d9731 100644 --- a/sgsn/SGSN_Tests.ttcn +++ b/sgsn/SGSN_Tests.ttcn @@ -3232,10 +3232,7 @@ execute( TC_attach_rau() ); execute( TC_attach_rau_a_a() ); execute( TC_attach_rau_a_b() ); - if (Misc_Helpers.f_osmo_repo_is("nightly")) { - /* Will double-free and crash osmo-sgsn <= 1.12.0 */ - execute( TC_attach_rau_a_b_wrong_old_ra() ); - } + execute( TC_attach_rau_a_b_wrong_old_ra() ); execute( TC_attach_usim_resync() ); execute( TC_attach_usim_a54_a54() ); execute( TC_attach_usim_a54_a53() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39551?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4ead7b05d7d956303584ccbfe1e13692f54341af Gerrit-Change-Number: 39551 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: remove osmo-hnbgw <= 1.6.0 code path

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39550?usp=email ) Change subject: hnbgw: remove osmo-hnbgw <= 1.6.0 code path ...................................................................... hnbgw: remove osmo-hnbgw <= 1.6.0 code path osmo-hnbgw 1.7.0 has been released, so we can remove this code path. Change-Id: Ie55b752c19aa597afdc47b6e57e8ff0b42313e00 --- M hnbgw/HNBGW_Tests.ttcn 1 file changed, 2 insertions(+), 11 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 589c699..33800f3 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -381,19 +381,10 @@ /* Temporarily access Statsd during test startup: */ connect(self:STATSD_PROC, vc_STATSD:STATSD_PROC); - /* osmo-hnbgw <= 1.6.0 doesn't support the stats "pfcp_associated". - * Assume we have to wait for IUT to send PFCP Assoc Setup Req, - * but avoid failing if we don't receive any. */ - var boolean validate_pfcp_assoc := Misc_Helpers.f_osmo_repo_is("nightly"); - var boolean pfcp_associated := false; - if (validate_pfcp_assoc) { - pfcp_associated := f_statsd_pfcp_associated(); - } - - if (not pfcp_associated) { + if (not f_statsd_pfcp_associated()) { connect(self:PFCP, vc_PFCP:CLIENT); connect(self:PFCP_PROC, vc_PFCP:CLIENT_PROC); - f_pfcp_wait_assoc_setup_req(fail_timeout := validate_pfcp_assoc); + f_pfcp_wait_assoc_setup_req(fail_timeout := true); disconnect(self:PFCP, vc_PFCP:CLIENT); disconnect(self:PFCP_PROC, vc_PFCP:CLIENT_PROC); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39550?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie55b752c19aa597afdc47b6e57e8ff0b42313e00 Gerrit-Change-Number: 39550 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: remove osmo-hnbgw <= 1.6.0 code path

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39550?usp=email ) Change subject: hnbgw: remove osmo-hnbgw <= 1.6.0 code path ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39550?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie55b752c19aa597afdc47b6e57e8ff0b42313e00 Gerrit-Change-Number: 39550 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Feb 2025 18:13:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2025