February 2025 - gerrit-log - lists.osmocom.org

[XL] Change in osmo-ggsn[master]: gtp: add support for SGSN Context Req/Resp/Ack

by Jenkins Builder

Attention is currently required from: lynxis lazus. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38938?usp=email ) Change subject: gtp: add support for SGSN Context Req/Resp/Ack ...................................................................... Patch Set 10: (6 comments) File include/osmocom/gtp/gsn.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21539): https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/7daac752_274d7768?us… : PS10, Line 116: int (*cb_sgsn_context_request_ind) (struct gsn_t *gsn, struct sockaddr_in *peer, uint32_t local_ref, union gtpie_member **ie, unsigned int ie_size); Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21539): https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/a6be551b_9cb9e501?us… : PS10, Line 117: int (*cb_sgsn_context_response_ind) (struct gsn_t *gsn, struct sockaddr_in *peer, uint32_t local_ref, union gtpie_member **ie, unsigned int ie_size); Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21539): https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/192557dd_bc77ad4d?us… : PS10, Line 118: int (*cb_sgsn_context_ack_ind) (struct gsn_t *gsn, struct sockaddr_in *peer, uint32_t local_ref, union gtpie_member **ie, unsigned int ie_size); Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21539): https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/34c8f2a6_94d154a6?us… : PS10, Line 169: int (*cb) (struct gsn_t *gsn, struct sockaddr_in *peer, uint32_t local_ref, union gtpie_member **ie, unsigned int ie_size)); Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21539): https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/e7f4b916_f5367c8b?us… : PS10, Line 172: int (*cb) (struct gsn_t *gsn, struct sockaddr_in *peer, uint32_t local_ref, union gtpie_member **ie, unsigned int ie_size)); Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21539): https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/8a301fad_16e28766?us… : PS10, Line 175: int (*cb) (struct gsn_t *gsn, struct sockaddr_in *peer, uint32_t local_ref, union gtpie_member **ie, unsigned int ie_size)); Unnecessary space before function pointer arguments -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38938?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Idb8ed0bb87200a68bb8caedd734fc070df9179c0 Gerrit-Change-Number: 38938 Gerrit-PatchSet: 10 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 16 Feb 2025 18:38:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 months, 2 weeks

1
0
0 0

[XL] Change in osmo-ggsn[master]: gtp: add support for SGSN Context Req/Resp/Ack

by lynxis lazus

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38938?usp=email to look at the new patch set (#10). Change subject: gtp: add support for SGSN Context Req/Resp/Ack ...................................................................... gtp: add support for SGSN Context Req/Resp/Ack To handle both incoming and outgoing SGSN Context via GTPv1. Introduce a FSM which handles the state of SGSN Context to simplify the API for the SGSN which uses libgtp as well as the external SGSN which communicates via GTP. Change-Id: Idb8ed0bb87200a68bb8caedd734fc070df9179c0 --- M TODO-RELEASE M configure.ac M gtp/Makefile.am M gtp/gsn.c M gtp/gtp.c A gtp/gtp_sgsn_ctx.c A gtp/gtp_sgsn_ctx.h M include/osmocom/gtp/gsn.h M include/osmocom/gtp/gtp.h 9 files changed, 1,317 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/38/38938/10 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38938?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Idb8ed0bb87200a68bb8caedd734fc070df9179c0 Gerrit-Change-Number: 38938 Gerrit-PatchSet: 10 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

4 months, 2 weeks

1
0
0 0

[S] Change in osmo-msc[master]: vlr: extend the subscriber invalidate callback with reasons

by lynxis lazus

Attention is currently required from: lynxis lazus, neels, pespin. Hello Jenkins Builder, neels, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/38488?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: vlr: extend the subscriber invalidate callback with reasons ...................................................................... vlr: extend the subscriber invalidate callback with reasons The VLR must be allowed to notify the MSC if a subscriber becomes invalid. There are multiple cases when this happens: a) if the subscriber didn't do a Location Update Procedure within the given periodic timer. b) if the HLR does a Cancel Location Procedure with reason withdraw c) if the HLR does a Cancel Location Procedure with reason update location. d) duplicate entries (unsure if this is valid, but keeping the code as is) Change-Id: Ie5b687318b106a230fcee52deba86649641004b3 --- M include/osmocom/vlr/vlr.h M src/libmsc/gsm_04_08.c M src/libvlr/vlr.c 3 files changed, 12 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/88/38488/8 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38488?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie5b687318b106a230fcee52deba86649641004b3 Gerrit-Change-Number: 38488 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

4 months, 2 weeks

1
0
0 0

[M] Change in libosmo-abis[master]: tests: add unit test for HRv1 TRAU->RTP

by falconia

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39559?usp=email ) Change subject: tests: add unit test for HRv1 TRAU->RTP ...................................................................... tests: add unit test for HRv1 TRAU->RTP Unit tests for TRAU->RTP conversion for FRv1 and EFR codecs were implemented earlier, but not for HRv1. Fill this gap in unit test coverage. The library code path exercised here is osmo_trau_frame_decode_8k() followed by osmo_trau2rtp(). Both plain (RFC 5993) and extended (TW-TS-002) RTP output formats are tested. Change-Id: Id2703d313f52fa54465a13f3370ebb6d7d976bbd --- M tests/Makefile.am M tests/testsuite.at A tests/trau_conv/trau2rtp_hr.in A tests/trau_conv/trau2rtp_hr_std.ok A tests/trau_conv/trau2rtp_hr_twts002.ok 5 files changed, 103 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/59/39559/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index d904241..4abfc4a 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -92,6 +92,8 @@ trau_conv/trau16_efr_twts001.ok \ trau_conv/trau16_fr.in trau_conv/trau16_fr_std.ok \ trau_conv/trau16_fr_twts001.ok \ + trau_conv/trau2rtp_hr.in trau_conv/trau2rtp_hr_std.ok \ + trau_conv/trau2rtp_hr_twts002.ok \ trau_sync/trau_sync_test.ok trau_sync/trau_sync_test.err \ trau_pcu_ericsson/trau_pcu_ericsson_test.ok diff --git a/tests/testsuite.at b/tests/testsuite.at index 70e7f25..291d47d 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -78,3 +78,15 @@ cat $abs_srcdir/trau_conv/trau16_efr_twts001.ok > expout AT_CHECK([$abs_top_builddir/tests/trau_conv/trau16_to_rtp $abs_srcdir/trau_conv/trau16_efr.in ul tw-ts-001], [0], [expout], [ignore]) AT_CLEANUP + +AT_SETUP([trau2rtp_hr_std]) +AT_KEYWORDS([trau2rtp_hr_std]) +cat $abs_srcdir/trau_conv/trau2rtp_hr_std.ok > expout +AT_CHECK([$abs_top_builddir/tests/trau_conv/trau2rtp_gen -8 $abs_srcdir/trau_conv/trau2rtp_hr.in], [0], [expout], [ignore]) +AT_CLEANUP + +AT_SETUP([trau2rtp_hr_twts002]) +AT_KEYWORDS([trau2rtp_hr_twts002]) +cat $abs_srcdir/trau_conv/trau2rtp_hr_twts002.ok > expout +AT_CHECK([$abs_top_builddir/tests/trau_conv/trau2rtp_gen -8 -x $abs_srcdir/trau_conv/trau2rtp_hr.in], [0], [expout], [ignore]) +AT_CLEANUP diff --git a/tests/trau_conv/trau2rtp_hr.in b/tests/trau_conv/trau2rtp_hr.in new file mode 100644 index 0000000..dcf33f8 --- /dev/null +++ b/tests/trau_conv/trau2rtp_hr.in @@ -0,0 +1,61 @@ +# This file is an input to trau2rtp_gen unit test program, containing +# TRAU-8k Abis-UL frames for TCH/HS. +# +# Most test frames in this set (all except a few hand-crafted ones) were +# taken from an E1-Abis UL capture from Nokia InSite BTS, specifically +# from hr-test2.bin E1 timeslot capture file posted here: +# +# https://osmocom.org/projects/retro-gsm/wiki/InSite_UL_captures +# +# The extraction of hex-encoded TRAU frames from the E1 timeslot octet stream +# capture was done with trau-hr-dump program (-r option) developed in this +# repository: +# +# https://www.freecalypso.org/hg/gsm-net-reveng/ + +# 2 good speech frames from the beginning of the call + +# Frame at 0xcf5e: +008846a6afdaf9a197a79d82b1efc4c9b8b0e4bb +# Frame at 0xcffe: +008844b78bdef8a8bd8da681abd6a2aabdf3e8fb + +# a pair of frames stolen for FACCH, the first of which falls on a TAF position + +# Frame at 0xd31e: +008970e480e5808081f180a180fc809881d084fb +# Frame at 0xd3be: +008964e48681808081f182eb80e78099eb9d89fb + +# some voiced speech frames + +# Frame at 0xdb3e: +00884694caaa89dc8083b89cc881e99a86adbebb +# Frame at 0xdbde: +008846e9e692c49bd1d3afac8aeec9f7a9d1efbb +# Frame at 0xdc7e: +00884789ff91c1bc93c7efca9f92c6f5a4b1f5fb +# Frame at 0xdd1e: +00884799ff82e09febd8aec895f4c2f1e1cfe8bb + +# a valid SID frame + +# Frame at 0x12c7e: +00885084dfddccdfffaffffffffffffffffffffb + +# an invalid SID frame + +# Frame at 0x133fe: +0089408799deb8ffffdffffffffffef5fffafffb + +# hand-crafted test frames follow + +# test handling of CRC: frames that begin like good speech, +# but the 115 bits of payload+CRC are either all-0 or all-1 +00884480808080808080808080808080808080bb +008847fffffffffffffffffffffffffffffffffb + +# good speech frame (copy of 0xdd1e) with XC6 flipped (parity error) +00884399ff82e09febd8aec895f4c2f1e1cfe8bb +# flip XC1 too: parity becomes good again, but the code is now undefined +008a4399ff82e09febd8aec895f4c2f1e1cfe8bb diff --git a/tests/trau_conv/trau2rtp_hr_std.ok b/tests/trau_conv/trau2rtp_hr_std.ok new file mode 100644 index 0000000..d017a87 --- /dev/null +++ b/tests/trau_conv/trau2rtp_hr_std.ok @@ -0,0 +1,14 @@ +00932FB5E509773A098EF8925C30C8 +001B8BBDE143DD4C055D644A9EF3D1 +NULL +NULL +008A4A5426E0037072401D26832D7C +00B4E62510DD135EB056E93DD4D1DE +00C4FF2305E137DF28F928DD5231EB +00CCFF0580FEB85D20AF485C70CFD0 +20025FBB32FFFFFFFFFFFFFFFFFFFF +NULL +NULL +NULL +NULL +NULL diff --git a/tests/trau_conv/trau2rtp_hr_twts002.ok b/tests/trau_conv/trau2rtp_hr_twts002.ok new file mode 100644 index 0000000..db65082 --- /dev/null +++ b/tests/trau_conv/trau2rtp_hr_twts002.ok @@ -0,0 +1,14 @@ +00932FB5E509773A098EF8925C30C8 +001B8BBDE143DD4C055D644A9EF3D1 +613200CA000011008407C00600D009 +6032060200001105AC067006759D13 +008A4A5426E0037072401D26832D7C +00B4E62510DD135EB056E93DD4D1DE +00C4FF2305E137DF28F928DD5231EB +00CCFF0580FEB85D20AF485C70CFD0 +20025FBB32FFFFFFFFFFFFFFFFFFFF +10 +70 +70 +70 +70 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39559?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Id2703d313f52fa54465a13f3370ebb6d7d976bbd Gerrit-Change-Number: 39559 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org>

4 months, 2 weeks

1
0
0 0

[M] Change in libosmo-abis[master]: tests: add trau2rtp_gen program

by falconia

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39558?usp=email ) Change subject: tests: add trau2rtp_gen program ...................................................................... tests: add trau2rtp_gen program This test program converts TRAU-16k or TRAU-8k frames into RTP payloads, both represented in hex. (Hex representation of RTP payloads follows TW-TS-005 spec; hex representation of TRAU frames is ad hoc.) It can be used as a basis for unit tests, verifying that a given TRAU frame input turns into corresponding RTP output, and it can also be used (in conjuction with additional Themyscira utilities) to turn captured TRAU frame streams into playable audio. Change-Id: I3cc8502406e930317b680b0ace2fce479e495ccd --- M .gitignore M tests/Makefile.am A tests/trau_conv/trau2rtp_gen.c 3 files changed, 220 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/58/39558/1 diff --git a/.gitignore b/.gitignore index fd0974d..dbe50db 100644 --- a/.gitignore +++ b/.gitignore @@ -44,6 +44,7 @@ tests/raa_prime/test_enc tests/trau_pcu_ericsson/trau_pcu_ericsson_test tests/trau_conv/trau16_to_rtp +tests/trau_conv/trau2rtp_gen tests/trau_sync/trau_sync_test diff --git a/tests/Makefile.am b/tests/Makefile.am index 04ce529..d904241 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -9,6 +9,7 @@ raa_prime/test_dec \ raa_prime/test_enc \ trau_conv/trau16_to_rtp \ + trau_conv/trau2rtp_gen \ trau_sync/trau_sync_test \ trau_pcu_ericsson/trau_pcu_ericsson_test @@ -54,6 +55,9 @@ trau_conv_trau16_to_rtp_SOURCES = trau_conv/trau16_to_rtp.c trau_conv_trau16_to_rtp_LDADD = $(TRAU_LA_LIBS) +trau_conv_trau2rtp_gen_SOURCES = trau_conv/trau2rtp_gen.c +trau_conv_trau2rtp_gen_LDADD = $(TRAU_LA_LIBS) + trau_sync_trau_sync_test_SOURCES = trau_sync/trau_sync_test.c trau_sync_trau_sync_test_LDADD = $(TRAU_LA_LIBS) diff --git a/tests/trau_conv/trau2rtp_gen.c b/tests/trau_conv/trau2rtp_gen.c new file mode 100644 index 0000000..60d98c8 --- /dev/null +++ b/tests/trau_conv/trau2rtp_gen.c @@ -0,0 +1,215 @@ +/* + * This program is a generic exerciser for libosmotrau functions + * osmo_trau_frame_decode_16k() or osmo_trau_frame_decode_8k(), + * followed by osmo_trau2rtp(). Specifically, it reads input in the form + * of hex lines, with each line representing a TRAU-16k frame as a string + * of 80 hex digits or a TRAU-8k frame as a string of 40 hex digits, + * passes each TRAU frame thus read into libosmotrau functions under test, + * and emits the resulting RTP payload in another hex format defined in + * TW-TS-005. IOW, this program is a hex-to-hex converter where input + * hex lines represent TRAU frames and output hex lines represent RTP payloads. + * + * Spec reference for output hex format: + * https://www.freecalypso.org/specs/tw-ts-005-v010003.txt + * + * Author: Mychaela N. Falconia <falcon(a)freecalypso.org>, 2025 - however, + * Mother Mychaela's contributions are NOT subject to copyright. + * No rights reserved, all rights relinquished. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <ctype.h> +#include <stdio.h> +#include <stdint.h> +#include <stdbool.h> +#include <stdlib.h> +#include <string.h> +#include <unistd.h> + +#include <osmocom/core/bits.h> +#include <osmocom/core/utils.h> +#include <osmocom/trau/trau_frame.h> +#include <osmocom/trau/trau_rtp.h> +#include <osmocom/gsm/rtp_extensions.h> + +static enum osmo_trau_frame_direction direction; +static bool trau_8k_mode; +static struct osmo_trau2rtp_state trau2rtp_st; +static FILE *out_file; + +static void do_trau_frame_16k(struct osmo_trau_frame *tf, const char *hex_str) +{ + uint8_t input_bytes[40]; + ubit_t trau_bits[320]; + int rc; + + osmo_hexparse(hex_str, input_bytes, sizeof(input_bytes)); + osmo_pbit2ubit(trau_bits, input_bytes, sizeof(trau_bits)); + rc = osmo_trau_frame_decode_16k(tf, trau_bits, direction); + if (rc < 0) { + fprintf(stderr, + "error: osmo_trau_frame_decode_16k() returned %d\n", + rc); + exit(1); + } +} + +static void do_trau_frame_8k(struct osmo_trau_frame *tf, const char *hex_str) +{ + uint8_t input_bytes[20]; + ubit_t trau_bits[160]; + int rc; + + osmo_hexparse(hex_str, input_bytes, sizeof(input_bytes)); + osmo_pbit2ubit(trau_bits, input_bytes, sizeof(trau_bits)); + rc = osmo_trau_frame_decode_8k(tf, trau_bits, direction); + if (rc < 0) { + fprintf(stderr, + "error: osmo_trau_frame_decode_8k() returned %d\n", + rc); + exit(1); + } +} + +static void emit_hex_frame(const uint8_t *frame, unsigned nbytes) +{ + unsigned n; + + for (n = 0; n < nbytes; n++) + fprintf(out_file, "%02X", frame[n]); + putc('\n', out_file); +} + +static void process_record(const char *hex_input) +{ + struct osmo_trau_frame tf; + uint8_t rtp_pl[40]; /* maximum RTP payload length for TW-TS-005 */ + int rc; + + if (trau_8k_mode) + do_trau_frame_8k(&tf, hex_input); + else + do_trau_frame_16k(&tf, hex_input); + trau2rtp_st.type = tf.type; + rc = osmo_trau2rtp(rtp_pl, sizeof(rtp_pl), &tf, &trau2rtp_st); + if (rc < 0) { + fprintf(stderr, "error: osmo_trau2rtp() returned %d\n", rc); + exit(1); + } + if (rc == 0) { + /* TW-TS-005 section 4.3.1 */ + fputs("NULL\n", out_file); + return; + } + emit_hex_frame(rtp_pl, rc); +} + +static void process_line(char *linebuf, const char *infname, int lineno) +{ + char *cp = linebuf, *hex_str; + int ndig, expect_digits; + + while (isspace(*cp)) + cp++; + if (*cp == '\0' || *cp == '#') + return; + /* expect string of 40 or 80 hex digits */ + if (trau_8k_mode) + expect_digits = 40; + else + expect_digits = 80; + hex_str = cp; + for (ndig = 0; ndig < expect_digits; ndig++) { + if (!isxdigit(*cp)) + goto inv; + cp++; + } + if (*cp) { + if (!isspace(*cp)) + goto inv; + *cp++ = '\0'; + } + /* must be end of non-comment line */ + while (isspace(*cp)) + cp++; + if (*cp != '\0' && *cp != '#') + goto inv; + + process_record(hex_str); + return; + +inv: fprintf(stderr, "%s line %d: invalid syntax\n", infname, lineno); + exit(1); +} + +static void process_file(const char *infname, const char *outfname) +{ + FILE *inf; + char linebuf[256]; + int lineno; + + inf = fopen(infname, "r"); + if (!inf) { + perror(infname); + exit(1); + } + if (outfname) { + out_file = fopen(outfname, "w"); + if (!out_file) { + perror(outfname); + exit(1); + } + } else { + out_file = stdout; + } + for (lineno = 1; fgets(linebuf, sizeof(linebuf), inf); lineno++) + process_line(linebuf, infname, lineno); + fclose(inf); + if (outfname) { + fclose(out_file); + out_file = NULL; + } +} + +int main(int argc, char **argv) +{ + int opt; + extern int optind; + + trau_8k_mode = false; + direction = OSMO_TRAU_DIR_UL; + trau2rtp_st.rtp_extensions = 0; + while ((opt = getopt(argc, argv, "8dx")) != EOF) { + switch (opt) { + case '8': + trau_8k_mode = true; + break; + case 'd': + direction = OSMO_TRAU_DIR_DL; + break; + case 'x': + trau2rtp_st.rtp_extensions = + OSMO_RTP_EXT_TWTS001 | OSMO_RTP_EXT_TWTS002; + break; + default: + goto usage; + } + } + if (argc < optind + 1 || argc > optind + 2) + goto usage; + process_file(argv[optind], argv[optind + 1]); + exit(0); + +usage: fprintf(stderr, "usage: %s [-8] [-d] [-x] input-file [output-file]\n", + argv[0]); + exit(1); +} -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39558?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I3cc8502406e930317b680b0ace2fce479e495ccd Gerrit-Change-Number: 39558 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org>

4 months, 2 weeks

1
0
0 0

[M] Change in osmo-msc[master]: vlr: when receiving imsi detach, purge the subscriber towards HLR

by lynxis lazus

Attention is currently required from: neels, pespin. Hello Jenkins Builder, neels, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/38489?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Code-Review+1 by neels, Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: vlr: when receiving imsi detach, purge the subscriber towards HLR ...................................................................... vlr: when receiving imsi detach, purge the subscriber towards HLR The HLR must know when a subscriber has been disconnected. Change-Id: I9c2569c45e69b422ce26050b682e6eb26c1c2625 --- M src/libvlr/vlr.c M tests/msc_vlr/msc_vlr_test_authen_reuse.c M tests/msc_vlr/msc_vlr_test_authen_reuse.err M tests/msc_vlr/msc_vlr_test_gsm_authen.c M tests/msc_vlr/msc_vlr_test_gsm_authen.err M tests/msc_vlr/msc_vlr_test_gsm_ciph.c M tests/msc_vlr/msc_vlr_test_gsm_ciph.err M tests/msc_vlr/msc_vlr_test_ms_timeout.c M tests/msc_vlr/msc_vlr_test_ms_timeout.err M tests/msc_vlr/msc_vlr_test_no_authen.c M tests/msc_vlr/msc_vlr_test_no_authen.err M tests/msc_vlr/msc_vlr_test_reject_concurrency.c M tests/msc_vlr/msc_vlr_test_reject_concurrency.err M tests/msc_vlr/msc_vlr_test_rest.c M tests/msc_vlr/msc_vlr_test_rest.err M tests/msc_vlr/msc_vlr_test_umts_authen.c M tests/msc_vlr/msc_vlr_test_umts_authen.err 17 files changed, 73 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/89/38489/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38489?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9c2569c45e69b422ce26050b682e6eb26c1c2625 Gerrit-Change-Number: 38489 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

4 months, 2 weeks

1
0
0 0

[M] Change in osmo-msc[master]: vlr: add PS support

by lynxis lazus

Attention is currently required from: daniel, laforge, neels, pespin. Hello Jenkins Builder, daniel, laforge, neels, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: vlr: add PS support ...................................................................... vlr: add PS support Add vlr_ra_update() similar to vlr_lu_update(). Implement resending of GMM PDUs. While CS has a reliable connection between the MS and MSC, the MS and SGSN doesn't have such connection. The PDU is resend N times before the LU fsm is failing. Change-Id: Ie9ffeb140c9d354b3a0f4822e2619f623235add0 --- M src/libvlr/vlr.c M src/libvlr/vlr_lu_fsm.c 2 files changed, 208 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/90/38490/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie9ffeb140c9d354b3a0f4822e2619f623235add0 Gerrit-Change-Number: 38490 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

4 months, 2 weeks

1
0
0 0

[S] Change in osmo-msc[master]: vlr: extend the subscriber invalidate callback with reasons

by lynxis lazus

Attention is currently required from: lynxis lazus, neels, pespin. Hello Jenkins Builder, neels, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/38488?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: vlr: extend the subscriber invalidate callback with reasons ...................................................................... vlr: extend the subscriber invalidate callback with reasons The VLR must be allowed to notify the MSC if a subscriber becomes invalid. There are multiple cases when this happens: a) if the subscriber didn't do a Location Update Procedure within the given periodic timer. b) if the HLR does a Cancel Location Procedure with reason withdraw c) if the HLR does a Cancel Location Procedure with reason update location. Change-Id: Ie5b687318b106a230fcee52deba86649641004b3 --- M include/osmocom/vlr/vlr.h M src/libmsc/gsm_04_08.c M src/libvlr/vlr.c 3 files changed, 14 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/88/38488/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38488?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie5b687318b106a230fcee52deba86649641004b3 Gerrit-Change-Number: 38488 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

4 months, 2 weeks

1
0
0 0

[L] Change in osmo-msc[master]: vlr_lu_fsm: terminate the FSM instead of dispatching only a signal to...

by lynxis lazus

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/38491?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: vlr_lu_fsm: terminate the FSM instead of dispatching only a signal to the parent ...................................................................... vlr_lu_fsm: terminate the FSM instead of dispatching only a signal to the parent CS doesn't need this because the FSM is bound to the signalling connection, but for PS, there is no direct signalling connection in the SGSN. Change-Id: I27fd1048f85363797b43808d2061ce28be6da81b --- M src/libvlr/vlr_lu_fsm.c M tests/msc_vlr/msc_vlr_test_authen_reuse.err M tests/msc_vlr/msc_vlr_test_call.err M tests/msc_vlr/msc_vlr_test_gsm_authen.err A tests/msc_vlr/msc_vlr_test_gsm_authen.err.err M tests/msc_vlr/msc_vlr_test_gsm_ciph.err M tests/msc_vlr/msc_vlr_test_hlr_reject.err M tests/msc_vlr/msc_vlr_test_hlr_timeout.err M tests/msc_vlr/msc_vlr_test_ms_timeout.err M tests/msc_vlr/msc_vlr_test_no_authen.err M tests/msc_vlr/msc_vlr_test_reject_concurrency.err M tests/msc_vlr/msc_vlr_test_rest.err M tests/msc_vlr/msc_vlr_test_ss.err M tests/msc_vlr/msc_vlr_test_umts_authen.err 14 files changed, 369 insertions(+), 367 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/91/38491/8 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38491?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I27fd1048f85363797b43808d2061ce28be6da81b Gerrit-Change-Number: 38491 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>

4 months, 2 weeks

1
0
0 0

[S] Change in osmo-msc[master]: RFC: vlr: vlr_lu_fsm: update the HLR only on initial IMSI attach

by lynxis lazus

lynxis lazus has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/38492?usp=email ) Change subject: RFC: vlr: vlr_lu_fsm: update the HLR only on initial IMSI attach ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38492?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I7adc2092557f8cc6bb358234df2d1a16d1036eee Gerrit-Change-Number: 38492 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>

4 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2025