osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/aram-applet/+/39584?usp=email )
Change subject: README: update after setting up gerrit and jenkins
......................................................................
README: update after setting up gerrit and jenkins
Change-Id: Ia27839881c0c739f58835ed883079b3ea60cb0e1
---
M README.md
1 file changed, 22 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/aram-applet refs/changes/84/39584/1
diff --git a/README.md b/README.md
index b11c171..fc25c1e 100644
--- a/README.md
+++ b/README.md
@@ -1,11 +1,23 @@
# ARAM Applet
-[…
-[](https://coveralls.io/github/bertrandmartel/aram-applet?branch=master)
-
JavaCard implementation of Global Platform Access Rule Application Master (ARA-M) applet according to
[Secure Element Access Control v1.1](https://globalplatform.org/specs-library/secure-element-access-contro… specification.
+## Contributing
+
+The git repository for this project is at:
+https://gitea.osmocom.org/sim-card/aram-applet
+
+This project was forked from:
+https://github.com/bertrandmartel/aram-applet
+
+We use Gerrit for patch submission and review. See the
+[Osmocom wiki](https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit)
+for details.
+
+The current patch queue for aram-applet can be seen at:
+https://gerrit.osmocom.org/#/q/project:aram-applet+status:open
+
## What is this ?
ARA-M is an application (typically present on a SIM card) which manages access rules that are enforced by an Access Control Enforcer (typically present on [Android device](https://github.com/seek-for-android/pool/wiki)).
@@ -49,7 +61,7 @@
#### Prepare the repository
```bash
-git clone git@github.com:bertrandmartel/aram-applet.git
+git clone https://gitea.osmocom.org/sim-card/aram-applet
cd aram-applet
git submodule update --init
```
@@ -64,6 +76,9 @@
* Older JDK versions are available here:
<https://www.oracle.com/de/java/technologies/javase/jdk11-archive-downloads.…>
+Find the pre-built applet of current master as artifact in the
+[Osmocom Jenkins](https://jenkins.osmocom.org/jenkins/job/master-aram-applet/lastSuc….
+
```bash
JAVA_HOME=/path/to/your/jdk1.8.0_421/ ./gradlew build
```
@@ -146,4 +161,6 @@
## License
-The MIT License (MIT) Copyright (c) 2017 Bertrand Martel
\ No newline at end of file
+The MIT License (MIT) Copyright (c) 2017 Bertrand Martel
+
+Copyright (c) 2025 sysmocom - s.f.m.c. GmbH
--
To view, visit https://gerrit.osmocom.org/c/aram-applet/+/39584?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: aram-applet
Gerrit-Branch: master
Gerrit-Change-Id: Ia27839881c0c739f58835ed883079b3ea60cb0e1
Gerrit-Change-Number: 39584
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/aram-applet/+/39583?usp=email )
Change subject: gradlew: fix "Unrecognized option: --add-opens"
......................................................................
gradlew: fix "Unrecognized option: --add-opens"
Comment out the code that causes the following errors during build:
+ ./gradlew test
Unrecognized option: --add-opens
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.
The build did not abort but this is distracting.
Change-Id: I788e44cfe20ba6a331e8247677ecb5a526c433f7
---
M gradlew
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/aram-applet refs/changes/83/39583/1
diff --git a/gradlew b/gradlew
index 17a9170..f03a59b 100755
--- a/gradlew
+++ b/gradlew
@@ -162,9 +162,10 @@
APP_ARGS=$(save "$@")
# Collect all arguments for the java command, following the shell quoting and substitution rules
-if $JAVACMD --add-opens java.base/java.lang=ALL-UNNAMED -version ; then
- DEFAULT_JVM_OPTS="--add-opens java.base/java.lang=ALL-UNNAMED $DEFAULT_JVM_OPTS"
-fi
+# NOTE: commented out as this doesn't work with openjdk-8
+# if $JAVACMD --add-opens java.base/java.lang=ALL-UNNAMED -version ; then
+# DEFAULT_JVM_OPTS="--add-opens java.base/java.lang=ALL-UNNAMED $DEFAULT_JVM_OPTS"
+# fi
eval set -- $DEFAULT_JVM_OPTS $JAVA_OPTS $GRADLE_OPTS "\"-Dorg.gradle.appname=$APP_BASE_NAME\"" -classpath "\"$CLASSPATH\"" org.gradle.wrapper.GradleWrapperMain "$APP_ARGS"
--
To view, visit https://gerrit.osmocom.org/c/aram-applet/+/39583?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: aram-applet
Gerrit-Branch: master
Gerrit-Change-Id: I788e44cfe20ba6a331e8247677ecb5a526c433f7
Gerrit-Change-Number: 39583
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/39557?usp=email )
Change subject: gprs: define OSMO_RESERVED_RAC 0xff
......................................................................
Patch Set 1:
(1 comment)
File include/osmocom/gsm/protocol/gsm_04_08_gprs.h:
https://gerrit.osmocom.org/c/libosmocore/+/39557/comment/6eb468e3_c158614c?… :
PS1, Line 14: #define OSMO_RESERVED_RAC 0xff
> Somehow I send it away in the middle of the sentence.. […]
Yeah ok, but I don't see how any of that makes it osmocom specific...
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39557?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I17a2adedc2c2ab158f40d58280f5df5c6967b8ec
Gerrit-Change-Number: 39557
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 19 Feb 2025 13:11:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/39557?usp=email )
Change subject: gprs: define OSMO_RESERVED_RAC 0xff
......................................................................
Patch Set 1:
(1 comment)
File include/osmocom/gsm/protocol/gsm_04_08_gprs.h:
https://gerrit.osmocom.org/c/libosmocore/+/39557/comment/04069be3_b1ef0c11?… :
PS1, Line 14: #define OSMO_RESERVED_RAC 0xff
> I didn't get what you mean sorry, do hou mind rephrasing?
Somehow I send it away in the middle of the sentence..
Because it is more an implicit definition. So far I understand, the 0xff is invalid for a RAC as cell id to be transmitted over the air.
But a UE will save the RAC 0xff on the simcard if it doensn't has a valid RAC (e.g. no PS services).
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39557?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I17a2adedc2c2ab158f40d58280f5df5c6967b8ec
Gerrit-Change-Number: 39557
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 18 Feb 2025 21:14:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-upf/+/39581?usp=email )
Change subject: Increase per PDR (F-TEID) hashtable size
......................................................................
Increase per PDR (F-TEID) hashtable size
In tunmap scenario there's usually 2 PDRs/local-F-TEIDs per session,
hence it makes sense to at least double the hashtable size with respect
to session hashtable. In here we actually multiply it by 2 twice since
this is actually global and not per peer, hence we account for multiple
peers.
Change-Id: I7ee3e875020d707c05e13ee70952174ca4daad30
---
M include/osmocom/upf/upf.h
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/81/39581/1
diff --git a/include/osmocom/upf/upf.h b/include/osmocom/upf/upf.h
index 1e5d702..2f25c99 100644
--- a/include/osmocom/upf/upf.h
+++ b/include/osmocom/upf/upf.h
@@ -116,13 +116,13 @@
int priority_post;
uint32_t next_chain_id_state;
/* hashtable of (struct upf_nft_tun)->node_by_chain_id: */
- DECLARE_HASHTABLE(nft_tun_by_chain_id, 10);
+ DECLARE_HASHTABLE(nft_tun_by_chain_id, 12);
} tunmap;
struct {
uint32_t next_local_teid_state;
/* hashtable of (struct pdr)->node_by_local_f_teid: */
- DECLARE_HASHTABLE(pdrs_by_local_f_teid, 10);
+ DECLARE_HASHTABLE(pdrs_by_local_f_teid, 12);
uint16_t next_echo_seq_nr;
} gtp;
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/39581?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I7ee3e875020d707c05e13ee70952174ca4daad30
Gerrit-Change-Number: 39581
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/39580?usp=email )
Change subject: pfcp_endpoint: Increase sent_{requests,responses}_by_seq_nr hashtable size
......................................................................
pfcp_endpoint: Increase sent_{requests,responses}_by_seq_nr hashtable size
Change-Id: Ie0bb28240b3a83a1776702f26d79a09e8f0e30f6
---
M src/libosmo-pfcp/pfcp_endpoint.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/80/39580/1
diff --git a/src/libosmo-pfcp/pfcp_endpoint.c b/src/libosmo-pfcp/pfcp_endpoint.c
index d6c109b..7c1058f 100644
--- a/src/libosmo-pfcp/pfcp_endpoint.c
+++ b/src/libosmo-pfcp/pfcp_endpoint.c
@@ -52,12 +52,12 @@
* For a transmitted Request message, wait for a matching Response from a remote peer; if none arrives,
* retransmit (see n1 and t1_ms). */
struct llist_head sent_requests;
- DECLARE_HASHTABLE(sent_requests_by_seq_nr, 10);
+ DECLARE_HASHTABLE(sent_requests_by_seq_nr, 12);
/* All transmitted PFCP Response messages, list of osmo_pfcp_queue_entry.
* For a transmitted Response message, keep it in the queue for a fixed amount of time. If the peer retransmits
* the original Request, do not dispatch the Request, but respond with the queued message directly. */
struct llist_head sent_responses;
- DECLARE_HASHTABLE(sent_responses_by_seq_nr, 10);
+ DECLARE_HASHTABLE(sent_responses_by_seq_nr, 12);
};
/*! Entry of pfcp_endpoint message queue of PFCP messages, for re-transsions. */
--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/39580?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: Ie0bb28240b3a83a1776702f26d79a09e8f0e30f6
Gerrit-Change-Number: 39580
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-upf/+/39579?usp=email )
Change subject: up_peer: Increase up/cp seid hashtable sizes
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
With this I can already create 200K tunend sessions in 30s. This is faster than tunmap since nft is not involved here.
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/39579?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I424778a4c75000fb67ba4725a6a3e3e91a80fc76
Gerrit-Change-Number: 39579
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Tue, 18 Feb 2025 18:20:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No