January 2025 - gerrit-log - lists.osmocom.org

[XS] Change in meta-telephony[laforge/nightly]: osmo-pcap: depend on libosmo-netif

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/39365?usp=email ) Change subject: osmo-pcap: depend on libosmo-netif ...................................................................... osmo-pcap: depend on libosmo-netif Related: osmo-pcap I3562185f98685ea5a412273212e6dfbe55b360e2 Change-Id: I79425b22fb9a63bbc82bb2b896788f3f7c173276 --- M recipes-osmocom/osmo-pcap/osmo-pcap.inc 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: osmith: Verified pespin: Looks good to me, approved diff --git a/recipes-osmocom/osmo-pcap/osmo-pcap.inc b/recipes-osmocom/osmo-pcap/osmo-pcap.inc index e64ca88..bef1101 100644 --- a/recipes-osmocom/osmo-pcap/osmo-pcap.inc +++ b/recipes-osmocom/osmo-pcap/osmo-pcap.inc @@ -3,7 +3,7 @@ LICENSE = "AGPLv3+" LIC_FILES_CHKSUM = "file://COPYING;md5=73f1eb20517c55bf9493b7dd6e480788" -DEPENDS = "libosmocore zeromq libpcap gnutls" +DEPENDS = "libosmocore zeromq libpcap gnutls libosmo-netif" INC_PR="r2.${META_TELEPHONY_OSMO_INC}" -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/39365?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: meta-telephony Gerrit-Branch: laforge/nightly Gerrit-Change-Id: I79425b22fb9a63bbc82bb2b896788f3f7c173276 Gerrit-Change-Number: 39365 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[XS] Change in meta-telephony[laforge/nightly]: osmo-pcap: depend on libosmo-netif

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/meta-telephony/+/39365?usp=email ) Change subject: osmo-pcap: depend on libosmo-netif ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/39365?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: meta-telephony Gerrit-Branch: laforge/nightly Gerrit-Change-Id: I79425b22fb9a63bbc82bb2b896788f3f7c173276 Gerrit-Change-Number: 39365 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Jan 2025 14:32:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 1 week

1
0
0 0

[XS] Change in meta-telephony[laforge/nightly]: osmo-pcap: depend on libosmo-netif

by osmith

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/meta-telephony/+/39365?usp=email ) Change subject: osmo-pcap: depend on libosmo-netif ...................................................................... Patch Set 1: Verified+1 (1 comment) Patchset: PS1: Verified on sysmocom-oe-userbuilds. This fixes 201705-nightly. -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/39365?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: meta-telephony Gerrit-Branch: laforge/nightly Gerrit-Change-Id: I79425b22fb9a63bbc82bb2b896788f3f7c173276 Gerrit-Change-Number: 39365 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Jan 2025 14:01:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

5 months, 1 week

1
0
0 0

[XS] Change in meta-telephony[laforge/nightly]: osmo-pcap: depend on libosmo-netif

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/meta-telephony/+/39365?usp=email ) Change subject: osmo-pcap: depend on libosmo-netif ...................................................................... osmo-pcap: depend on libosmo-netif Related: osmo-pcap I3562185f98685ea5a412273212e6dfbe55b360e2 Change-Id: I79425b22fb9a63bbc82bb2b896788f3f7c173276 --- M recipes-osmocom/osmo-pcap/osmo-pcap.inc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/65/39365/1 diff --git a/recipes-osmocom/osmo-pcap/osmo-pcap.inc b/recipes-osmocom/osmo-pcap/osmo-pcap.inc index e64ca88..bef1101 100644 --- a/recipes-osmocom/osmo-pcap/osmo-pcap.inc +++ b/recipes-osmocom/osmo-pcap/osmo-pcap.inc @@ -3,7 +3,7 @@ LICENSE = "AGPLv3+" LIC_FILES_CHKSUM = "file://COPYING;md5=73f1eb20517c55bf9493b7dd6e480788" -DEPENDS = "libosmocore zeromq libpcap gnutls" +DEPENDS = "libosmocore zeromq libpcap gnutls libosmo-netif" INC_PR="r2.${META_TELEPHONY_OSMO_INC}" -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/39365?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: meta-telephony Gerrit-Branch: laforge/nightly Gerrit-Change-Id: I79425b22fb9a63bbc82bb2b896788f3f7c173276 Gerrit-Change-Number: 39365 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[S] Change in osmo-bsc[master]: coverity: vty for AMR start mode: clarify range checks

by pespin

Attention is currently required from: neels. pespin has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39364?usp=email ) Change subject: coverity: vty for AMR start mode: clarify range checks ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmo-bsc/bts_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/39364/comment/5b31a029_1a951a15?usp… : PS1, Line 2785: for (int i = 0; i < ((full) ? 8 : 6); i++) { afaiu "i" can also be unsigned? which would be saner since it's only used to shift. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39364?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I34ac83e1441a34fcec6b10c34e10ab6dffa37607 Gerrit-Change-Number: 39364 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Jan 2025 13:23:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

5 months, 1 week

1
0
0 0

[XS] Change in libosmocore[master]: osmo_io: segmentation: Remove unneeded impossible check

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/39360?usp=email ) Change subject: osmo_io: segmentation: Remove unneeded impossible check ...................................................................... osmo_io: segmentation: Remove unneeded impossible check The rc <= 0 case is already early returned above. Change-Id: I9316730aeaf7c7efd3ea8965ab43fa21f844260c --- M src/core/osmo_io.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c index 45aaef3..15703cf 100644 --- a/src/core/osmo_io.c +++ b/src/core/osmo_io.c @@ -343,7 +343,7 @@ do { pending = NULL; res = iofd_handle_segmentation(iofd, msg, &pending); - if (res != IOFD_SEG_ACT_DEFER || rc < 0) { + if (res != IOFD_SEG_ACT_DEFER) { iofd->io_ops.read_cb(iofd, rc, msg); /* The user could unregister/close the iofd during read_cb() above. * Once that's done, it doesn't expect to receive any more events, -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39360?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9316730aeaf7c7efd3ea8965ab43fa21f844260c Gerrit-Change-Number: 39360 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[XS] Change in libosmocore[master]: cosmetic: osmo_io: Improvde documentation of read_cb when segmentatio...

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/39361?usp=email ) Change subject: cosmetic: osmo_io: Improvde documentation of read_cb when segmentation is used ...................................................................... cosmetic: osmo_io: Improvde documentation of read_cb when segmentation is used Change-Id: I93ac0b3224e17bfd1ecd4244a6dc7a44457c06e8 --- M include/osmocom/core/osmo_io.h M src/core/osmo_io.c 2 files changed, 8 insertions(+), 1 deletion(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/core/osmo_io.h b/include/osmocom/core/osmo_io.h index fa1f9c3..f4bfec4 100644 --- a/include/osmocom/core/osmo_io.h +++ b/include/osmocom/core/osmo_io.h @@ -98,7 +98,11 @@ * \param[in] iofd osmo_io_fd for which read() has completed. * \param[in] res return value of the read() call, or -errno in case of error. * \param[in] msg message buffer containing the read data. Ownership is transferred to the - * call-back, and it must make sure to msgb_free() it eventually! */ + * call-back, and it must make sure to msgb_free() it eventually! + * + * NOTE: If segmentation_cb is in use, the bytes read in res value + * may be different than those provided in the msg parameter! + */ void (*read_cb)(struct osmo_io_fd *iofd, int res, struct msgb *msg); /*! completion call-back function when write issued via osmo_iofd_write_msgb() has completed diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c index 15703cf..65c9b33 100644 --- a/src/core/osmo_io.c +++ b/src/core/osmo_io.c @@ -344,6 +344,9 @@ pending = NULL; res = iofd_handle_segmentation(iofd, msg, &pending); if (res != IOFD_SEG_ACT_DEFER) { + /* It it expected as per API spec that we return the + * return value of read here. The amount of bytes in msg is + * available to the user in msg itself. */ iofd->io_ops.read_cb(iofd, rc, msg); /* The user could unregister/close the iofd during read_cb() above. * Once that's done, it doesn't expect to receive any more events, -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39361?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I93ac0b3224e17bfd1ecd4244a6dc7a44457c06e8 Gerrit-Change-Number: 39361 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[XS] Change in libosmo-netif[master]: api doc: stream.h: hint at how to select modern vs legacy mode

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39309?usp=email ) Change subject: api doc: stream.h: hint at how to select modern vs legacy mode ...................................................................... api doc: stream.h: hint at how to select modern vs legacy mode Change-Id: I651fadb1a00e51f347963418b7a6c5d320580d23 --- M include/osmocom/netif/stream.h 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve neels: Looks good to me, approved diff --git a/include/osmocom/netif/stream.h b/include/osmocom/netif/stream.h index a132a27..f63560a 100644 --- a/include/osmocom/netif/stream.h +++ b/include/osmocom/netif/stream.h @@ -32,6 +32,9 @@ * For any new applications, you definitely should use the modern mode, as it provides you with a higher * layer of abstraction and allows you to perform efficient I/O using the io_uring backend of osmo_io. * + * The modern mode is chosen by invoking osmo_stream_srv_create2(). + * The legacy mode is chosen by invoking the older osmo_stream_srv_create(). + * * The two main objects are osmo_stream_srv_link (main server accept()ing incoming connections) and * osmo_stream_srv (a single given connection from a remote client). * @@ -160,6 +163,9 @@ * For any new applications, you definitely should use the modern mode, as it provides you with a higher * layer of abstraction and allows you to perform efficient I/O using the io_uring backend of osmo_io. * + * The modern mode is chosen by invoking osmo_stream_cli_set_read_cb2(). + * The legacy mode is chosen by invoking the older osmo_stream_cli_set_read_cb(). + * * A typical usage of osmo_stream_cli would look as follows: * * * call osmo_stream_cli_create() to create a new osmo_stream_cli -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39309?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I651fadb1a00e51f347963418b7a6c5d320580d23 Gerrit-Change-Number: 39309 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[XS] Change in libosmo-netif[master]: api doc: stream.h: hint at how to select modern vs legacy mode

by neels

Attention is currently required from: laforge, pespin. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39309?usp=email ) Change subject: api doc: stream.h: hint at how to select modern vs legacy mode ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File include/osmocom/netif/stream.h: https://gerrit.osmocom.org/c/libosmo-netif/+/39309/comment/b40f78da_9704601… : PS1, Line 36: * The legacy mode is chosen by invoking the older osmo_stream_srv_create(). > maybe at some point, but at the moment it's just about a year old and we haven't even bothered to co […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39309?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I651fadb1a00e51f347963418b7a6c5d320580d23 Gerrit-Change-Number: 39309 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Jan 2025 12:46:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[S] Change in osmo-bsc[master]: coverity: vty for AMR start mode: clarify range checks

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39364?usp=email ) Change subject: coverity: vty for AMR start mode: clarify range checks ...................................................................... coverity: vty for AMR start mode: clarify range checks Coverity complains about a possible overflow to smod = -1. Clarify by some type sanity that this is actually not possible. Related: CID#465560 Change-Id: I34ac83e1441a34fcec6b10c34e10ab6dffa37607 --- M src/osmo-bsc/bts_vty.c 1 file changed, 17 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/64/39364/1 diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c index 1babd4d..9c68b75 100644 --- a/src/osmo-bsc/bts_vty.c +++ b/src/osmo-bsc/bts_vty.c @@ -2781,23 +2781,32 @@ struct amr_multirate_conf *mr = (full) ? &bts->mr_full: &bts->mr_half; struct gsm48_multi_rate_conf *mr_conf = (struct gsm48_multi_rate_conf *) mr->gsm48_ie; - int num = 0, i; - - for (i = 0; i < ((full) ? 8 : 6); i++) { + unsigned int num = 0; + for (int i = 0; i < ((full) ? 8 : 6); i++) { if ((mr->gsm48_ie[1] & (1 << i))) { num++; } } - if (argv[0][0] == 'a' || num == 0) { + /* When the user passed "auto", set ICMI=0. + * Otherwise, pass ICMI=1 and the start mode in smod. + * (smod starts with index 0, while arguments and 'num' start with index 1). + */ + if (strcmp(argv[0], "auto") == 0 || num == 0) { mr_conf->icmi = 0; mr_conf->smod = 0; } else { + int arg = atoi(argv[0]); + /* clarify for coverity: the VTY argument spec is (auto|1|2|3|4). */ + OSMO_ASSERT(arg >= 1 && arg <= 4); + + /* If there are less modes than the start mode the user is asking for, fall back to the last available + * mode. (FIXME: should this complain and fail instead?) + * 'num' is guaranteed to be > 0 here. */ + num = OSMO_MIN(num, arg); + mr_conf->icmi = 1; - if (num < atoi(argv[0])) - mr_conf->smod = num - 1; - else - mr_conf->smod = atoi(argv[0]) - 1; + mr_conf->smod = num - 1; } } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39364?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I34ac83e1441a34fcec6b10c34e10ab6dffa37607 Gerrit-Change-Number: 39364 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>

5 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2025