January 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-iuh[master]: iu_client: add a new event NEW_LAC_RAC

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-iuh/+/38947?usp=email ) Change subject: iu_client: add a new event NEW_LAC_RAC ...................................................................... Patch Set 3: (1 comment) File include/osmocom/ranap/iu_client.h: https://gerrit.osmocom.org/c/osmo-iuh/+/38947/comment/870b9f7d_4dc57d52?usp… : PS3, Line 50: RANAP_IU_EVENT_NEW_LAC_RAC, /* Either a new LAC/RAC has been detected */ > Btw. iu_client is also somehow deprecated. Because it abstractions are not well designed. […] Fine, just wanted you to notice those existed too in case it made sense. -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/38947?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I8b1b8c58bf72b00e2705ca87a89a91481bac3470 Gerrit-Change-Number: 38947 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 07 Jan 2025 18:08:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

5 months, 2 weeks

1
0
0 0

[S] Change in osmo-sgsn[master]: gprs_gmm_util: use a RAU specific TLV dictionary

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39247?usp=email ) Change subject: gprs_gmm_util: use a RAU specific TLV dictionary ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/sgsn/gprs_gmm_util.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/39247/comment/729eb211_e4ad3e45?us… : PS1, Line 265: ret = tlv_parse(&rau_req->tlv, &gsm48_gmm_rau_ie_tlvdef, afair we have a specific set of APIs in libosmocore to werap tlv_parse and specify a set of messages... -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39247?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I460971deeebc9977a984937c542b263d941e78df Gerrit-Change-Number: 39247 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 07 Jan 2025 18:07:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

5 months, 2 weeks

1
0
0 0

[M] Change in osmo-sgsn[master]: gprs_gmm_util: add parsing of GMM Attach Requests

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39246?usp=email ) Change subject: gprs_gmm_util: add parsing of GMM Attach Requests ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-sgsn/+/39246/comment/82e6da53_6aed2615?us… : PS1, Line 8: "This will be used in a follow-up patch..." -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39246?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I4a82e0c4070da982efd6c2f15fd145393423772b Gerrit-Change-Number: 39246 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 07 Jan 2025 18:05:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

5 months, 2 weeks

1
0
0 0

[M] Change in osmo-sgsn[master]: gprs_gmm_util: add parsing of GMM Attach Requests

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39246?usp=email ) Change subject: gprs_gmm_util: add parsing of GMM Attach Requests ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39246?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I4a82e0c4070da982efd6c2f15fd145393423772b Gerrit-Change-Number: 39246 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 07 Jan 2025 18:05:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 2 weeks

1
0
0 0

[XS] Change in osmo-sgsn[master]: gprs_gmm_util: add IE GSM48_IE_GMM_UE_NET_CAP

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39245?usp=email ) Change subject: gprs_gmm_util: add IE GSM48_IE_GMM_UE_NET_CAP ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/sgsn/gprs_gmm_util.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/39245/comment/4b79d48b_f62b5522?us… : PS1, Line 55: [GSM48_IE_GMM_UE_NET_CAP] = { TLV_TYPE_TLV, 0 }, Please also submit equivalent commit into libosmo-gprs.git -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39245?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ia8e2630a370f6066f4e3f0ea0d685f1556efac05 Gerrit-Change-Number: 39245 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 07 Jan 2025 18:05:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

5 months, 2 weeks

1
0
0 0

[S] Change in osmo-sgsn[master]: Add include prefix for all libgtp related includes

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39244?usp=email ) Change subject: Add include prefix for all libgtp related includes ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39244?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I5ea50c9766f719e1eea89cbf6783fafc2093773d Gerrit-Change-Number: 39244 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 07 Jan 2025 18:04:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 2 weeks

1
0
0 0

[XS] Change in osmo-sgsn[master]: gprs_ms_net_cap_gea_mask(): protect against empty MS Network Capabili...

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39243?usp=email ) Change subject: gprs_ms_net_cap_gea_mask(): protect against empty MS Network Capabilities ...................................................................... Patch Set 1: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-sgsn/+/39243/comment/e0944bd1_53dcc2e0?us… : PS1, Line 9: When the MS Network Capability is empty, expect to support at least unecnrypted unencrypted https://gerrit.osmocom.org/c/osmo-sgsn/+/39243/comment/0226c7f2_7fbb9b67?us… : PS1, Line 11: This shouldn't be empty at all. this shouldn't be mepty at all you say, yet you add code to handle this case? can you please explain better? -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39243?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ieef2e3eeaaadc90c35fff6f20d47bd36aaa4b9e6 Gerrit-Change-Number: 39243 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 07 Jan 2025 18:04:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

5 months, 2 weeks

1
0
0 0

[S] Change in osmo-sgsn[master]: Refactor mmctx_is_r99 into mmctx.c

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39242?usp=email ) Change subject: Refactor mmctx_is_r99 into mmctx.c ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-sgsn/+/39242/comment/68e285a6_3a8133e8?us… : PS1, Line 9: It is related to the mmctx and doesn't has anything to do with GMM. "doesn't have" what do you mean with mmctx having nothing to do with GMM? it's the GMM context... -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39242?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I198a3c9d49667c70e8995808b3fcb5ea26e8f17a Gerrit-Change-Number: 39242 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 07 Jan 2025 18:03:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

5 months, 2 weeks

1
0
0 0

[M] Change in osmo-sgsn[master]: GMM: rework PDP context status

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39241?usp=email ) Change subject: GMM: rework PDP context status ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-sgsn/+/39241/comment/230b2fbf_b2b0b512?us… : PS1, Line 12: close it while the MS is not reachable. "to resynchronize it close it" is wrong gramatically speaking, rephrase so I can understand.. File src/sgsn/gprs_gmm.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/39241/comment/7bb2fef3_fbf2295d?us… : PS1, Line 200: /* 3GPP TS 24.008 § 10.5.7.1 Process PDP context status value, bit 0 correspond to nsapi 0 */ corresponds -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39241?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I12d3110c9365132f96ef7ff8a1be22a431682c81 Gerrit-Change-Number: 39241 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 07 Jan 2025 18:01:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

5 months, 2 weeks

1
0
0 0

[S] Change in osmo-mgw[master]: Rename mgcp_free_rtp_port() to mgcp_rtp_end_free_port()

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39212?usp=email ) Change subject: Rename mgcp_free_rtp_port() to mgcp_rtp_end_free_port() ...................................................................... Rename mgcp_free_rtp_port() to mgcp_rtp_end_free_port() While at it, moving the only clearly existing API for the same object to the same place to have them together (mgcp_rtp_end_remote_addr_available()). Change-Id: Ifabd1cf69273a6d22feb65c08de590d083987d09 --- M include/osmocom/mgcp/mgcp_network.h M src/libosmo-mgcp/mgcp_conn.c M src/libosmo-mgcp/mgcp_network.c M src/libosmo-mgcp/mgcp_protocol.c 4 files changed, 14 insertions(+), 10 deletions(-) Approvals: Jenkins Builder: Verified daniel: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/include/osmocom/mgcp/mgcp_network.h b/include/osmocom/mgcp/mgcp_network.h index 453fbe9..db3dce7 100644 --- a/include/osmocom/mgcp/mgcp_network.h +++ b/include/osmocom/mgcp/mgcp_network.h @@ -132,6 +132,7 @@ }; bool mgcp_rtp_end_remote_addr_available(const struct mgcp_rtp_end *rtp_end); +void mgcp_rtp_end_free_port(struct mgcp_rtp_end *end); struct mgcp_rtp_tap { /* is this tap active (1) or not (0) */ @@ -152,7 +153,6 @@ void mgcp_cleanup_e1_bridge_cb(struct mgcp_endpoint *endp, struct mgcp_conn *conn); int mgcp_bind_net_rtp_port(struct mgcp_endpoint *endp, int rtp_port, struct mgcp_conn_rtp *conn); -void mgcp_free_rtp_port(struct mgcp_rtp_end *end); void mgcp_patch_and_count(const struct mgcp_endpoint *endp, struct mgcp_rtp_state *state, struct mgcp_rtp_end *rtp_end, diff --git a/src/libosmo-mgcp/mgcp_conn.c b/src/libosmo-mgcp/mgcp_conn.c index b4d971e..e7ff30b 100644 --- a/src/libosmo-mgcp/mgcp_conn.c +++ b/src/libosmo-mgcp/mgcp_conn.c @@ -137,7 +137,7 @@ conn_osmux_disable(conn_rtp); if (mgcp_conn_rtp_is_iuup(conn_rtp)) mgcp_conn_iuup_cleanup(conn_rtp); - mgcp_free_rtp_port(&conn_rtp->end); + mgcp_rtp_end_free_port(&conn_rtp->end); rate_ctr_group_free(conn_rtp->ctrg); mgcp_codec_reset_all(conn_rtp); } diff --git a/src/libosmo-mgcp/mgcp_network.c b/src/libosmo-mgcp/mgcp_network.c index f0111cd..9a993a7 100644 --- a/src/libosmo-mgcp/mgcp_network.c +++ b/src/libosmo-mgcp/mgcp_network.c @@ -85,12 +85,6 @@ static int rx_rtp(struct msgb *msg); -bool mgcp_rtp_end_remote_addr_available(const struct mgcp_rtp_end *rtp_end) -{ - return (osmo_sockaddr_port(&rtp_end->addr.u.sa) != 0) && - (osmo_sockaddr_is_any(&rtp_end->addr) == 0); -} - /*! Determine the local rtp bind IP-address. * \param[out] addr caller provided memory to store the resulting IP-Address. * \param[in] endp mgcp endpoint, that holds a copy of the VTY parameters. @@ -1726,9 +1720,19 @@ return bind_rtp(endp->trunk->cfg, conn->end.local_addr, end, endp); } +/*********************** + * mgcp_rtp_end + **********************/ + +bool mgcp_rtp_end_remote_addr_available(const struct mgcp_rtp_end *rtp_end) +{ + return (osmo_sockaddr_port(&rtp_end->addr.u.sa) != 0) && + (osmo_sockaddr_is_any(&rtp_end->addr) == 0); +} + /*! free allocated RTP and RTCP ports. * \param[in] end RTP end */ -void mgcp_free_rtp_port(struct mgcp_rtp_end *end) +void mgcp_rtp_end_free_port(struct mgcp_rtp_end *end) { if (end->rtp) { osmo_iofd_free(end->rtp); diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c index 98a0062..eef9d5f 100644 --- a/src/libosmo-mgcp/mgcp_protocol.c +++ b/src/libosmo-mgcp/mgcp_protocol.c @@ -1331,7 +1331,7 @@ } if (strcmp(new_local_addr, conn_rtp->end.local_addr)) { osmo_strlcpy(conn_rtp->end.local_addr, new_local_addr, sizeof(conn_rtp->end.local_addr)); - mgcp_free_rtp_port(&conn_rtp->end); + mgcp_rtp_end_free_port(&conn_rtp->end); if (allocate_port(endp, conn_rtp) != 0) { rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_BIND_PORT)); goto error3; -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39212?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ifabd1cf69273a6d22feb65c08de590d083987d09 Gerrit-Change-Number: 39212 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

5 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2025