September 2024 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ttcn3-hacks[master]: testenv/README: consistency fix

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38257?usp=email ) Change subject: testenv/README: consistency fix ...................................................................... testenv/README: consistency fix Add = after the vty_* keys too, like the others. Change-Id: Ic9828b67f5a81498d0e951dd71b80b36cdd36173 --- M _testenv/README.md 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/57/38257/1 diff --git a/_testenv/README.md b/_testenv/README.md index 8562063..2c70a0a 100644 --- a/_testenv/README.md +++ b/_testenv/README.md @@ -91,12 +91,12 @@ below for `PATH`. A `TESTENV_CLEAN_REASON` env var is set to `prepare`, `crashed` or `finished` depending on when the script runs. -* `vty_port`: optionally set the VTY port for the SUT component to obtain a +* `vty_port=`: optionally set the VTY port for the SUT component to obtain a talloc report after each test case has been executed. If this is not set, no talloc reports will be obtained. -* `vty_host`: optionally set the VTY host for the SUT component to be used when - obtaining a talloc report. If this is not set, `127.0.0.1` is used. +* `vty_host=`: optionally set the VTY host for the SUT component to be used + when obtaining a talloc report. If this is not set, `127.0.0.1` is used. ### PATH -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38257?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9828b67f5a81498d0e951dd71b80b36cdd36173 Gerrit-Change-Number: 38257 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

9 months

1
0
0 0

[XL] Change in pysim[master]: tests: sanitize all cards before running tests

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38254?usp=email ) Change subject: tests: sanitize all cards before running tests ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: Do we have some information how much time the restore of all cards takes? File tests/card_sanitizer/restore.script: https://gerrit.osmocom.org/c/pysim/+/38254/comment/70dea27c_d511b702?usp=em… : PS1, Line 3: ru I don't like this approach with a global file in /var/tmp. What if for some reason there's two jobs running by accident? what if somebody else can write to that file? If you must use a temp file, I would suggest it to be created with mkstem(3) or mktemp(1) or some python equivalent thereof. But wouldn't it be much simpler to introduce something like a @-e@ command line argument to pySim-shell, which could be used multiple times to specify multiple commands? Then you could do `pySim-shell -e verify_adm -e run_script /my/path/to/full.script > /dev/null` See https://gerrit.osmocom.org/c/pysim/+/38255 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38254?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I42eaf61280968518164f2280245136fd30a603ce Gerrit-Change-Number: 38254 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Sep 2024 09:55:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

9 months

1
0
0 0

[XS] Change in pysim[master]: pySim-shell: New '-e' command line argument

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/38255?usp=email ) Change subject: pySim-shell: New '-e' command line argument ...................................................................... pySim-shell: New '-e' command line argument Using '-e' it is possible to specify *multiple* pySim-shell commands which shall be executed at startup. This extends the current ability to execute just a single command. Example: ./pySim-shell.py -p0 -e 'select ADF.USIM/EF.IMSI' -e 'read_binary_decoded' Change-Id: I74004f46105553f077c039ca0f86f75afccc7342 --- M pySim-shell.py 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/55/38255/1 diff --git a/pySim-shell.py b/pySim-shell.py index 8c260aa..756ba68 100755 --- a/pySim-shell.py +++ b/pySim-shell.py @@ -1056,6 +1056,8 @@ adm_group.add_argument('-A', '--pin-adm-hex', metavar='PIN_ADM1_HEX', dest='pin_adm_hex', default=None, help='ADM PIN used for provisioning, as hex string (16 characters long)') +option_parser.add_argument('-e', '--execute-command', action='append', + help='A pySim-shell command that will be executed at startup') option_parser.add_argument("command", nargs='?', help="A pySim-shell command that would optionally be executed at startup") option_parser.add_argument('command_args', nargs=argparse.REMAINDER, @@ -1122,6 +1124,13 @@ print(e) print("---------------------8<---------------------") + # Run optional commands + for c in opts.execute_command: + if not startup_errors: + app.onecmd_plus_hooks(c) + else: + print("Errors during startup, refusing to execute command (%s)" % c) + # Run optional command if opts.command: if not startup_errors: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38255?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I74004f46105553f077c039ca0f86f75afccc7342 Gerrit-Change-Number: 38255 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

9 months

1
0
0 0

[M] Change in ...osmo-s1gw[master]: s1ap_proxy: Support replying errors

by fixeria

Attention is currently required from: lynxis lazus, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37924?usp=email ) Change subject: s1ap_proxy: Support replying errors ...................................................................... Patch Set 5: (1 comment) Patchset: PS4: > > One month after submission and my patch is still blocked in here. […] Just to clarify: I am fine with the follow-up patch adding metrics, and I have no objections about merging it as-is. My concern is specifically about this patch. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37924?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I242e84fb09b00f4794b6e1aa770f348a0e60aea4 Gerrit-Change-Number: 37924 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 23 Sep 2024 09:50:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

9 months

1
0
0 0

[M] Change in ...osmo-s1gw[master]: s1ap_proxy: Support replying errors

by fixeria

Attention is currently required from: lynxis lazus, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37924?usp=email ) Change subject: s1ap_proxy: Support replying errors ...................................................................... Patch Set 5: Code-Review-1 (1 comment) Patchset: PS4: > One month after submission and my patch is still blocked in here. Yes, because other than weekly pings there hasn't been any progress on adding testing coverage for this specific change. Unit test infra was already there. The TTCN-3 infra is in a much better shape now, so it should not be a blocker anymore as soon as my big osmo-ttcn3-hacks patchset is merged. I take a chance to ask again: can I take over this patchset and work on adding testing coverage myself? I would also like to change formatting in a few places, but I will not do that without your explicit permission. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37924?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I242e84fb09b00f4794b6e1aa770f348a0e60aea4 Gerrit-Change-Number: 37924 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 23 Sep 2024 09:44:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

9 months

1
0
0 0

[S] Change in osmo-ci[master]: manuals: publish pyosmocom manuals for releases

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/38251?usp=email ) Change subject: manuals: publish pyosmocom manuals for releases ...................................................................... manuals: publish pyosmocom manuals for releases Adjust the building and publishing commands to work for pyosmocom. Remove the 0.0.3 release from TAGS_IGNORE, because it already has manuals. Skip "apt-get -y build-dep" and adjusting "debian/control" if that file does not exist, as it is the case with the 0.0.3 and 0.0.4 releases of pyosmocom. Change-Id: I3799cf825937cdd8dfca9fbd98e8b6b159f7cea8 --- M scripts/manuals/publish-manuals-for-tags.sh 1 file changed, 13 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/scripts/manuals/publish-manuals-for-tags.sh b/scripts/manuals/publish-manuals-for-tags.sh index 690eafc..50b7a3b 100755 --- a/scripts/manuals/publish-manuals-for-tags.sh +++ b/scripts/manuals/publish-manuals-for-tags.sh @@ -203,7 +203,6 @@ pyosmocom:0.0.1, pyosmocom:0.0.2, - pyosmocom:0.0.3, " mkdir -p \ @@ -331,8 +330,10 @@ git clean -dxf # Fix depends on packages that don't exist anymore - sed -i 's/dh-systemd $.*$,//g' debian/control - sed -i 's/python-minimal,//g' debian/control + if [ -e debian/control ]; then + sed -i 's/dh-systemd $.*$,//g' debian/control + sed -i 's/python-minimal,//g' debian/control + fi } # $1: repository @@ -367,7 +368,9 @@ # Install dependencies case $repo in *) - apt-get -y build-dep /build + if [ -e debian/control ]; then + apt-get -y build-dep /build + fi ;; esac @@ -386,6 +389,9 @@ osmo-epdg) su build -c \"make -C docs/manuals\" ;; + pyosmocom) + su build -c \"make -C docs html latexpdf\" + ;; *) su build -c \"autoreconf -fi\" su build -c \"./configure $configure_opts\" @@ -404,6 +410,9 @@ osmo-epdg) su build -c \"make -C docs/manuals publish\" ;; + pyosmocom) + su build -c \"make -C docs publish publish-html\" + ;; *) su build -c \"make -C doc/manuals publish\" ;; -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38251?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3799cf825937cdd8dfca9fbd98e8b6b159f7cea8 Gerrit-Change-Number: 38251 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

9 months

1
0
0 0

[S] Change in osmo-ci[master]: manuals: publish pyosmocom manuals for releases

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38251?usp=email ) Change subject: manuals: publish pyosmocom manuals for releases ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38251?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3799cf825937cdd8dfca9fbd98e8b6b159f7cea8 Gerrit-Change-Number: 38251 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Sep 2024 09:42:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months

1
0
0 0

[M] Change in ...osmo-s1gw[master]: s1ap_proxy: Support replying errors

by laforge

Attention is currently required from: fixeria, lynxis lazus, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37924?usp=email ) Change subject: s1ap_proxy: Support replying errors ...................................................................... Patch Set 5: Code-Review+1 (1 comment) Patchset: PS2: > Let's keep this patch in review until we have functional or at least unit tests. So what is the status here? Why do we have no unit nor functional/integration tests for this patch? Instead we had a lengthy debate about patch review priorities. I agree with @pespin that it's not acceptable to delay a patch for a month - but then I also agree with @fixeria that we should have at least some test coverage. Let's find a solution, please. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37924?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I242e84fb09b00f4794b6e1aa770f348a0e60aea4 Gerrit-Change-Number: 37924 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 23 Sep 2024 09:41:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

9 months

1
0
0 0

[S] Change in osmo-msc[master]: Remove speech codec list from bearer_cap for phase 1 mobile station

by laforge

Attention is currently required from: fixeria, jolly, neels, nt2mku, pespin. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-msc/+/38197?usp=email ) Change subject: Remove speech codec list from bearer_cap for phase 1 mobile station ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38197?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Idd267dad0ade18cee7d5be813a57e1ee3168e2db Gerrit-Change-Number: 38197 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: nt2mku <degrunert.web(a)googlemail.com> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: nt2mku <degrunert.web(a)googlemail.com> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Sep 2024 09:39:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months

1
0
0 0

[XS] Change in pysim[master]: gitignore: add files generated with jenkins.sh

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/38252?usp=email ) Change subject: gitignore: add files generated with jenkins.sh ...................................................................... gitignore: add files generated with jenkins.sh Change-Id: Iaffe04a3dfebd46efc479dc3665fd67f2c95f375 --- M .gitignore 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/.gitignore b/.gitignore index 8401eb2..2eb3d89 100644 --- a/.gitignore +++ b/.gitignore @@ -3,3 +3,7 @@ /docs/_* /docs/generated +/.cache +/.local +/build +/pySim.egg-info -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38252?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iaffe04a3dfebd46efc479dc3665fd67f2c95f375 Gerrit-Change-Number: 38252 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2024