September 2024 - gerrit-log - lists.osmocom.org

[XS] Change in ...pyosmocom[master]: gitignore: add dirs generated with jenkins.sh

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38269?usp=email ) Change subject: gitignore: add dirs generated with jenkins.sh ...................................................................... gitignore: add dirs generated with jenkins.sh Change-Id: Ib255d889a0d65b581a1f4e47a3d767e33ae9b352 --- M .gitignore 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/.gitignore b/.gitignore index f2487b6..0c6adc6 100644 --- a/.gitignore +++ b/.gitignore @@ -4,3 +4,6 @@ build dist docs/_build +/.cache +/.local +/pysim -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38269?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: Ib255d889a0d65b581a1f4e47a3d767e33ae9b352 Gerrit-Change-Number: 38269 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

9 months

1
0
0 0

[S] Change in osmo-sgsn[master]: Use %d instead of %i

by Jenkins Builder

Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/38281?usp=email ) Change subject: Use %d instead of %i ...................................................................... Patch Set 1: (3 comments) File src/sgsn/slhc.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18860): https://gerrit.osmocom.org/c/osmo-sgsn/+/38281/comment/8a69d84b_9be2702e?us… : PS1, Line 542: DEBUGP(DSLHC, "slhc_compress(): Original header len (hlen) = %d\n",hlen); space required after that ',' (ctx:VxV) File tests/sndcp_xid/sndcp_xid_test.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18860): https://gerrit.osmocom.org/c/osmo-sgsn/+/38281/comment/3a7896f4_5d4a19ca?us… : PS1, Line 58: printf("Result length=%d\n",rc); space required after that ',' (ctx:VxV) File tests/xid/xid_test.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18860): https://gerrit.osmocom.org/c/osmo-sgsn/+/38281/comment/6b12e05a_493fa3b3?us… : PS1, Line 115: printf("Result length=%d\n",rc); space required after that ',' (ctx:VxV) -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/38281?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Icd5f5f9b0d2ed8fd82afa406787acb4bd95358bf Gerrit-Change-Number: 38281 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 23 Sep 2024 21:04:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

9 months

1
0
0 0

[L] Change in osmo-sgsn[master]: Add Routing Areas

by Jenkins Builder

Attention is currently required from: daniel, pespin. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37864?usp=email ) Change subject: Add Routing Areas ...................................................................... Patch Set 13: (1 comment) File tests/gprs_routing_area/gprs_routing_area_test.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18859): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/c000062e_f2215941?us… : PS13, Line 375: .name = "testSGSN", please, no space before tabs -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37864?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I2474b19a7471a1dea3c863ddf8372b16180211aa Gerrit-Change-Number: 37864 Gerrit-PatchSet: 13 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Sep 2024 21:04:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

9 months

1
0
0 0

[S] Change in osmo-sgsn[master]: Use %d instead of %i

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/38281?usp=email ) Change subject: Use %d instead of %i ...................................................................... Use %d instead of %i %d and %i has the same meaning when used in format string for printf. The linter will warn when using %i. %i was only added to provide symmetry between scanf() and printf(). Change-Id: Icd5f5f9b0d2ed8fd82afa406787acb4bd95358bf --- M src/sgsn/gprs_ranap.c M src/sgsn/slhc.c M tests/slhc/slhc_test.c M tests/sndcp_xid/sndcp_xid_test.c M tests/v42bis/v42bis_test.c M tests/xid/xid_test.c 6 files changed, 15 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/81/38281/1 diff --git a/src/sgsn/gprs_ranap.c b/src/sgsn/gprs_ranap.c index 51954ce..76e375f 100644 --- a/src/sgsn/gprs_ranap.c +++ b/src/sgsn/gprs_ranap.c @@ -168,7 +168,7 @@ rc = 0; break; default: - LOGMMCTXP(LOGL_NOTICE, mm, "Unknown event received: %i\n", type); + LOGMMCTXP(LOGL_NOTICE, mm, "Unknown event received: %d\n", type); rc = -1; break; } diff --git a/src/sgsn/slhc.c b/src/sgsn/slhc.c index 20e571d..ab13167 100644 --- a/src/sgsn/slhc.c +++ b/src/sgsn/slhc.c @@ -388,7 +388,7 @@ DEBUGP(DSLHC, "slhc_compress(): Unexpected change: th->doff != cs->cs_tcp.doff\n"); if(ip->ihl > 5 && memcmp(ip+1,cs->cs_ipopt,((ip->ihl)-5)*4) != 0) { DEBUGP(DSLHC, "slhc_compress(): Unexpected change: (ip->ihl > 5 && memcmp(ip+1,cs->cs_ipopt,((ip->ihl)-5)*4) != 0)\n"); - DEBUGP(DSLHC, "slhc_compress(): ip->ihl = %i\n", ip->ihl); + DEBUGP(DSLHC, "slhc_compress(): ip->ihl = %d\n", ip->ihl); DEBUGP(DSLHC, "slhc_compress(): ip+1 = %s\n", osmo_hexdump_nospc((uint8_t*)(ip+1),((ip->ihl)-5)*4)); DEBUGP(DSLHC, "slhc_compress(): Unexpected change: cs->cs_ipopt = %s\n", @@ -396,7 +396,7 @@ } if(th->doff > 5 && memcmp(th+1,cs->cs_tcpopt,((th->doff)-5)*4) != 0) { DEBUGP(DSLHC, "slhc_compress(): Unexpected change: (th->doff > 5 && memcmp(th+1,cs->cs_tcpopt,((th->doff)-5)*4) != 0)\n"); - DEBUGP(DSLHC, "slhc_compress(): th->doff = %i\n", th->doff); + DEBUGP(DSLHC, "slhc_compress(): th->doff = %d\n", th->doff); DEBUGP(DSLHC, "slhc_compress(): th+1 = %s\n", osmo_hexdump_nospc((uint8_t*)(th+1),((th->doff)-5)*4)); DEBUGP(DSLHC, "slhc_compress(): cs->cs_tcpopt = %s\n", @@ -539,7 +539,7 @@ /* deltaS is now the size of the change section of the compressed header */ DEBUGP(DSLHC, "slhc_compress(): Delta-list length (deltaS) = %li\n",deltaS); - DEBUGP(DSLHC, "slhc_compress(): Original header len (hlen) = %i\n",hlen); + DEBUGP(DSLHC, "slhc_compress(): Original header len (hlen) = %d\n",hlen); memcpy(cp,new_seq,deltaS); /* Write list of deltas */ memcpy(cp+deltaS,icp+hlen,isize-hlen); diff --git a/tests/slhc/slhc_test.c b/tests/slhc/slhc_test.c index 5c13313..9013623 100644 --- a/tests/slhc/slhc_test.c +++ b/tests/slhc/slhc_test.c @@ -209,12 +209,12 @@ packet_len = DISP_MAX_BYTES; if (packet_decompr_len > DISP_MAX_BYTES) packet_decompr_len = DISP_MAX_BYTES; - printf("Original Packet: (%i bytes) %s\n", packet_len, + printf("Original Packet: (%d bytes) %s\n", packet_len, osmo_hexdump_nospc(packet, packet_len)); - printf("DecompressedPacket: (%i bytes) %s\n", + printf("DecompressedPacket: (%d bytes) %s\n", packet_decompr_len, osmo_hexdump_nospc(packet_decompr, packet_decompr_len)); - printf("CompressedPacket: (%i bytes) %s\n", packet_compr_len, + printf("CompressedPacket: (%d bytes) %s\n", packet_compr_len, osmo_hexdump_nospc(packet_compr, packet_compr_len)); slhc_o_status(comp); slhc_o_status(comp); diff --git a/tests/sndcp_xid/sndcp_xid_test.c b/tests/sndcp_xid/sndcp_xid_test.c index 56b97e3..fca44fc 100644 --- a/tests/sndcp_xid/sndcp_xid_test.c +++ b/tests/sndcp_xid/sndcp_xid_test.c @@ -55,7 +55,7 @@ /* Encode comp-fields again */ rc = gprs_sndcp_compile_xid(xid_r,sizeof(xid_r), comp_fields, DEFAULT_SNDCP_VERSION); - printf("Result length=%i\n",rc); + printf("Result length=%d\n",rc); printf("Encoded: %s\n", osmo_hexdump_nospc(xid, sizeof(xid))); printf("Rencoded: %s\n", osmo_hexdump_nospc(xid_r, rc)); @@ -231,7 +231,7 @@ DEFAULT_SNDCP_VERSION); OSMO_ASSERT(rc > 0); - printf("Encoded: %s (%i bytes)\n", osmo_hexdump_nospc(xid, rc), rc); + printf("Encoded: %s (%d bytes)\n", osmo_hexdump_nospc(xid, rc), rc); /* Parse and show contained comp fields */ comp_fields_dec = gprs_sndcp_parse_xid(NULL, ctx, xid, rc, NULL); diff --git a/tests/v42bis/v42bis_test.c b/tests/v42bis/v42bis_test.c index e9c5069..7ada0e2 100644 --- a/tests/v42bis/v42bis_test.c +++ b/tests/v42bis/v42bis_test.c @@ -268,7 +268,7 @@ rc_sum += rc; /* Check results */ - printf("Mode: %i\n", mode); + printf("Mode: %d\n", mode); printf("uncompressed_original= %s ASCII:", osmo_hexdump_nospc(uncompressed_original, len)); @@ -314,7 +314,7 @@ int len; printf ("Testing compression/decompression with realistic TCP/IP packets:\n"); - printf("Packet No.: %i\n", packet_id); + printf("Packet No.: %d\n", packet_id); len = strlen(uncompr_packets[packet_id]); testvec = talloc_zero_size(ctx, len); len = osmo_hexparse(uncompr_packets[packet_id], testvec, len); @@ -339,7 +339,7 @@ printf ("Testing decompression with sniffed compressed TCP/IP packets:\n"); - printf("Packet No.: %i\n", packet_id); + printf("Packet No.: %d\n", packet_id); len = strlen(compr_packets[packet_id]); uncompressed = talloc_zero_size(ctx, len); diff --git a/tests/xid/xid_test.c b/tests/xid/xid_test.c index 89d82e9..5963d4f 100644 --- a/tests/xid/xid_test.c +++ b/tests/xid/xid_test.c @@ -73,8 +73,8 @@ /* Encode data */ rc = gprs_llc_compile_xid(xid, sizeof(xid), &xid_fields); OSMO_ASSERT(rc == 14); - printf("Encoded: %s (%i bytes)\n", osmo_hexdump_nospc(xid, rc), rc); - printf("Expected: %s (%i bytes)\n", + printf("Encoded: %s (%d bytes)\n", osmo_hexdump_nospc(xid, rc), rc); + printf("Expected: %s (%d bytes)\n", osmo_hexdump_nospc(xid_expected, sizeof(xid_expected)), (int)sizeof(xid_expected)); @@ -112,7 +112,7 @@ /* Encode xid-fields again */ rc = gprs_llc_compile_xid(xid_r, sizeof(xid_r), xid_fields); - printf("Result length=%i\n",rc); + printf("Result length=%d\n",rc); printf("Encoded: %s\n", osmo_hexdump_nospc(xid, sizeof(xid))); printf("Rencoded: %s\n", osmo_hexdump_nospc(xid_r, rc)); -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/38281?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Icd5f5f9b0d2ed8fd82afa406787acb4bd95358bf Gerrit-Change-Number: 38281 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

9 months

1
0
0 0

[M] Change in osmo-sgsn[master]: Implement correct Routing Area based paging

by lynxis lazus

Attention is currently required from: daniel, lynxis lazus, pespin. Hello Jenkins Builder, daniel, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37866?usp=email to look at the new patch set (#12). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Implement correct Routing Area based paging ...................................................................... Implement correct Routing Area based paging Previous the SGSN would not support multiple BSS within the same routing area. Add support paging of a whole routing area. Change-Id: I181da9f656e394ccfcb8999021a5b7e13ca0419f --- M include/osmocom/sgsn/gprs_bssgp.h M include/osmocom/sgsn/gprs_routing_area.h M src/sgsn/gprs_bssgp.c M src/sgsn/gprs_routing_area.c M src/sgsn/sgsn_libgtp.c M src/sgsn/sgsn_vty.c M tests/gprs_routing_area/gprs_routing_area_test.c M tests/gprs_routing_area/gprs_routing_area_test.ok 8 files changed, 133 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/66/37866/12 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37866?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I181da9f656e394ccfcb8999021a5b7e13ca0419f Gerrit-Change-Number: 37866 Gerrit-PatchSet: 12 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

9 months

1
0
0 0

[M] Change in osmo-sgsn[master]: move gsm48_gmm_att_tlvdef into gprs_gmm_util

by lynxis lazus

Attention is currently required from: daniel, lynxis lazus, pespin. Hello Jenkins Builder, daniel, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37868?usp=email to look at the new patch set (#13). The following approvals got outdated and were removed: Code-Review+1 by pespin, Code-Review+2 by daniel, Verified-1 by Jenkins Builder Change subject: move gsm48_gmm_att_tlvdef into gprs_gmm_util ...................................................................... move gsm48_gmm_att_tlvdef into gprs_gmm_util The gprs_gmm.c is huge. Move message parsing into gprS_gmm_util.c. Change-Id: I67dcdb986fd01dc093501d324b5c376246a5d30d --- M include/osmocom/sgsn/Makefile.am A include/osmocom/sgsn/gprs_gmm_util.h M src/sgsn/Makefile.am M src/sgsn/gprs_gmm.c A src/sgsn/gprs_gmm_util.c M tests/gprs_routing_area/Makefile.am M tests/sgsn/Makefile.am 7 files changed, 67 insertions(+), 23 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/68/37868/13 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37868?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I67dcdb986fd01dc093501d324b5c376246a5d30d Gerrit-Change-Number: 37868 Gerrit-PatchSet: 13 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

9 months

1
0
0 0

[L] Change in osmo-sgsn[master]: Add Routing Areas

by lynxis lazus

Attention is currently required from: daniel, pespin. Hello Jenkins Builder, daniel, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37864?usp=email to look at the new patch set (#13). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Add Routing Areas ...................................................................... Add Routing Areas Add a routing area layer which tracks routing area and cells within a routing area. Change-Id: I2474b19a7471a1dea3c863ddf8372b16180211aa --- M configure.ac M include/osmocom/sgsn/Makefile.am M include/osmocom/sgsn/debug.h A include/osmocom/sgsn/gprs_routing_area.h M include/osmocom/sgsn/sgsn.h M src/sgsn/Makefile.am M src/sgsn/gprs_bssgp.c M src/sgsn/gprs_ns.c A src/sgsn/gprs_routing_area.c M src/sgsn/sgsn.c M src/sgsn/sgsn_main.c M tests/Makefile.am A tests/gprs_routing_area/Makefile.am A tests/gprs_routing_area/gprs_routing_area_test.c A tests/gprs_routing_area/gprs_routing_area_test.ok M tests/sgsn/Makefile.am M tests/testsuite.at 17 files changed, 972 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/64/37864/13 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37864?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I2474b19a7471a1dea3c863ddf8372b16180211aa Gerrit-Change-Number: 37864 Gerrit-PatchSet: 13 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

9 months

1
0
0 0

[M] Change in osmo-sgsn[master]: GMM: split parsing of a RA Update Request in a separate file

by lynxis lazus

Attention is currently required from: daniel, lynxis lazus, pespin. Hello Jenkins Builder, daniel, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37869?usp=email to look at the new patch set (#14). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: GMM: split parsing of a RA Update Request in a separate file ...................................................................... GMM: split parsing of a RA Update Request in a separate file gprs_gmm.c is huge. Further split the general validation and parsing of the message into an own function. Change-Id: I413da1b6b4b7c0c4781393acd8564661bc74ce2d --- M include/osmocom/sgsn/gprs_gmm_util.h M src/sgsn/gprs_gmm.c M src/sgsn/gprs_gmm_util.c 3 files changed, 100 insertions(+), 44 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/69/37869/14 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37869?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I413da1b6b4b7c0c4781393acd8564661bc74ce2d Gerrit-Change-Number: 37869 Gerrit-PatchSet: 14 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

9 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: library/s1ap: add templates for INITIAL CONTEXT SETUP

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38275?usp=email ) Change subject: library/s1ap: add templates for INITIAL CONTEXT SETUP ...................................................................... library/s1ap: add templates for INITIAL CONTEXT SETUP Change-Id: I249e34ce91c874d4b6628d367672b58a77da041e --- M library/s1ap/S1AP_Templates.ttcn 1 file changed, 96 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/75/38275/1 diff --git a/library/s1ap/S1AP_Templates.ttcn b/library/s1ap/S1AP_Templates.ttcn index cd99ce2..e7fed9d 100644 --- a/library/s1ap/S1AP_Templates.ttcn +++ b/library/s1ap/S1AP_Templates.ttcn @@ -507,6 +507,80 @@ * 9.1.4 Context Management *********************************************************************************/ +template (value) UEAggregateMaximumBitrate +ts_UEAggregateMaximumBitrate(template (value) BitRate dl := 1073741824, + template (value) BitRate ul := 1073741824) := { + uEaggregateMaximumBitRateDL := dl, + uEaggregateMaximumBitRateUL := ul, + iE_Extensions := omit +} +template (present) UEAggregateMaximumBitrate +tr_UEAggregateMaximumBitrate(template (present) BitRate dl := ?, + template (present) BitRate ul := ?) := { + uEaggregateMaximumBitRateDL := dl, + uEaggregateMaximumBitRateUL := ul, + iE_Extensions := * +} + +template (value) UESecurityCapabilities +ts_UESecurityCapabilities(template (value) EncryptionAlgorithms eea := '1110000000000000'B, + template (value) IntegrityProtectionAlgorithms eia := '1110000000000000'B) := { + encryptionAlgorithms := eea, + integrityProtectionAlgorithms := eia, + iE_Extensions := omit +} +template (present) UESecurityCapabilities +tr_UESecurityCapabilities(template (present) EncryptionAlgorithms eea := ?, + template (present) IntegrityProtectionAlgorithms eia := ?) := { + encryptionAlgorithms := eea, + integrityProtectionAlgorithms := eia, + iE_Extensions := * +} + +template (value) E_RABToBeSetupItemCtxtSUReq +ts_E_RABToBeSetupItemCtxtSUReq(template (value) E_RAB_ID rab_id, + template (value) E_RABLevelQoSParameters qos_params, + template (value) TransportLayerAddress tla, + template (value) GTP_TEID gtp_teid, + template (omit) NAS_PDU nas_pdu) := { + e_RAB_ID := rab_id, + e_RABlevelQoSParameters := qos_params, + transportLayerAddress := tla, + gTP_TEID := gtp_teid, + nAS_PDU := nas_pdu, + iE_Extensions := omit +} +template (present) E_RABToBeSetupItemCtxtSUReq +tr_E_RABToBeSetupItemCtxtSUReq(template (present) E_RAB_ID rab_id := ?, + template (present) E_RABLevelQoSParameters qos_params := ?, + template (present) TransportLayerAddress tla := ?, + template (present) GTP_TEID gtp_teid := ?, + template NAS_PDU nas_pdu := *) := { + e_RAB_ID := rab_id, + e_RABlevelQoSParameters := qos_params, + transportLayerAddress := tla, + gTP_TEID := gtp_teid, + nAS_PDU := nas_pdu, + iE_Extensions := * +} + +template (value) E_RABToBeSetupListCtxtSUReq +ts_E_RABToBeSetupListCtxtSUReq(template (value) E_RABToBeSetupItemCtxtSUReq it) := { + { + id := S1AP_Constants.id_E_RABToBeSetupItemCtxtSUReq, + criticality := reject, + value_ := { E_RABToBeSetupItemCtxtSUReq := it } + } +} +template (present) E_RABToBeSetupListCtxtSUReq +tr_E_RABToBeSetupListCtxtSUReq(template (present) E_RABToBeSetupItemCtxtSUReq it) := { + { + id := S1AP_Constants.id_E_RABToBeSetupItemCtxtSUReq, + criticality := reject, + value_ := { E_RABToBeSetupItemCtxtSUReq := it } + } +} + /* 9.1.4.1 INITIAL CONTEXT SETUP REQ */ template (value) S1AP_PDU ts_S1AP_IntialCtxSetupReq(template (value) MME_UE_S1AP_ID mme_id, @@ -597,16 +671,34 @@ /* 9.1.4.3 INITIAL CONTEXT SETUP RESPONSE */ template (value) E_RABSetupItemCtxtSURes -ts_S1AP_RABSetupItemCtxtSURes(template (value) E_RAB_ID rab_id := 5, - template (value) TransportLayerAddress tla := '00001010000101110001100000000100'B, - template (value) GTP_TEID gtp_teid := '00000002'O) := { +ts_S1AP_RABSetupItemCtxtSURes(template (value) E_RAB_ID rab_id, + template (value) TransportLayerAddress tla, + template (value) GTP_TEID gtp_teid) := { e_RAB_ID := rab_id, transportLayerAddress := tla, gTP_TEID := gtp_teid, iE_Extensions := omit } +template (present) E_RABSetupItemCtxtSURes +tr_S1AP_RABSetupItemCtxtSURes(template (present) E_RAB_ID rab_id := ?, + template (present) TransportLayerAddress tla := ?, + template (present) GTP_TEID gtp_teid := ?) := { + e_RAB_ID := rab_id, + transportLayerAddress := tla, + gTP_TEID := gtp_teid, + iE_Extensions := * +} + template (value) E_RABSetupListCtxtSURes -ts_S1AP_RABSetupListCtxtSURes(template (value) E_RABSetupItemCtxtSURes it := ts_S1AP_RABSetupItemCtxtSURes()) := { +ts_S1AP_RABSetupListCtxtSURes(template (value) E_RABSetupItemCtxtSURes it) := { + { + id := S1AP_Constants.id_E_RABSetupItemCtxtSURes, + criticality := ignore, + value_ := { E_RABSetupItemCtxtSURes := it } + } +} +template (present) E_RABSetupListCtxtSURes +tr_S1AP_RABSetupListCtxtSURes(template (present) E_RABSetupItemCtxtSURes it := ?) := { { id := S1AP_Constants.id_E_RABSetupItemCtxtSURes, criticality := ignore, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38275?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I249e34ce91c874d4b6628d367672b58a77da041e Gerrit-Change-Number: 38275 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

9 months

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: library/s1ap: fix wrong IDs in {ts,tr}_S1AP_InitialCtxSetupResp

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38276?usp=email ) Change subject: library/s1ap: fix wrong IDs in {ts,tr}_S1AP_InitialCtxSetupResp ...................................................................... library/s1ap: fix wrong IDs in {ts,tr}_S1AP_InitialCtxSetupResp Change-Id: I752f202e891f7f6ff4f8f33b56de90c99c4ab456 Fixes: ce818da5b "library: Add S1AP Templates" --- M library/s1ap/S1AP_Templates.ttcn 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/76/38276/1 diff --git a/library/s1ap/S1AP_Templates.ttcn b/library/s1ap/S1AP_Templates.ttcn index e7fed9d..0079649 100644 --- a/library/s1ap/S1AP_Templates.ttcn +++ b/library/s1ap/S1AP_Templates.ttcn @@ -732,7 +732,7 @@ value_ := {E_RABSetupListCtxtSURes := rab_setup_items} } /*, { - id := S1AP_Constants.id_E_RABFailedToSetupListBearerSURes, + id := S1AP_Constants.id_E_RABFailedToSetupListCtxtSURes, criticality := ignore, value_ := {E_RABList := rab_items} }*/ @@ -761,11 +761,11 @@ criticality := reject, value_ := {ENB_UE_S1AP_ID := enb_id} }, { - id := S1AP_Constants.id_E_RABSetupListBearerSURes, + id := S1AP_Constants.id_E_RABSetupListCtxtSURes, criticality := ignore, value_ := {E_RABSetupListCtxtSURes := rab_setup_items} }, { - id := S1AP_Constants.id_E_RABFailedToSetupListBearerSURes, + id := S1AP_Constants.id_E_RABFailedToSetupListCtxtSURes, criticality := ignore, value_ := {E_RABList := rab_items} }, * -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38276?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I752f202e891f7f6ff4f8f33b56de90c99c4ab456 Gerrit-Change-Number: 38276 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2024