September 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: s1gw: fix TC_e_rab_setup: handle PFCP Session related PDUs

by fixeria

Attention is currently required from: fixeria, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38102?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: s1gw: fix TC_e_rab_setup: handle PFCP Session related PDUs ...................................................................... s1gw: fix TC_e_rab_setup: handle PFCP Session related PDUs S1GW_Tests.TC_e_rab_setup is failing since we introduced the PFCP support to osmo-s1gw. The IUT now requires co-located UPF, which we need to emulate in the testsuite. This patch patch adds the following API: * S1GW_ConnHdlr.f_ConnHdlr_rx_session_establish_req(), * S1GW_ConnHdlr.f_ConnHdlr_tx_session_establish_resp(), * S1GW_ConnHdlr.f_ConnHdlr_rx_session_modify_req(), * S1GW_ConnHdlr.f_ConnHdlr_tx_session_modify_resp(), and makes use of it in S1GW_Tests.TC_e_rab_setup. Change-Id: Ibbb326badaa1e3df968c137f3e4b576ca5c6f94d --- M s1gw/S1GW_ConnHdlr.ttcn M s1gw/S1GW_Tests.ttcn 2 files changed, 174 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/02/38102/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38102?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibbb326badaa1e3df968c137f3e4b576ca5c6f94d Gerrit-Change-Number: 38102 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: library/s1ap: add E-RAB RELEASE templates

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38144?usp=email ) Change subject: library/s1ap: add E-RAB RELEASE templates ...................................................................... library/s1ap: add E-RAB RELEASE templates Change-Id: I2e9305da80934ea68e3eca8215a9c16de48b37fd --- M library/s1ap/S1AP_Templates.ttcn 1 file changed, 236 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/44/38144/1 diff --git a/library/s1ap/S1AP_Templates.ttcn b/library/s1ap/S1AP_Templates.ttcn index 60dd063..4f0b5ee 100644 --- a/library/s1ap/S1AP_Templates.ttcn +++ b/library/s1ap/S1AP_Templates.ttcn @@ -1200,4 +1200,240 @@ } } +/* 9.1.3.5 E-RAB RELEASE COMMAND */ +template (value) S1AP_PDU +ts_S1AP_RABReleaseCmd(template (value) MME_UE_S1AP_ID mme_id, + template (value) ENB_UE_S1AP_ID enb_id, + template (value) E_RABList rab_items) := { + initiatingMessage := { + procedureCode := S1AP_Constants.id_E_RABRelease, + criticality := reject, + value_ := { + e_RABReleaseCommand := { + protocolIEs := { + { + id := S1AP_Constants.id_MME_UE_S1AP_ID, + criticality := reject, + value_ := { MME_UE_S1AP_ID := mme_id } + }, { + id := S1AP_Constants.id_eNB_UE_S1AP_ID, + criticality := reject, + value_ := { ENB_UE_S1AP_ID := enb_id } + }, { + id := S1AP_Constants.id_E_RABToBeReleasedList, + criticality := ignore, + value_ := { e_RABList := rab_items } + } + } + } + } + } +} +template (present) S1AP_PDU +tr_S1AP_RABReleaseCmd(template (present) MME_UE_S1AP_ID mme_id := ?, + template (present) ENB_UE_S1AP_ID enb_id := ?, + template (present) E_RABList rab_items := ?) := { + initiatingMessage := { + procedureCode := S1AP_Constants.id_E_RABRelease, + criticality := reject, + value_ := { + e_RABReleaseCommand := { + protocolIEs := { + { + id := S1AP_Constants.id_MME_UE_S1AP_ID, + criticality := reject, + value_ := { MME_UE_S1AP_ID := mme_id } + }, { + id := S1AP_Constants.id_eNB_UE_S1AP_ID, + criticality := reject, + value_ := { ENB_UE_S1AP_ID := enb_id } + }, { + id := S1AP_Constants.id_E_RABToBeReleasedList, + criticality := ignore, + value_ := { e_RABList := rab_items } + } + } + } + } + } +} + +/* 9.1.3.6 E-RAB RELEASE RESPONSE */ +template (value) S1AP_PDU +ts_S1AP_RABReleaseRsp(template (value) MME_UE_S1AP_ID mme_id, + template (value) ENB_UE_S1AP_ID enb_id, + template (value) E_RABReleaseListBearerRelComp rab_items) := { + successfulOutcome := { + procedureCode := S1AP_Constants.id_E_RABRelease, + criticality := reject, + value_ := { + e_RABReleaseResponse := { + protocolIEs := { + { + id := S1AP_Constants.id_MME_UE_S1AP_ID, + criticality := reject, + value_ := { MME_UE_S1AP_ID := mme_id } + }, { + id := S1AP_Constants.id_eNB_UE_S1AP_ID, + criticality := reject, + value_ := { ENB_UE_S1AP_ID := enb_id } + }, { + id := S1AP_Constants.id_E_RABReleaseListBearerRelComp, + criticality := ignore, + value_ := { e_RABReleaseListBearerRelComp := rab_items } + } + } + } + } + } +} +template (present) S1AP_PDU +tr_S1AP_RABReleaseRsp(template (present) MME_UE_S1AP_ID mme_id := ?, + template (present) ENB_UE_S1AP_ID enb_id := ?, + template (present) E_RABReleaseListBearerRelComp rab_items := ?) := { + successfulOutcome := { + procedureCode := S1AP_Constants.id_E_RABRelease, + criticality := reject, + value_ := { + e_RABReleaseResponse := { + protocolIEs := { + { + id := S1AP_Constants.id_MME_UE_S1AP_ID, + criticality := reject, + value_ := { MME_UE_S1AP_ID := mme_id } + }, { + id := S1AP_Constants.id_eNB_UE_S1AP_ID, + criticality := reject, + value_ := { ENB_UE_S1AP_ID := enb_id } + }, { + id := S1AP_Constants.id_E_RABReleaseListBearerRelComp, + criticality := ignore, + value_ := { e_RABReleaseListBearerRelComp := rab_items } + } + } + } + } + } +} + +/* 9.1.3.7 E-RAB RELEASE INDICATION */ +template (value) S1AP_PDU +ts_S1AP_RABReleaseInd(template (value) MME_UE_S1AP_ID mme_id, + template (value) ENB_UE_S1AP_ID enb_id, + template (value) E_RABList rab_items) := { + initiatingMessage := { + procedureCode := S1AP_Constants.id_E_RABReleaseIndication, + criticality := reject, + value_ := { + e_RABReleaseCommand := { + protocolIEs := { + { + id := S1AP_Constants.id_MME_UE_S1AP_ID, + criticality := reject, + value_ := { MME_UE_S1AP_ID := mme_id } + }, { + id := S1AP_Constants.id_eNB_UE_S1AP_ID, + criticality := reject, + value_ := { ENB_UE_S1AP_ID := enb_id } + }, { + id := S1AP_Constants.id_E_RABReleasedList, + criticality := ignore, + value_ := { E_RABList := rab_items } + } + } + } + } + } +} +template (present) S1AP_PDU +tr_S1AP_RABReleaseInd(template (present) MME_UE_S1AP_ID mme_id := ?, + template (present) ENB_UE_S1AP_ID enb_id := ?, + template (present) E_RABList rab_items := ?) := { + initiatingMessage := { + procedureCode := S1AP_Constants.id_E_RABReleaseIndication, + criticality := reject, + value_ := { + e_RABReleaseCommand := { + protocolIEs := { + { + id := S1AP_Constants.id_MME_UE_S1AP_ID, + criticality := reject, + value_ := { MME_UE_S1AP_ID := mme_id } + }, { + id := S1AP_Constants.id_eNB_UE_S1AP_ID, + criticality := reject, + value_ := { ENB_UE_S1AP_ID := enb_id } + }, { + id := S1AP_Constants.id_E_RABReleasedList, + criticality := ignore, + value_ := { E_RABList := rab_items } + } + } + } + } + } +} + +/* 9.2.1.36 E-RAB List */ +template (value) E_RABList +ts_E_RABList(template (value) E_RABItem it) := { + { + id := S1AP_Constants.id_E_RABItem, + criticality := ignore, + value_ := { E_RABItem := it } + } +} +template (present) E_RABList +tr_E_RABList(template (present) E_RABItem it := ?) := { + { + id := S1AP_Constants.id_E_RABItem, + criticality := ignore, + value_ := { E_RABItem := it } + } +} + +template (value) E_RABItem +ts_E_RABItem(template (value) E_RAB_ID rab_id, + template (value) Cause cause := {nas := normal_release}) := { + e_RAB_ID := rab_id, + cause := cause, + iE_Extensions := omit +} +template (present) E_RABItem +tr_E_RABItem(template (present) E_RAB_ID rab_id := ?, + template (present) Cause cause := ?) := { + e_RAB_ID := rab_id, + cause := cause, + iE_Extensions := * +} + +/* E-RAB Release List */ +template (value) E_RABReleaseListBearerRelComp +ts_E_RABReleaseListBearerRelComp(template (value) E_RABReleaseItemBearerRelComp it) := { + { + id := S1AP_Constants.id_E_RABReleaseListBearerRelComp, + criticality := ignore, + value_ := { E_RABReleaseItemBearerRelComp := it } + } +} +template (present) E_RABReleaseListBearerRelComp +tr_E_RABReleaseListBearerRelComp(template (present) E_RABReleaseItemBearerRelComp it := ?) := { + { + id := S1AP_Constants.id_E_RABReleaseListBearerRelComp, + criticality := ignore, + value_ := { E_RABReleaseItemBearerRelComp := it } + } +} + +template (value) E_RABReleaseItemBearerRelComp +ts_E_RABReleaseItemBearerRelComp(template (value) E_RAB_ID rab_id) := { + e_RAB_ID := rab_id, + iE_Extensions := omit +} +template (present) E_RABReleaseItemBearerRelComp +tr_E_RABReleaseItemBearerRelComp(template (present) E_RAB_ID rab_id := ?) := { + e_RAB_ID := rab_id, + iE_Extensions := * +} + } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38144?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2e9305da80934ea68e3eca8215a9c16de48b37fd Gerrit-Change-Number: 38144 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: s1gw: TC_e_rab_setup: also test E-RAB release

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38145?usp=email ) Change subject: s1gw: TC_e_rab_setup: also test E-RAB release ...................................................................... s1gw: TC_e_rab_setup: also test E-RAB release * s1ap: add E-RAB RELEASE API * pfcp: add PFCP Session Deletion API * s1gw: make use of this API in TC_e_rab_setup Change-Id: Id995c51d8ac76316f41ef49d35380a2521d5ae19 --- M s1gw/S1GW_ConnHdlr.ttcn M s1gw/S1GW_Tests.ttcn 2 files changed, 69 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/45/38145/1 diff --git a/s1gw/S1GW_ConnHdlr.ttcn b/s1gw/S1GW_ConnHdlr.ttcn index cd61123..5b2e7bb 100644 --- a/s1gw/S1GW_ConnHdlr.ttcn +++ b/s1gw/S1GW_ConnHdlr.ttcn @@ -303,6 +303,7 @@ }; private const MME_UE_S1AP_ID c_MME_UE_ID := 4242; +private const S1AP_IEs.Cause c_REL_CMD_CAUSE := { nas := normal_release }; function f_ConnHdlr_tx_erab_setup_req(in ERabList erabs, MME_UE_S1AP_ID mme_ue_id := c_MME_UE_ID) @@ -399,6 +400,42 @@ return pdu; } +function f_ConnHdlr_tx_erab_release_cmd(in ERabList erabs, + S1AP_IEs.Cause cause := c_REL_CMD_CAUSE, + MME_UE_S1AP_ID mme_ue_id := c_MME_UE_ID) +runs on ConnHdlr { + var ENB_UE_S1AP_ID enb_ue_id := g_pars.idx; + var template (value) E_RABList items; + + for (var integer i := 0; i < lengthof(erabs); i := i + 1) { + var template (value) E_RABItem item; + + item := ts_E_RABItem(erabs[i].erab_id, cause); + items[i] := ts_E_RABList(item)[0]; + } + + f_ConnHdlr_tx_s1ap_from_mme(ts_S1AP_RABReleaseCmd(mme_ue_id, enb_ue_id, items)); +} + +function f_ConnHdlr_rx_erab_release_cmd(in ERabList erabs, + S1AP_IEs.Cause cause := c_REL_CMD_CAUSE, + MME_UE_S1AP_ID mme_ue_id := c_MME_UE_ID) +runs on ConnHdlr return S1AP_PDU { + var ENB_UE_S1AP_ID enb_ue_id := g_pars.idx; + var template (present) E_RABList items; + var S1AP_PDU pdu; + + for (var integer i := 0; i < lengthof(erabs); i := i + 1) { + var template (present) E_RABItem item; + + item := ts_E_RABItem(erabs[i].erab_id, cause); + items[i] := tr_E_RABList(item)[0]; + } + + f_ConnHdlr_rx_s1ap_from_mme(pdu, tr_S1AP_RABReleaseCmd(mme_ue_id, enb_ue_id, items)); + return pdu; +} + function f_ConnHdlr_rx_session_establish_req(in ERab erab) runs on ConnHdlr return PDU_PFCP { var OCT4 addr := f_inet_addr(g_pars.pfcp_rem_addr); @@ -504,6 +541,24 @@ PFCP.send(resp); } +function f_ConnHdlr_rx_session_delete_req(in ERab erab) +runs on ConnHdlr return PDU_PFCP { + /* The final Session Deletion Request PDU */ + var template (present) PDU_PFCP tr_pdu; + tr_pdu := tr_PFCP_Session_Del_Req(erab.pfcp_loc_seid); + return f_ConnHdlr_pfcp_expect(tr_pdu); +} + +function f_ConnHdlr_tx_session_delete_resp(in ERab erab, + in PDU_PFCP req) +runs on ConnHdlr { + /* The final Session Deletion Response PDU */ + var template (value) PDU_PFCP resp; + resp := ts_PFCP_Session_Del_Resp(seq_nr := req.sequence_number, + seid := erab.pfcp_rem_seid); + PFCP.send(resp); +} + function f_ConnHdlr_erab_setup_req(inout ERabList erabs) runs on ConnHdlr { log("eNB <- [S1GW <- MME]: E-RAB SETUP REQUEST"); @@ -534,4 +589,17 @@ f_ConnHdlr_rx_erab_setup_rsp(erabs); } +function f_ConnHdlr_erab_release_cmd(inout ERabList erabs, + S1AP_IEs.Cause cause := c_REL_CMD_CAUSE) +runs on ConnHdlr { + f_ConnHdlr_tx_erab_release_cmd(erabs, cause); + for (var integer i := 0; i < lengthof(erabs); i := i + 1) { + log("UPF <- S1GW: PFCP Session Deletion Request for E-RAB ID ", erabs[i].erab_id); + var PDU_PFCP pdu := f_ConnHdlr_rx_session_delete_req(erabs[i]); + log("UPF -> S1GW: PFCP Session Deletion Response for E-RAB ID ", erabs[i].erab_id); + f_ConnHdlr_tx_session_delete_resp(erabs[i], pdu); + } + f_ConnHdlr_rx_erab_release_cmd(erabs, cause); +} + } diff --git a/s1gw/S1GW_Tests.ttcn b/s1gw/S1GW_Tests.ttcn index fb4ee9b..2e513da 100644 --- a/s1gw/S1GW_Tests.ttcn +++ b/s1gw/S1GW_Tests.ttcn @@ -285,6 +285,7 @@ f_ConnHdlr_erab_setup_req(g_pars.erabs); f_ConnHdlr_erab_setup_rsp(g_pars.erabs); + f_ConnHdlr_erab_release_cmd(g_pars.erabs); f_ConnHdlr_s1ap_disconnect(); f_ConnHdlr_s1ap_unregister(g_pars.genb_id); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38145?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id995c51d8ac76316f41ef49d35380a2521d5ae19 Gerrit-Change-Number: 38145 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: library/s1ap: fix formatting in ts_S1AP_RABSetupItemCtxtSURes

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38143?usp=email ) Change subject: library/s1ap: fix formatting in ts_S1AP_RABSetupItemCtxtSURes ...................................................................... library/s1ap: fix formatting in ts_S1AP_RABSetupItemCtxtSURes Change-Id: Ie6a367841a927ee0b542ccff2d6eb4ab9e51ca12 --- M library/s1ap/S1AP_Templates.ttcn 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/43/38143/1 diff --git a/library/s1ap/S1AP_Templates.ttcn b/library/s1ap/S1AP_Templates.ttcn index dbea258..60dd063 100644 --- a/library/s1ap/S1AP_Templates.ttcn +++ b/library/s1ap/S1AP_Templates.ttcn @@ -600,10 +600,10 @@ ts_S1AP_RABSetupItemCtxtSURes(template (value) E_RAB_ID rab_id := 5, template (value) TransportLayerAddress tla := '00001010000101110001100000000100'B, template (value) GTP_TEID gtp_teid := '00000002'O) := { - e_RAB_ID := rab_id, - transportLayerAddress := tla, - gTP_TEID := gtp_teid, - iE_Extensions := omit + e_RAB_ID := rab_id, + transportLayerAddress := tla, + gTP_TEID := gtp_teid, + iE_Extensions := omit } template (value) E_RABSetupListCtxtSURes ts_S1AP_RABSetupListCtxtSURes(template (value) E_RABSetupItemCtxtSURes it := ts_S1AP_RABSetupItemCtxtSURes()) := { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38143?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie6a367841a927ee0b542ccff2d6eb4ab9e51ca12 Gerrit-Change-Number: 38143 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: pfcp_peer: fix handling of IPv6 addr in get_f_seid()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38142?usp=email ) Change subject: pfcp_peer: fix handling of IPv6 addr in get_f_seid() ...................................................................... pfcp_peer: fix handling of IPv6 addr in get_f_seid() An IPv6 addr is 16 bytes long, not 6! Change-Id: Ie0529e8f67b5dc477fb8e04207dbef4d19ec9b75 --- M src/pfcp_peer.erl 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/42/38142/1 diff --git a/src/pfcp_peer.erl b/src/pfcp_peer.erl index c97304b..f379e69 100644 --- a/src/pfcp_peer.erl +++ b/src/pfcp_peer.erl @@ -377,9 +377,9 @@ ipv4 = undefined, ipv6 = undefined}, NodeId = get_node_id(S), - case byte_size(NodeId) of - 4 -> IE#f_seid{ipv4 = NodeId}; - 6 -> IE#f_seid{ipv6 = NodeId}; + case NodeId of + << _:32 >> -> IE#f_seid{ipv4 = NodeId}; + << _:128 >> -> IE#f_seid{ipv6 = NodeId}; _ -> IE %% shall not happen end. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38142?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ie0529e8f67b5dc477fb8e04207dbef4d19ec9b75 Gerrit-Change-Number: 38142 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: s1ap_proxy: fix E-RAB FSM lookup for RELEASE related IEs

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38141?usp=email ) Change subject: s1ap_proxy: fix E-RAB FSM lookup for RELEASE related IEs ...................................................................... s1ap_proxy: fix E-RAB FSM lookup for RELEASE related IEs We use a tuple of {MmeUeId, EnbUeId, RABId} to register and lookup E-RAB FSMs in the registry. Using RABId alone is wrong (because it's not a globally unique ID) and will never yield anything. Because of this bug the E-RAB FSMs were never terminated properly. This was found thanks to the ttcn3-s1gw-test and remained unnoticed so far because in test_e_rab_release() we still have this TODO: %% TODO: make sure that the E-RAB FSM has been terminated We'll need to add some E-RAB introspection API to implement this. Change-Id: Ic737e7b0c08562ecfd641ce4e3c2f27c26f8560e Fixes: 935a0f02 "{sctp,s1ap}_proxy: employ E-RAB FSMs" --- M src/s1ap_proxy.erl 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/41/38141/1 diff --git a/src/s1ap_proxy.erl b/src/s1ap_proxy.erl index f28ff56..1df1518 100644 --- a/src/s1ap_proxy.erl +++ b/src/s1ap_proxy.erl @@ -269,7 +269,7 @@ value = Content}, S) -> %% poke E-RAB FSM #'E-RABItem'{'e-RAB-ID' = ERABId} = Content, - case dict:find(ERABId, S#proxy_state.erabs) of + case erab_fsm_find(ERABId, S) of {ok, Pid} -> ok = erab_fsm:erab_release_req(Pid); error -> @@ -287,7 +287,7 @@ value = Content}, S) -> %% poke E-RAB FSM #'E-RABReleaseItemBearerRelComp'{'e-RAB-ID' = ERABId} = Content, - case dict:find(ERABId, S#proxy_state.erabs) of + case erab_fsm_find(ERABId, S) of {ok, Pid} -> ok = erab_fsm:erab_release_rsp(Pid); error -> -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38141?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ic737e7b0c08562ecfd641ce4e3c2f27c26f8560e Gerrit-Change-Number: 38141 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ci[master]: spelling.txt: remove teh||the

by falconia

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/38140?usp=email ) Change subject: spelling.txt: remove teh||the ...................................................................... spelling.txt: remove teh||the TEH is a valid acronym in Osmocom+Themyscira universe: it stands for TRAU-like Extension Header, as defined in this spec: https://www.freecalypso.org/specs/tw-ts-001-v010100.txt Various Osmocom components now include support for this family of Themyscira specs, but the linter outright rejects any and all patches that have a legitimate need to mention this acronym. Change-Id: I3d429d723e6cf926ecca9a83e36445575786c228 --- M lint/checkpatch/spelling.txt 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/40/38140/1 diff --git a/lint/checkpatch/spelling.txt b/lint/checkpatch/spelling.txt index f60a02f..6cfb584 100644 --- a/lint/checkpatch/spelling.txt +++ b/lint/checkpatch/spelling.txt @@ -1439,7 +1439,6 @@ targetted||targeted targetting||targeting taskelt||tasklet -teh||the temorary||temporary temproarily||temporarily temperture||temperature -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38140?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3d429d723e6cf926ecca9a83e36445575786c228 Gerrit-Change-Number: 38140 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org>

9 months, 2 weeks

1
0
0 0

[XL] Change in libosmo-abis[master]: tests: add unit tests for trau2rtp conversion, FR & EFR

by falconia

falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38139?usp=email ) Change subject: tests: add unit tests for trau2rtp conversion, FR & EFR ...................................................................... Patch Set 3: Verified+1 (1 comment) Patchset: PS3: The actual builds are passing, but the linter is failing on the TEH acronym (TRAU-like Extension Header as defined in TW-TS-001). How to remove Jenkins Builder from reviewers on this patch? -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38139?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ie319900125baa8f20595cac83343771d780a5b4e Gerrit-Change-Number: 38139 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Sat, 14 Sep 2024 08:02:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

[XL] Change in libosmo-abis[master]: tests: add unit tests for trau2rtp conversion, FR & EFR

by Jenkins Builder

Attention is currently required from: falconia. Jenkins Builder has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38139?usp=email ) Change subject: tests: add unit tests for trau2rtp conversion, FR & EFR ...................................................................... Patch Set 3: (6 comments) File tests/trau_conv/trau16_to_rtp.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18531): https://gerrit.osmocom.org/c/libosmo-abis/+/38139/comment/31eb183a_b1bb2c54… : PS3, Line 196: /* The only valid 1-byte payload is TEH by itself 'TEH' may be misspelled - perhaps 'THE'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18531): https://gerrit.osmocom.org/c/libosmo-abis/+/38139/comment/57458703_59a822ba… : PS3, Line 200: printf(" TW-TS-001 TEH octet: 0x%02X\n", rtp_pl[0]); 'TEH' may be misspelled - perhaps 'THE'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18531): https://gerrit.osmocom.org/c/libosmo-abis/+/38139/comment/7bd38afd_40a6e1d5… : PS3, Line 213: printf(" TW-TS-001 TEH octet: 0x%02X\n", rtp_pl[0]); 'TEH' may be misspelled - perhaps 'THE'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18531): https://gerrit.osmocom.org/c/libosmo-abis/+/38139/comment/5d4b9326_78fbb185… : PS3, Line 250: /* The only valid 1-byte payload is TEH by itself 'TEH' may be misspelled - perhaps 'THE'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18531): https://gerrit.osmocom.org/c/libosmo-abis/+/38139/comment/55ce8998_87e01bec… : PS3, Line 254: printf(" TW-TS-001 TEH octet: 0x%02X\n", rtp_pl[0]); 'TEH' may be misspelled - perhaps 'THE'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18531): https://gerrit.osmocom.org/c/libosmo-abis/+/38139/comment/a9790a0e_18f8e9e8… : PS3, Line 267: printf(" TW-TS-001 TEH octet: 0x%02X\n", rtp_pl[0]); 'TEH' may be misspelled - perhaps 'THE'? -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38139?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ie319900125baa8f20595cac83343771d780a5b4e Gerrit-Change-Number: 38139 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Sat, 14 Sep 2024 07:53:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

9 months, 2 weeks

1
0
0 0

[XL] Change in libosmo-abis[master]: tests: add unit tests for trau2rtp conversion, FR & EFR

by falconia

Attention is currently required from: falconia. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/38139?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: tests: add unit tests for trau2rtp conversion, FR & EFR ...................................................................... tests: add unit tests for trau2rtp conversion, FR & EFR The present set of tests exercises osmo_trau_frame_decode_16k() and osmo_trau2rtp() functions for frame types of FR speech and EFR speech. Both standard (RFC 3551) and TW-TS-001 output modes are tested. Change-Id: Ie319900125baa8f20595cac83343771d780a5b4e --- M .gitignore M tests/Makefile.am M tests/testsuite.at A tests/trau_conv/trau16_efr.in A tests/trau_conv/trau16_efr_std.ok A tests/trau_conv/trau16_efr_twts001.ok A tests/trau_conv/trau16_fr.in A tests/trau_conv/trau16_fr_std.ok A tests/trau_conv/trau16_fr_twts001.ok A tests/trau_conv/trau16_to_rtp.c 10 files changed, 1,128 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/39/38139/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38139?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ie319900125baa8f20595cac83343771d780a5b4e Gerrit-Change-Number: 38139 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: falconia <falcon(a)freecalypso.org>

9 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2024