September 2024 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ci[master]: jobs: ttcn3-s1gw-test-latest: disable

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/38151?usp=email ) Change subject: jobs: ttcn3-s1gw-test-latest: disable ...................................................................... jobs: ttcn3-s1gw-test-latest: disable It is too early in development to make sure that the tests work with the first "latest" version, so disable it until the next release. Change-Id: I88543792b26e7d24d0f0d18d86d39409335dbaa0 --- M jobs/ttcn3-testsuites-testenv.yml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/jobs/ttcn3-testsuites-testenv.yml b/jobs/ttcn3-testsuites-testenv.yml index d61c5f6..b5180f1 100644 --- a/jobs/ttcn3-testsuites-testenv.yml +++ b/jobs/ttcn3-testsuites-testenv.yml @@ -146,6 +146,7 @@ testsuite: s1gw args: -b osmocom:latest timer: H 10 * * * + disabled: true # disable until > 0.1.x release # --------------------------------------------- # Debian nightly + io_uring (OS#6357) -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38151?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I88543792b26e7d24d0f0d18d86d39409335dbaa0 Gerrit-Change-Number: 38151 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ci[master]: jobs: ttcn3-s1gw-test-latest: disable

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38151?usp=email ) Change subject: jobs: ttcn3-s1gw-test-latest: disable ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38151?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I88543792b26e7d24d0f0d18d86d39409335dbaa0 Gerrit-Change-Number: 38151 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Sep 2024 09:24:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ci[master]: jobs: ttcn3-s1gw-test-latest: disable

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/38151?usp=email ) Change subject: jobs: ttcn3-s1gw-test-latest: disable ...................................................................... jobs: ttcn3-s1gw-test-latest: disable It is too early in development to make sure that the tests work with the first "latest" version, so disable it until the next release. Change-Id: I88543792b26e7d24d0f0d18d86d39409335dbaa0 --- M jobs/ttcn3-testsuites-testenv.yml 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/51/38151/1 diff --git a/jobs/ttcn3-testsuites-testenv.yml b/jobs/ttcn3-testsuites-testenv.yml index d61c5f6..b5180f1 100644 --- a/jobs/ttcn3-testsuites-testenv.yml +++ b/jobs/ttcn3-testsuites-testenv.yml @@ -146,6 +146,7 @@ testsuite: s1gw args: -b osmocom:latest timer: H 10 * * * + disabled: true # disable until > 0.1.x release # --------------------------------------------- # Debian nightly + io_uring (OS#6357) -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38151?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I88543792b26e7d24d0f0d18d86d39409335dbaa0 Gerrit-Change-Number: 38151 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[S] Change in osmo-bsc[master]: Introduce hashtable to lookup bts by LAC

by pespin

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38087?usp=email ) Change subject: Introduce hashtable to lookup bts by LAC ...................................................................... Patch Set 4: (1 comment) File src/osmo-bsc/bts_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/38087/comment/897e29e8_ee2fd135?usp… : PS4, Line 281: default > I agree this behaviour is a bug. […] I'm not changing the existing behavior there, just clarifying it since I had to add extra logic near/around it. I can create a separate ticket so we can discuss the desired behavior, since you seem to have a clearer idea on how what you want there. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38087?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id523027b49e0f58cd2c8c9b4dee619de415dbd15 Gerrit-Change-Number: 38087 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Sep 2024 08:27:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[S] Change in pysim[master]: docs: remove traces of modules migrated to pyosmocom

by fixeria

Attention is currently required from: dexter, laforge. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/38149?usp=email ) Change subject: docs: remove traces of modules migrated to pyosmocom ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38149?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2ebb17f9781c90a81e9e554bddd7a851ef51c82a Gerrit-Change-Number: 38149 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Sep 2024 08:27:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

[XS] Change in osmocom-bb[master]: firmware: k2xx: fix comments about flash organization

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/38148?usp=email ) Change subject: firmware: k2xx: fix comments about flash organization ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/38148?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1b6a50cf7e10b5d71c6aa8d492721a7345ad892a Gerrit-Change-Number: 38148 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Sep 2024 08:26:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

[M] Change in osmocom-bb[master]: firmware: rename 'se_k2x0' -> 'se_k2xx' (include K205)

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/38147?usp=email ) Change subject: firmware: rename 'se_k2x0' -> 'se_k2xx' (include K205) ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/38147?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I05a4815c38f9cea7c2c7f2a33b836ebd0c016d0d Gerrit-Change-Number: 38147 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Sep 2024 08:26:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

[M] Change in pysim[master]: pySim-shell: Detect different eUICC types and print during start-up

by fixeria

Attention is currently required from: dexter, laforge. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/38049?usp=email ) Change subject: pySim-shell: Detect different eUICC types and print during start-up ...................................................................... Patch Set 6: (4 comments) File pySim/euicc.py: https://gerrit.osmocom.org/c/pysim/+/38049/comment/3c597a2e_3663e855?usp=em… : PS6, Line 580: -> bool: This function does not return a `bool`, but always `None` (implicit return) AFAICS. https://gerrit.osmocom.org/c/pysim/+/38049/comment/8f9cd7f0_b497fca6?usp=em… : PS6, Line 586: @staticmethod (just some ideas below, not blocking) Maybe use `@classmethod` instead, so that you can do: ``` @classmethod def match_with_card(cls, scc: SimCardCommands) -> bool: return match_helper(scc, cls._match_with_card) ``` Pros: no need to specify the class name and thus less risk of copy-paste errors. This method can then go to the parent class `CardProfileUICC` to avoid duplication. The `_match_with_card()` can then become an abstract static method. https://gerrit.osmocom.org/c/pysim/+/38049/comment/fff61958_19c6526e?usp=em… : PS6, Line 598: -> bool: likewise, change to `-> None`? https://gerrit.osmocom.org/c/pysim/+/38049/comment/01f92e4c_a4b824e1?usp=em… : PS6, Line 616: -> bool: likewise, change to `-> None`? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38049?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I54ea4ce663693f3951040dcc8a16bf532bf99c02 Gerrit-Change-Number: 38049 Gerrit-PatchSet: 6 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Sep 2024 08:14:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

9 months, 2 weeks

1
0
0 0

[S] Change in osmo-bsc[master]: Introduce hashtable to lookup bts by <LAC,CI>

by pespin

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38127?usp=email ) Change subject: Introduce hashtable to lookup bts by <LAC,CI> ...................................................................... Patch Set 2: (1 comment) File include/osmocom/bsc/gsm_data.h: https://gerrit.osmocom.org/c/osmo-bsc/+/38127/comment/a074c4d0_a1700a07?usp… : PS2, Line 993: #define LAC_CI_HASHTABLE_KEY(lac, ci) ((((uint32_t)(ci)) << sizeof(lac)) | (uint32_t)(lac)) > Acknowledged Ah ok, I did it this way on purpose to align it as if it was a function of the class, but I can modify it if you prefer it the other way. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38127?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I47db6c7543e5c6c3b8f0de3ae5ee1b53c2b5f16f Gerrit-Change-Number: 38127 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Sep 2024 08:04:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[S] Change in pysim[master]: docs: Bring osmo-smdpp documentation up to date with code

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/38150?usp=email ) Change subject: docs: Bring osmo-smdpp documentation up to date with code ...................................................................... docs: Bring osmo-smdpp documentation up to date with code Change-Id: Ibaab1fadd5d35ecdb356bed1820074b1b0a1752e Closes: OS#6418 --- M docs/osmo-smdpp.rst 1 file changed, 13 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/50/38150/1 diff --git a/docs/osmo-smdpp.rst b/docs/osmo-smdpp.rst index ad7d902..5111e2e 100644 --- a/docs/osmo-smdpp.rst +++ b/docs/osmo-smdpp.rst @@ -19,15 +19,20 @@ osmo-smdpp currently -* uses test certificates copied from GSMA SGP.26 into `./smdpp-data/certs`, assuming that your osmo-smdppp - would be running at the host name `testsmdpplus1.example.com` +* [by default] uses test certificates copied from GSMA SGP.26 into `./smdpp-data/certs`, assuming that your + osmo-smdppp would be running at the host name `testsmdpplus1.example.com`. You can of course replace those + certificates with your own, whether SGP.26 derived or part of a *private root CA* setup with mathcing eUICCs. * doesn't understand profile state. Any profile can always be downloaded any number of times, irrespective - of the EID or whether it was donwloaded before -* doesn't perform any personalization, so the IMSI/ICCID etc. are always identical + of the EID or whether it was donwloaded before. This is actually very useful for R&D and testing, as it + doesn't require you to generate new profiles all the time. This logic of course is unsuitable for + production usage. +* doesn't perform any personalization, so the IMSI/ICCID etc. are always identical (the ones that are store in + the respective UPP `.der` files) * **is absolutely insecure**, as it - * does not perform any certificate verification - * does not evaluate/consider any *Matching ID* or *Confirmation Code* + * does not perform all of the mandatory certificate verification (it checks the certificate chain, but not + the expiration dates nor any CRL) + * does not evaluate/consider any *Confirmation Code* * stores the sessions in an unencrypted _python shelve_ and is hence leaking one-time key materials used for profile encryption and signing. @@ -82,7 +87,8 @@ and it will bind its plain-HTTP ES9+ interface to local TCP port 8000. The `smdpp-data/certs`` directory contains the DPtls, DPauth and DPpb as well as CI certificates -used; they are copied from GSMA SGP.26 v2. +used; they are copied from GSMA SGP.26 v2. You can of course replace them with custom certificates +if you're operating eSIM with a *private root CA*. The `smdpp-data/upp` directory contains the UPP (Unprotected Profile Package) used. The file names (without .der suffix) are looked up by the matchingID parameter from the activation code presented by the LPA. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38150?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ibaab1fadd5d35ecdb356bed1820074b1b0a1752e Gerrit-Change-Number: 38150 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

9 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2024