August 2024 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-netif[rel-1.5.1]: ipa: Ensure osmo_ipa_segmentation_cb sets msg->l2h to the payload data

by daniel

Attention is currently required from: osmith. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/37673?usp=email ) Change subject: ipa: Ensure osmo_ipa_segmentation_cb sets msg->l2h to the payload data ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > * as there was only one patch added to master since the last release, we can directly make the relea […] Ok and thanks for handling it. Just a note that I didn't change the Change-Id and it also shows in "Cherry-Picks" in the top-right on this page (also with osmo-bsc). -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/37673?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: rel-1.5.1 Gerrit-Change-Id: Id91cddf9948ca49abf092850fae3a8f17e445b45 Gerrit-Change-Number: 37673 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Aug 2024 14:44:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

11 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_x2001_pacch_pkt_dl_ass_unanswered_timeout

by osmith

Attention is currently required from: fixeria, laforge, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37677?usp=email ) Change subject: pcu: Introduce test TC_x2001_pacch_pkt_dl_ass_unanswered_timeout ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37677?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I08921132de863404485581dfa439a54f109b0078 Gerrit-Change-Number: 37677 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Aug 2024 14:06:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months

1
0
0 0

[S] Change in pysim[master]: pySim-shell: Support other ADMx values beyond ADM1 from 'verify_adm'

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37685?usp=email ) Change subject: pySim-shell: Support other ADMx values beyond ADM1 from 'verify_adm' ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I really don't understand why we get this `pySim-shell.py:842:26: E1136: Value 'pin_names.inverse' is unsubscriptable (unsubscriptable-object)` pylint error. The inverse[] approach is the one documented by the bidict user manual. Also, we're using it successfully in pySim.cat, pySim.sms and pySim.ts_102_221 without any problems... -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37685?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icce6903c1e449889f8bc5003ccfe6af767a26d44 Gerrit-Change-Number: 37685 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Aug 2024 13:21:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

11 months

1
0
0 0

[S] Change in pysim[master]: pySim-shell: Support hexadecimal ADM pin in 'verify_adm'

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37684?usp=email ) Change subject: pySim-shell: Support hexadecimal ADM pin in 'verify_adm' ...................................................................... Patch Set 1: (1 comment) File pySim-shell.py: https://gerrit.osmocom.org/c/pysim/+/37684/comment/71c16a30_c5bd099e PS1, Line 829: '--pin-is-hex' > maybe add short `-H` for convenience? cmd2 has tab completion... I'd rather keep expressive names. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37684?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4191ed79ebe7869d8411d280a32ac2d4bbc210e3 Gerrit-Change-Number: 37684 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Aug 2024 13:19:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

11 months

1
0
0 0

[S] Change in pysim[master]: pySim-shell: Support other ADMx values beyond ADM1 from 'verify_adm'

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37685?usp=email ) Change subject: pySim-shell: Support other ADMx values beyond ADM1 from 'verify_adm' ...................................................................... Patch Set 1: (2 comments) File pySim-shell.py: https://gerrit.osmocom.org/c/pysim/+/37685/comment/b9303aba_75aeda5b PS1, Line 832: '--adm-type', > add `default='ADM1'`? No, that would break the default ADM number being retrieved from the CardProfile. For sysmocom that's always ADM1, but for e.g. Fairwaves its 2 (or 3). https://gerrit.osmocom.org/c/pysim/+/37685/comment/565977c5_73e8e8bc PS1, Line 842: inverse > `reverse()`? https://bidict.readthedocs.io/en/main/basic-usage.html uses the inverse[] approach. I couldn't immediately find a reverse() method documentation? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37685?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icce6903c1e449889f8bc5003ccfe6af767a26d44 Gerrit-Change-Number: 37685 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Aug 2024 13:17:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

11 months

1
0
0 0

[S] Change in pysim[master]: pySim-shell: Support other ADMx values beyond ADM1 from 'verify_adm'

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37685?usp=email ) Change subject: pySim-shell: Support other ADMx values beyond ADM1 from 'verify_adm' ...................................................................... Patch Set 1: (2 comments) File pySim-shell.py: https://gerrit.osmocom.org/c/pysim/+/37685/comment/175157e5_a8c8262c PS1, Line 832: '--adm-type', add `default='ADM1'`? https://gerrit.osmocom.org/c/pysim/+/37685/comment/7773a76a_38327134 PS1, Line 842: inverse `reverse()`? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37685?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icce6903c1e449889f8bc5003ccfe6af767a26d44 Gerrit-Change-Number: 37685 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 01 Aug 2024 11:55:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

11 months

1
0
0 0

[S] Change in pysim[master]: pySim-shell: Support hexadecimal ADM pin in 'verify_adm'

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37684?usp=email ) Change subject: pySim-shell: Support hexadecimal ADM pin in 'verify_adm' ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File pySim-shell.py: https://gerrit.osmocom.org/c/pysim/+/37684/comment/6bfdbe5c_95925ffd PS1, Line 829: '--pin-is-hex' maybe add short `-H` for convenience? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37684?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4191ed79ebe7869d8411d280a32ac2d4bbc210e3 Gerrit-Change-Number: 37684 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 01 Aug 2024 11:52:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months

1
0
0 0

[M] Change in pysim[master]: Support EF.ICCID and EF.PL on classic TS 51.011 SIM

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37679?usp=email ) Change subject: Support EF.ICCID and EF.PL on classic TS 51.011 SIM ...................................................................... Patch Set 2: Verified+1 Code-Review+2 (1 comment) Patchset: PS2: https://osmocom.org/issues/6485#note-3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37679?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6eaa5b579f02c7d75f443ee2b2cc8ae0ba13f2fe Gerrit-Change-Number: 37679 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 01 Aug 2024 11:48:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months

1
0
0 0

[S] Change in meta-telephony[201705]: libosmo-netif: upgrade to 1.5.1

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/37686?usp=email ) Change subject: libosmo-netif: upgrade to 1.5.1 ...................................................................... libosmo-netif: upgrade to 1.5.1 Change-Id: I4de497767931488f28282759687dd0dc3a4b5d48 --- M recipes-osmocom/libosmo-netif/libosmo-netif_git.bb 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: osmith: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/recipes-osmocom/libosmo-netif/libosmo-netif_git.bb b/recipes-osmocom/libosmo-netif/libosmo-netif_git.bb index a8e2ea6..036745f 100644 --- a/recipes-osmocom/libosmo-netif/libosmo-netif_git.bb +++ b/recipes-osmocom/libosmo-netif/libosmo-netif_git.bb @@ -1,7 +1,7 @@ require ${PN}.inc S = "${WORKDIR}/git" -SRCREV = "1.5.0" +SRCREV = "1.5.1" SRC_URI = "git://gerrit.osmocom.org/libosmo-netif.git;protocol=https;tag=${SRCREV};nob…" -PV = "1.5.0+gitr${SRCPV}" +PV = "1.5.1+gitr${SRCPV}" PR = "${INC_PR}.0" -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/37686?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: I4de497767931488f28282759687dd0dc3a4b5d48 Gerrit-Change-Number: 37686 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

11 months

1
0
0 0

[S] Change in meta-telephony[201705]: osmo-bsc: upgrade to 1.12.1

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/37687?usp=email ) Change subject: osmo-bsc: upgrade to 1.12.1 ...................................................................... osmo-bsc: upgrade to 1.12.1 Change-Id: I62e0b97c7c6a4f951baba23e02859e53f4264464 --- M recipes-osmocom/osmo-bsc/osmo-bsc_git.bb 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve osmith: Verified diff --git a/recipes-osmocom/osmo-bsc/osmo-bsc_git.bb b/recipes-osmocom/osmo-bsc/osmo-bsc_git.bb index 7f3c022..dc712db 100644 --- a/recipes-osmocom/osmo-bsc/osmo-bsc_git.bb +++ b/recipes-osmocom/osmo-bsc/osmo-bsc_git.bb @@ -1,7 +1,7 @@ require ${PN}.inc S = "${WORKDIR}/git" -SRCREV = "1.12.0" +SRCREV = "1.12.1" SRC_URI = "git://gerrit.osmocom.org/osmo-bsc.git;protocol=https;tag=${SRCREV};nobranch…" -PV = "1.12.0+gitr${SRCPV}" +PV = "1.12.1+gitr${SRCPV}" PR = "${INC_PR}.0" -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/37687?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: I62e0b97c7c6a4f951baba23e02859e53f4264464 Gerrit-Change-Number: 37687 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

11 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2024