July 2024 - gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: saip-tool: Dump information about security domains from "info" command

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/37428?usp=email ) Change subject: saip-tool: Dump information about security domains from "info" command ...................................................................... saip-tool: Dump information about security domains from "info" command output looks like this: Number of security domains: 1 Security domain Instance AID: a000000151000000 KVN=0x01, KID=0x01, [SdKeyComp(type=aes, mac_len=8, data=00000000000000000000000000000000)] KVN=0x01, KID=0x02, [SdKeyComp(type=aes, mac_len=8, data=00000000000000000000000000000000)] KVN=0x01, KID=0x03, [SdKeyComp(type=aes, mac_len=8, data=00000000000000000000000000000000)] Change-Id: Ia25f5ca6d7e888f7032301dd2561d066a3870010 --- M contrib/saip-tool.py 1 file changed, 27 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/28/37428/1 diff --git a/contrib/saip-tool.py b/contrib/saip-tool.py index 6f2a2a4..4a9bec9 100755 --- a/contrib/saip-tool.py +++ b/contrib/saip-tool.py @@ -180,7 +180,16 @@ print("\tLoad Block Size: %s" % len(app_pe.decoded['loadBlock']['loadBlockObject'])) for inst in app_pe.decoded.get('instanceList', []): print("\tInstance AID: %s" % b2h(inst['instanceAID'])) - pass + + # security domains + print() + sds = pes.pe_by_type.get('securityDomain', []) + print("Number of security domains: %u" % len(sds)) + for sd in sds: + print("Security domain Instance AID: %s" % b2h(sd.decoded['instance']['instanceAID'])) + # FIXME: 'applicationSpecificParametersC9' parsing to figure out enabled SCP + for key in sd.keys: + print("\tKVN=0x%02x, KID=0x%02x, %s" % (key.key_version_number, key.key_identifier, key.key_components)) def do_extract_apps(pes:ProfileElementSequence, opts): apps = pes.pe_by_type.get('application', []) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37428?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia25f5ca6d7e888f7032301dd2561d066a3870010 Gerrit-Change-Number: 37428 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

11 months, 3 weeks

1
0
0 0

[S] Change in pysim[master]: saip-tool: Also dump RFM information in "info" command

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/37429?usp=email ) Change subject: saip-tool: Also dump RFM information in "info" command ...................................................................... saip-tool: Also dump RFM information in "info" command example output: Number of RFM instances: 2 RFM instanceAID: d276000005aa060200000000b00000 (-> TAR: b00000) MSL: 0x16 RFM instanceAID: d276000005aa060200000000b00001 (-> TAR: b00001) MSL: 0x16 ADF AID: a0000000871002ff33ffff8901010100 Change-Id: I534267c7420fc5bd96eaded6078e986161729073 --- M contrib/saip-tool.py 1 file changed, 30 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/29/37429/1 diff --git a/contrib/saip-tool.py b/contrib/saip-tool.py index 4a9bec9..d73cc90 100755 --- a/contrib/saip-tool.py +++ b/contrib/saip-tool.py @@ -191,6 +191,18 @@ for key in sd.keys: print("\tKVN=0x%02x, KID=0x%02x, %s" % (key.key_version_number, key.key_identifier, key.key_components)) + # RFM + print() + rfms = pes.pe_by_type.get('rfm', []) + print("Number of RFM instances: %u" % len(rfms)) + for rfm in rfms: + inst_aid = rfm.decoded['instanceAID'] + print("RFM instanceAID: %s (-> TAR: %s)" % (b2h(inst_aid), b2h(inst_aid[-3:]))) + print("\tMSL: 0x%02x" % rfm.decoded['minimumSecurityLevel'][0]) + adf = rfm.decoded.get('adfRFMAccess', None) + if adf: + print("\tADF AID: %s" % b2h(adf['adfAID'])) + def do_extract_apps(pes:ProfileElementSequence, opts): apps = pes.pe_by_type.get('application', []) for app_pe in apps: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37429?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I534267c7420fc5bd96eaded6078e986161729073 Gerrit-Change-Number: 37429 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

11 months, 3 weeks

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: Makefile: new file

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37340?usp=email ) Change subject: Makefile: new file ...................................................................... Makefile: new file Add a Makefile similar to the ones in osmo-epdg and osmo-s1gw. Change-Id: Ida7ce261bfaac845ecdbec43e0bdd7d1669e5486 --- A Makefile 1 file changed, 41 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/Makefile b/Makefile new file mode 100644 index 0000000..940e06f --- /dev/null +++ b/Makefile @@ -0,0 +1,30 @@ +CONFIG ?= examples/sys.config + +all: build + +build: + rebar3 compile + rebar3 escriptize + +run: build + ERL_FLAGS='-config $(CONFIG)' _build/default/bin/osmo-dia2gsup + +shell: build + rebar3 shell --config $(CONFIG) + +check: + rebar3 eunit + +analyze: + rebar3 dialyzer + +clean: +# Avoid running rebar3 clean if _build doesn't exist, since it would try +# to fetch deps from the Internet and that may not be avaialble when in +# OBS build. +ifneq ("$(wildcard _build/.*)", "") + rebar3 clean + rm -rf _build/ +else + rm -f src/diameter_*.erl +endif -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37340?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: Ida7ce261bfaac845ecdbec43e0bdd7d1669e5486 Gerrit-Change-Number: 37340 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

11 months, 3 weeks

1
0
0 0

[S] Change in docker-playground[master]: ttcn3-s1gw-test: update logging config in osmo-s1gw.config

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/37427?usp=email ) Change subject: ttcn3-s1gw-test: update logging config in osmo-s1gw.config ...................................................................... ttcn3-s1gw-test: update logging config in osmo-s1gw.config Bring logging configuration in sync with erlang/osmo-s1gw.git. Change-Id: I3853c40c94d3ee2bbd5d6f6b345bfd87cce134d0 Related: erlang/osmo-s1gw.git Ib88801b8d38976b98a02ed06e1638e0e9056bafb --- M ttcn3-s1gw-test/osmo-s1gw.config 1 file changed, 16 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/27/37427/1 diff --git a/ttcn3-s1gw-test/osmo-s1gw.config b/ttcn3-s1gw-test/osmo-s1gw.config index 13b5058..b621ef9 100644 --- a/ttcn3-s1gw-test/osmo-s1gw.config +++ b/ttcn3-s1gw-test/osmo-s1gw.config @@ -25,9 +25,10 @@ #{level => debug, formatter => {logger_formatter, #{template => [time, " ", - "[", level, "] ", - {pid, ["", pid, " "], ""}, - msg, + "[", level, "]", + {pid, [" ", pid, ""], ""}, + {prefix, [" ", prefix, " ::"], ""}, + " ", msg, {mfa, [" (", mfa, ":", line, ")"], ""}, "\n"]}}}}]}]}]. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37427?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I3853c40c94d3ee2bbd5d6f6b345bfd87cce134d0 Gerrit-Change-Number: 37427 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

11 months, 3 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: asterisk: Split test code into helper functions

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37425?usp=email ) Change subject: asterisk: Split test code into helper functions ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37425?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9c712f4cd688729bece225c0d19219dc53e14b3 Gerrit-Change-Number: 37425 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Jul 2024 16:08:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 3 weeks

1
0
0 0

[S] Change in osmo-iuh[master]: support RAB Assignment in cn_ranap_rx_*_msg_co()

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/37393?usp=email ) Change subject: support RAB Assignment in cn_ranap_rx_*_msg_co() ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-iuh/+/37393/comment/5e12c63c_18a273d4 PS2, Line 20: Procedure", but doesn't > My humble conclusion is to just accept all the variants that an implementation could sensibly choose […] The way how its specified in the ASN.1 syntax: ``` rAB-Assignment RANAP-ELEMENTARY-PROCEDURE ::= { INITIATING MESSAGE RAB-AssignmentRequest OUTCOME RAB-AssignmentResponse PROCEDURE CODE id-RAB-Assignment CRITICALITY reject } ``` The way how I read this that the RAB assignment procedure should never have a SUCCESSFUL OUTCOME or an UNUSUCCESSFUL OUTCOME, but always _only_ OUTCOME. RAB-assinment, sRVCCPreparation and ueRadioCapabilityMatch are the only three procedures in the RANAP-PDU-Descriptions that have this. I'm not saying any of this as an argument to change your code - I'm just stating it to clarify what the spec says. -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/37393?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Ifec566a98cb6141d27b9e5e33d5a78f8b1530658 Gerrit-Change-Number: 37393 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Jul 2024 16:07:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

11 months, 3 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: asterisk: Split test code into helper functions

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37425?usp=email ) Change subject: asterisk: Split test code into helper functions ...................................................................... asterisk: Split test code into helper functions This allows reusing code to create new tests coming up soon, like sending HOLD (re-INVITE sendonly) after having estavlished the call. Related: SYS#6782 Change-Id: Ic9c712f4cd688729bece225c0d19219dc53e14b3 --- M asterisk/Asterisk_Tests.ttcn 1 file changed, 40 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/25/37425/1 diff --git a/asterisk/Asterisk_Tests.ttcn b/asterisk/Asterisk_Tests.ttcn index ca1ec72..3f9db75 100644 --- a/asterisk/Asterisk_Tests.ttcn +++ b/asterisk/Asterisk_Tests.ttcn @@ -206,21 +206,24 @@ } /* Successful SIP MO-MT Call between local clients: */ -private function f_TC_internal_call_mo(charstring id) runs on SIPConnHdlr { - +private function f_TC_internal_register_establish_call_mo() runs on SIPConnHdlr { f_SIP_register(); COORD.send(COORD_CMD_REGISTERED); COORD.receive(COORD_CMD_START); f_SIP_mo_call_setup(); COORD.send(COORD_CMD_CALL_ESTABLISHED); - +} +private function f_TC_internal_hangup_call_mo_unregister() runs on SIPConnHdlr { COORD.receive(COORD_CMD_HANGUP); f_SIP_do_call_hangup(); COORD.receive(COORD_CMD_UNREGISTER); f_SIP_unregister(); - +} +private function f_TC_internal_call_mo(charstring id) runs on SIPConnHdlr { + f_TC_internal_register_establish_call_mo(); + f_TC_internal_hangup_call_mo_unregister(); setverdict(pass); } private function f_TC_internal_call_mt(charstring id) runs on SIPConnHdlr { @@ -714,8 +717,7 @@ IMS_COORD.receive(COORD_CMD_CALL_ESTABLISHED) from vc_conn_ims; } -/* Test IMS MO call emulating an MT which doesn't support precondition */ -private function f_TC_ims_call_mo_IMS_ConnHdlr(charstring id) runs on IMS_ConnHdlr { +private function f_TC_ims_call_mo_IMS_ConnHdlr_register_establish_call() runs on IMS_ConnHdlr { f_create_sip_expect(valueof(ts_SipUrl_from_Addr_Union(g_pars.subscr.registrar_sip_record.addr))); if (ispresent(g_pars.subscr.cp.called)) { f_create_sip_expect(valueof(ts_SipUrl_from_Addr_Union(g_pars.subscr.cp.called.addr))); @@ -725,6 +727,16 @@ as_IMS_mo_call_accept(); setverdict(pass); COORD.send(COORD_CMD_CALL_ESTABLISHED); +} + +private function f_TC_ims_call_mo_IMS_ConnHdlr_hangup_call_unregister() runs on IMS_ConnHdlr { + as_IMS_exp_call_hangup(g_pars.subscr.cp.sip_seq_nr + 1); + COORD.send(IMS_COORD_CMD_CALL_FINISHED); + setverdict(pass); + as_IMS_unregister(); +} +private function f_TC_ims_call_mo_IMS_ConnHdlr(charstring id) runs on IMS_ConnHdlr { + f_TC_ims_call_mo_IMS_ConnHdlr_register_establish_call(); if (g_pars.subscr.cp.mo.support_timer_session_expires > 0) { timer Trefresh; Trefresh.start(int2float(g_pars.subscr.cp.mo.support_timer_session_expires)); @@ -739,13 +751,12 @@ f_sleep(1.0); COORD.send(IMS_COORD_CMD_CALL_SESSION_REFRESH); } - as_IMS_exp_call_hangup(g_pars.subscr.cp.sip_seq_nr + 1); - COORD.send(IMS_COORD_CMD_CALL_FINISHED); - setverdict(pass); - as_IMS_unregister(); + f_TC_ims_call_mo_IMS_ConnHdlr_hangup_call_unregister(); } -private function f_TC_ims_call_mo(boolean use_precondition_ext, boolean use_session_timer) runs on test_CT { +private function f_TC_ims_call_mo(boolean use_precondition_ext := true, boolean use_session_timer := false, + void_fn sip_fn := refers(f_TC_internal_call_mo), + ims_void_fn ims_fn := refers(f_TC_ims_call_mo_IMS_ConnHdlr)) runs on test_CT { var SIPConnHdlrPars sip_pars; var IMS_ConnHdlrPars ims_pars; var SIPConnHdlr vc_conn_sip; @@ -769,8 +780,8 @@ } - vc_conn_ims := f_start_handler_IMS(refers(f_TC_ims_call_mo_IMS_ConnHdlr), ims_pars); - vc_conn_sip := f_start_handler(refers(f_TC_internal_call_mo), sip_pars); + vc_conn_ims := f_start_handler_IMS(ims_fn, ims_pars); + vc_conn_sip := f_start_handler(sip_fn, sip_pars); COORD.receive(COORD_CMD_REGISTERED) from vc_conn_sip; @@ -804,13 +815,13 @@ f_shutdown(); } testcase TC_ims_call_mo() runs on test_CT { - f_TC_ims_call_mo(true, false); + f_TC_ims_call_mo(); } testcase TC_ims_call_mo_session_timer() runs on test_CT { - f_TC_ims_call_mo(true, true); + f_TC_ims_call_mo(use_session_timer := true); } testcase TC_ims_call_mo_noprecondition() runs on test_CT { - f_TC_ims_call_mo(false, false); + f_TC_ims_call_mo(use_precondition_ext := false); } /* Test SIP registration of local clients */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37425?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9c712f4cd688729bece225c0d19219dc53e14b3 Gerrit-Change-Number: 37425 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

11 months, 3 weeks

1
0
0 0

[S] Change in osmo-iuh[master]: support RAB Assignment in cn_ranap_rx_*_msg_co()

by daniel

Attention is currently required from: laforge, neels. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/37393?usp=email ) Change subject: support RAB Assignment in cn_ranap_rx_*_msg_co() ...................................................................... Patch Set 2: Code-Review+1 (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-iuh/+/37393/comment/565bd5e1_dec1e8f0 PS2, Line 30: cn_ranap_rx_successful_msg_co(). Decoding is also present in cn_ranap_rx_outcome_msg_co() Patchset: PS2: Maybe mention *_outcome_msg_co as well -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/37393?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Ifec566a98cb6141d27b9e5e33d5a78f8b1530658 Gerrit-Change-Number: 37393 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 08 Jul 2024 14:18:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 3 weeks

1
0
0 0

[S] Change in osmo-iuh[master]: ranap_cn_rx_co(): do not ranap_cn_rx_co_free() on error

by daniel

Attention is currently required from: neels. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/37414?usp=email ) Change subject: ranap_cn_rx_co(): do not ranap_cn_rx_co_free() on error ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/37414?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: If7545f91c69f06bc32c55cab7dcfcad8350b0473 Gerrit-Change-Number: 37414 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Jul 2024 14:13:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 3 weeks

1
0
0 0

[S] Change in osmo-iuh[master]: fix memleak: free after aper_decode() also on error

by daniel

Attention is currently required from: neels. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/37413?usp=email ) Change subject: fix memleak: free after aper_decode() also on error ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/37413?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I03ed2376e520ec6dbcc2bae22f9291e211c7cca9 Gerrit-Change-Number: 37413 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Jul 2024 14:03:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2024