June 2024 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-abis[master]: trau_rtp_conv: add support for HRv1 in 8k format

by laforge

Attention is currently required from: falconia, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37287?usp=email ) Change subject: trau_rtp_conv: add support for HRv1 in 8k format ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Patchset: PS3: it seems we only have unit tests for the Ericsson proprietary PCU Trau frames. It of course would be great to also have that for the standard formats. It's sad that the existing ones don't have coverage, and it would certainly be great but not required to add some for the new 8k format. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37287?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I8ee01b73360501ca380a8695cbc7070ceaaba1be Gerrit-Change-Number: 37287 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Jun 2024 13:34:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

12 months

1
0
0 0

[M] Change in libosmo-abis[master]: build config: add --disable-ortp option

by laforge

Attention is currently required from: falconia, neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/36975?usp=email ) Change subject: build config: add --disable-ortp option ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > FYI, we already have in osmocom: […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/36975?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I554260483b94d812ac3a957c969a902870f53883 Gerrit-Change-Number: 36975 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Jun 2024 13:31:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

12 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: mme: Verify GUTI -> RAI/PTMSI translation is correct

by laforge

Attention is currently required from: daniel, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37296?usp=email ) Change subject: mme: Verify GUTI -> RAI/PTMSI translation is correct ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37296?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id1afd55f84c91a765fa12a22979ef0351b6d6554 Gerrit-Change-Number: 37296 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Jun 2024 13:30:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

12 months

1
0
0 0

[S] Change in osmo-trx[master]: contrib/systemd/osmo-trx-uhd: fix HOME=

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/37295?usp=email ) Change subject: contrib/systemd/osmo-trx-uhd: fix HOME= ...................................................................... contrib/systemd/osmo-trx-uhd: fix HOME= With recent changes, osmo-trx-uhd does not run as root anymore. Change HOME=%h, which evaluates to HOME=/root, to HOME=%S/osmocom which evaluates to HOME=/var/lib/osmocom. This is the StateDirectory that is owned by the osmocom user. Fix for: osmo-trx-uhd[4013]: terminate called after throwing an instance of 'boost::filesystem::filesystem_error' osmo-trx-uhd[4013]: what(): boost::filesystem::status: Permission denied: "/root/.config/uhd.conf" osmo-trx-uhd[4013]: signal 6 received Fixes: OS#6495 Change-Id: Ic6f020dd800eedc5e56c7d71e65521ec831d8c64 --- M contrib/systemd/osmo-trx-uhd.service 1 file changed, 21 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve Hoernchen: Looks good to me, approved diff --git a/contrib/systemd/osmo-trx-uhd.service b/contrib/systemd/osmo-trx-uhd.service index 64eb510..50440a7 100644 --- a/contrib/systemd/osmo-trx-uhd.service +++ b/contrib/systemd/osmo-trx-uhd.service @@ -8,7 +8,7 @@ Restart=always StateDirectory=osmocom WorkingDirectory=%S/osmocom -Environment=HOME=%h +Environment=HOME=%S/osmocom User=osmocom Group=osmocom ExecStart=/usr/bin/osmo-trx-uhd -C /etc/osmocom/osmo-trx-uhd.cfg -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/37295?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ic6f020dd800eedc5e56c7d71e65521ec831d8c64 Gerrit-Change-Number: 37295 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

12 months

1
0
0 0

[S] Change in osmo-trx[master]: contrib/systemd/osmo-trx-uhd: fix HOME=

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/37295?usp=email ) Change subject: contrib/systemd/osmo-trx-uhd: fix HOME= ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Should this be the state directory It has to be inside the state directory, as the osmocom user doesn't have write access anywhere else. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/37295?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ic6f020dd800eedc5e56c7d71e65521ec831d8c64 Gerrit-Change-Number: 37295 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Jun 2024 12:58:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de> Gerrit-MessageType: comment

12 months

1
0
0 0

[S] Change in osmo-trx[master]: contrib/systemd/osmo-trx-uhd: fix HOME=

by Hoernchen

Attention is currently required from: osmith. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/37295?usp=email ) Change subject: contrib/systemd/osmo-trx-uhd: fix HOME= ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Should this be the state directory -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/37295?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ic6f020dd800eedc5e56c7d71e65521ec831d8c64 Gerrit-Change-Number: 37295 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Jun 2024 12:57:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

12 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: mme: Verify GUTI -> RAI/PTMSI translation is correct

by daniel

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37296?usp=email ) Change subject: mme: Verify GUTI -> RAI/PTMSI translation is correct ...................................................................... mme: Verify GUTI -> RAI/PTMSI translation is correct Change-Id: Id1afd55f84c91a765fa12a22979ef0351b6d6554 --- M mme/MME_Tests.ttcn 1 file changed, 25 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/96/37296/1 diff --git a/mme/MME_Tests.ttcn b/mme/MME_Tests.ttcn index 3ea17dd..76c9c7e 100644 --- a/mme/MME_Tests.ttcn +++ b/mme/MME_Tests.ttcn @@ -962,10 +962,14 @@ } -private altstep as_gtp_sgsn_context_2g_to_4g(OCT4 new_sgsn_teid := 'ABABABAB'O, GTPv1C_Templates.GTP_RATType rat_type := GTP_RAT_TYPE_EUTRAN) runs on ConnHdlr { +private altstep as_gtp_sgsn_context_2g_to_4g(OCT4 new_sgsn_teid := 'ABABABAB'O, GTPv1C_Templates.GTP_RATType rat_type := GTP_RAT_TYPE_EUTRAN, + RoutingAreaIdentity rai, + OCT4 ptmsi, + OCT3 ptmsi_sig +) runs on ConnHdlr { var Gtp1cUnitdata gtpc_pdu; - [] GTP.receive(tr_GTPC_SGSNContextReq(g_gn_iface_peer, tr_SGSNContextReqPDU(rat_type := int2oct(enum2int(rat_type), 1)))) -> value gtpc_pdu { + [] GTP.receive(tr_GTPC_SGSNContextReq(g_gn_iface_peer, tr_SGSNContextReqPDU(rai := rai, ptmsi := ts_PTMSI(ptmsi), ptmsi_sig := ts_PTMSI_sig(ptmsi_sig), rat_type := int2oct(enum2int(rat_type), 1)))) -> value gtpc_pdu { var template (value) PDP_Context_GTPC pdp_ctx; var template (value) GTPC_PDUs SGSNContextRespPDU; var Gtp1cUnitdata gtpc_pdu_ack; @@ -1457,25 +1461,25 @@ vc_conn.done; } -/* 3GPP TS 23.401 D.3.6, TS 23.003 2.8.2.2 */ -private function rai_ptmsi2_guti(in RoutingAreaIdentity rai, in OCT4 ptmsi, in OCT3 ptmsi_sig, out NAS_EPS_Types.GUTI guti) runs on ConnHdlr { +/* 3GPP TS 23.401 D.3.6, TS 23.003 2.8.2.2.2 (Mapping in the UE) */ +private function rai_ptmsi2_guti(in RoutingAreaIdentity rai, in OCT4 ptmsi, out NAS_EPS_Types.GUTI guti) { var bitstring ptmsi_bits := oct2bit(ptmsi); - var bitstring ptmsi_sig_bits := oct2bit(ptmsi_sig); + var bitstring rac_bits := oct2bit(rai.rac); var bitstring mtmsi_bits := '11'B & substr(ptmsi_bits, 2, 6) & - substr(ptmsi_sig_bits, 0, 8) & + substr(rac_bits, 0, 8) & substr(ptmsi_bits, 16, 16); guti := valueof(ts_NAS_GUTI(mcc_mnc := rai.mcc_digits & rai.mnc_digits, mmegi := rai.lac, - mmec := rai.rac, + mmec := bit2oct(substr(ptmsi_bits, 8, 8)), tmsi := bit2oct(mtmsi_bits))); } /* Test UE attached to GERAN reselecting a EUTRAN cell. In this scenario, the * new MME will attempt to obtain information of the UE from the old SGSN * through Gn interface using SGSN Context Request/Response procedure (OS#6294). */ -/* 3GPP TS 23.401 D.3.6, TS 23.003 2.8.2.1 */ +/* 3GPP TS 23.401 D.3.6, TS 23.003 2.8.2.2.2 */ private function f_TC_ue_cell_reselect_geran_to_eutran(ConnHdlrPars pars) runs on ConnHdlr { f_init_handler(pars); f_gtp_register_imsi(g_pars.ue_pars.imsi); @@ -1496,10 +1500,12 @@ var template (value) EPS_MobileIdentityLV old_guti; var S1APEM_Config cfg; timer T := 5.0; + var bitstring ptmsi_bits := oct2bit(ptmsi); + var OCT4 ptmsi_exp := bit2oct('11'B & substr(ptmsi_bits, 2, 30)); rai := valueof(ts_RoutingAreaIdentity(mp_gn_local_mcc, mp_gn_local_mnc, int2oct(mp_gn_local_lac, 2), int2oct(mp_gn_local_rac, 1))); - rai_ptmsi2_guti(rai, ptmsi, ptmsi_sig, guti_val); + rai_ptmsi2_guti(rai, ptmsi, guti_val); old_guti := ts_EPS_MobileId_GUTI_(guti_val); nas_tau := ts_PDU_NAS_EPS_TrackingAreaUpdateRequest(old_guti, @@ -1520,7 +1526,7 @@ }; S1AP.send(cfg); - as_gtp_sgsn_context_2g_to_4g(new_sgsn_teid); + as_gtp_sgsn_context_2g_to_4g(new_sgsn_teid, GTP_RAT_TYPE_EUTRAN, rai, ptmsi_exp, ptmsi_sig); /* We now expect the MME to send a Create Session Request to the SGW-C */ T.start; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37296?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id1afd55f84c91a765fa12a22979ef0351b6d6554 Gerrit-Change-Number: 37296 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newchange

12 months

1
0
0 0

[M] Change in libosmo-abis[master]: build config: add --disable-ortp option

by fixeria

Attention is currently required from: falconia, laforge, neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/36975?usp=email ) Change subject: build config: add --disable-ortp option ...................................................................... Patch Set 2: (1 comment) File configure.ac: https://gerrit.osmocom.org/c/libosmo-abis/+/36975/comment/5cb57044_d94296ba PS2, Line 150: _cflags_save=$CFLAGS I believe these API quirks should not be executed if `ENABLE_ORTP = no`? -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/36975?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I554260483b94d812ac3a957c969a902870f53883 Gerrit-Change-Number: 36975 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 26 Jun 2024 10:25:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

12 months

1
0
0 0

[S] Change in osmo-trx[master]: contrib/systemd/osmo-trx-uhd: fix HOME=

by fixeria

Attention is currently required from: Hoernchen, osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/37295?usp=email ) Change subject: contrib/systemd/osmo-trx-uhd: fix HOME= ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/37295?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ic6f020dd800eedc5e56c7d71e65521ec831d8c64 Gerrit-Change-Number: 37295 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Jun 2024 10:18:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

12 months

1
0
0 0

[S] Change in osmo-trx[master]: contrib/systemd/osmo-trx-uhd: fix HOME=

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/37295?usp=email ) Change subject: contrib/systemd/osmo-trx-uhd: fix HOME= ...................................................................... contrib/systemd/osmo-trx-uhd: fix HOME= With recent changes, osmo-trx-uhd does not run as root anymore. Change HOME=%h, which evaluates to HOME=/root, to HOME=%S/osmocom which evaluates to HOME=/var/lib/osmocom. This is the StateDirectory that is owned by the osmocom user. Fix for: osmo-trx-uhd[4013]: terminate called after throwing an instance of 'boost::filesystem::filesystem_error' osmo-trx-uhd[4013]: what(): boost::filesystem::status: Permission denied: "/root/.config/uhd.conf" osmo-trx-uhd[4013]: signal 6 received Fixes: OS#6495 Change-Id: Ic6f020dd800eedc5e56c7d71e65521ec831d8c64 --- M contrib/systemd/osmo-trx-uhd.service 1 file changed, 21 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/95/37295/1 diff --git a/contrib/systemd/osmo-trx-uhd.service b/contrib/systemd/osmo-trx-uhd.service index 64eb510..50440a7 100644 --- a/contrib/systemd/osmo-trx-uhd.service +++ b/contrib/systemd/osmo-trx-uhd.service @@ -8,7 +8,7 @@ Restart=always StateDirectory=osmocom WorkingDirectory=%S/osmocom -Environment=HOME=%h +Environment=HOME=%S/osmocom User=osmocom Group=osmocom ExecStart=/usr/bin/osmo-trx-uhd -C /etc/osmocom/osmo-trx-uhd.cfg -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/37295?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ic6f020dd800eedc5e56c7d71e65521ec831d8c64 Gerrit-Change-Number: 37295 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

12 months

1
0
0 0

2025

2024

2023

2022

gerrit-log June 2024