June 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: asterisk: Test initial IMS REGISTER timeout

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37194?usp=email ) Change subject: asterisk: Test initial IMS REGISTER timeout ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37194?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If59d43b2779dfbd14890a88d664077c194f843a1 Gerrit-Change-Number: 37194 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Wed, 12 Jun 2024 12:44:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year

1
0
0 0

[S] Change in osmocom-bb[master]: mobile: cosmetic: fix -Wswitch in tch_voice_state_init()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/37212?usp=email ) Change subject: mobile: cosmetic: fix -Wswitch in tch_voice_state_init() ...................................................................... Patch Set 1: (1 comment) File src/host/layer23/src/mobile/tch_voice.c: https://gerrit.osmocom.org/c/osmocom-bb/+/37212/comment/60bf1749_980b7758 PS1, Line 135: #endif > It's fine because we cannot end up having `state->handler == TCH_VOICE_IOH_GAPK` if built without `W […] as you see, but I'm sure the same question I had will probably be triggered by other readers when they look at this code ("Was this correct or should it be before the break?"). It's much much clear here adding the #else with the comment or a explicit "rr->audio_mode = 0x00;" imho. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/37212?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I46afce396f730de26f21e0e4ec71e144aafd6beb Gerrit-Change-Number: 37212 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Jun 2024 12:43:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: library: de-duplicate SCTP related templates

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37197?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: library: de-duplicate SCTP related templates ...................................................................... library: de-duplicate SCTP related templates Change-Id: Ic2a0cba0cfb1909ccbd1ade9565d508fd239f78c Related: SYS#6772 --- M cbc/gen_links.sh M dia2gsup/gen_links.sh M epdg/gen_links.sh M ggsn_tests/gen_links.sh M hnbgw/gen_links.sh M hnodeb/gen_links.sh M hss/gen_links.sh M library/DIAMETER_Emulation.ttcn M library/GTPv2_Emulation.ttcn M library/Iuh_Emulation.ttcn M library/S1AP_Emulation.ttcn A library/SCTP_Templates.ttcn M library/SGsAP_Emulation.ttcn M library/sbcap/SBC_AP_Adapter.ttcn M library/sbcap/SBC_AP_CodecPort.ttcn M mme/gen_links.sh M msc/gen_links.sh M pgw/gen_links.sh M stp/STP_Tests_M3UA.ttcn M stp/gen_links.sh 20 files changed, 125 insertions(+), 131 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/97/37197/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37197?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic2a0cba0cfb1909ccbd1ade9565d508fd239f78c Gerrit-Change-Number: 37197 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year

1
0
0 0

[S] Change in osmocom-bb[master]: mobile: cosmetic: fix -Wswitch in tch_voice_state_init()

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/37212?usp=email ) Change subject: mobile: cosmetic: fix -Wswitch in tch_voice_state_init() ...................................................................... Patch Set 1: (1 comment) File src/host/layer23/src/mobile/tch_voice.c: https://gerrit.osmocom.org/c/osmocom-bb/+/37212/comment/4878e0a4_7ec75460 PS1, Line 135: #endif > is this fine here? that makes it jump into TCH_VOICE_IOH_NONE. […] It's fine because we cannot end up having `state->handler == TCH_VOICE_IOH_GAPK` if built without `WITH_GAPK_IO`. The VTY does not permit that. So we treat this very unlikely to happen scenario the same way as `TCH_VOICE_IOH_NONE`. I don't see a need to add `/* fall through */` here because the pre-processor will produce the following code when building without `WITH_GAPK_IO`: ``` case TCH_VOICE_IOH_GAPK: case TCH_VOICE_IOH_NONE: rr->audio_mode = 0x00; break; ``` -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/37212?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I46afce396f730de26f21e0e4ec71e144aafd6beb Gerrit-Change-Number: 37212 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Jun 2024 12:39:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year

1
0
0 0

[S] Change in osmocom-bb[master]: mobile: fix -Wmaybe-uninitialized in gsm48_rr_tx_meas_rep()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/37213?usp=email ) Change subject: mobile: fix -Wmaybe-uninitialized in gsm48_rr_tx_meas_rep() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/37213?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I111438633ed48e16f7c43fc1b7a23ae6753a404d Gerrit-Change-Number: 37213 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Jun 2024 12:32:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year

1
0
0 0

[S] Change in osmocom-bb[master]: mobile: cosmetic: fix -Wswitch in tch_voice_state_init()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/37212?usp=email ) Change subject: mobile: cosmetic: fix -Wswitch in tch_voice_state_init() ...................................................................... Patch Set 1: (1 comment) File src/host/layer23/src/mobile/tch_voice.c: https://gerrit.osmocom.org/c/osmocom-bb/+/37212/comment/3185fe5b_1c32aed2 PS1, Line 135: #endif is this fine here? that makes it jump into TCH_VOICE_IOH_NONE. Maybe you want to move it before the break? otherwise I'd suggest adding an: #else /* fall through */ #endif -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/37212?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I46afce396f730de26f21e0e4ec71e144aafd6beb Gerrit-Change-Number: 37212 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Jun 2024 12:31:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: library: de-duplicate SCTP related templates

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37197?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: library: de-duplicate SCTP related templates ...................................................................... library: de-duplicate SCTP related templates Change-Id: Ic2a0cba0cfb1909ccbd1ade9565d508fd239f78c Related: SYS#6772 --- M cbc/gen_links.sh M dia2gsup/gen_links.sh M epdg/gen_links.sh M ggsn_tests/gen_links.sh M hnbgw/gen_links.sh M hnodeb/gen_links.sh M hss/gen_links.sh M library/DIAMETER_Emulation.ttcn M library/GTPv2_Emulation.ttcn M library/Iuh_Emulation.ttcn M library/S1AP_Emulation.ttcn M library/SGsAP_Emulation.ttcn M library/sbcap/SBC_AP_Adapter.ttcn M library/sbcap/SBC_AP_CodecPort.ttcn M mme/gen_links.sh M msc/gen_links.sh M pgw/gen_links.sh M stp/STP_Tests_M3UA.ttcn M stp/gen_links.sh 19 files changed, 57 insertions(+), 131 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/97/37197/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37197?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic2a0cba0cfb1909ccbd1ade9565d508fd239f78c Gerrit-Change-Number: 37197 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year

1
0
0 0

[S] Change in osmocom-bb[master]: mobile: cosmetic: fix -Wswitch in tch_voice_state_init()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/37212?usp=email ) Change subject: mobile: cosmetic: fix -Wswitch in tch_voice_state_init() ...................................................................... mobile: cosmetic: fix -Wswitch in tch_voice_state_init() Not really critical, just make gcc happy: tch_voice.c: In function ‘tch_voice_state_init’: tch_voice.c:117:9: warning: enumeration value ‘TCH_VOICE_IOH_GAPK’ not handled in switch [-Wswitch] 117 | switch (state->handler) { | ^~~~~~ Change-Id: I46afce396f730de26f21e0e4ec71e144aafd6beb --- M src/host/layer23/src/mobile/tch_voice.c 1 file changed, 17 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/12/37212/1 diff --git a/src/host/layer23/src/mobile/tch_voice.c b/src/host/layer23/src/mobile/tch_voice.c index ac793e8..a740f71 100644 --- a/src/host/layer23/src/mobile/tch_voice.c +++ b/src/host/layer23/src/mobile/tch_voice.c @@ -122,8 +122,8 @@ case TCH_VOICE_IOH_LOOPBACK: rr->audio_mode = AUDIO_RX_TRAFFIC_IND | AUDIO_TX_TRAFFIC_REQ; break; -#ifdef WITH_GAPK_IO case TCH_VOICE_IOH_GAPK: +#ifdef WITH_GAPK_IO if ((cd->chan_nr & RSL_CHAN_NR_MASK) == RSL_CHAN_Bm_ACCHs) state->gapk_io = gapk_io_state_alloc_mode_rate(ms, cd->mode, true); else /* RSL_CHAN_Lm_ACCHs */ -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/37212?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I46afce396f730de26f21e0e4ec71e144aafd6beb Gerrit-Change-Number: 37212 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year

1
0
0 0

[S] Change in osmocom-bb[master]: mobile: fix -Wmaybe-uninitialized in gsm48_rr_tx_meas_rep()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/37213?usp=email ) Change subject: mobile: fix -Wmaybe-uninitialized in gsm48_rr_tx_meas_rep() ...................................................................... mobile: fix -Wmaybe-uninitialized in gsm48_rr_tx_meas_rep() This is very unlikely to happen, because we set strongest to 127, but anyway we don't want to see those warnings: gsm48_rr.c: In function ‘gsm48_rr_tx_meas_rep.isra’: gsm48_rr.c:3714:74: warning: ‘strongest_i’ may be used uninitialized [-Wmaybe-uninitialized] 3714 | if (rrmeas->nc_rxlev_dbm[i] == strongest && i <= strongest_i) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~ gsm48_rr.c:3696:31: note: ‘strongest_i’ was declared here 3696 | int i, index, strongest_i; | ^~~~~~~~~~~ Change-Id: I111438633ed48e16f7c43fc1b7a23ae6753a404d --- M src/host/layer23/src/mobile/gsm48_rr.c 1 file changed, 21 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/13/37213/1 diff --git a/src/host/layer23/src/mobile/gsm48_rr.c b/src/host/layer23/src/mobile/gsm48_rr.c index 83287c1..1750c57 100644 --- a/src/host/layer23/src/mobile/gsm48_rr.c +++ b/src/host/layer23/src/mobile/gsm48_rr.c @@ -3703,6 +3703,7 @@ /* get 6 strongest measurements */ strongest = 127; /* infinite */ + strongest_i = -1; /* make gcc happy */ for (n = 0; n < 6; n++) { current = -128; /* -infinite */ index = 0; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/37213?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I111438633ed48e16f7c43fc1b7a23ae6753a404d Gerrit-Change-Number: 37213 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year

1
0
0 0

[S] Change in docker-playground[master]: jenkins-common: Treat -asan builds the same as -master

by pespin

Attention is currently required from: daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37192?usp=email ) Change subject: jenkins-common: Treat -asan builds the same as -master ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37192?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ibf93880345f38668f8dc812d1523b985d368dfcc Gerrit-Change-Number: 37192 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Jun 2024 11:15:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year

1
0
0 0

2025

2024

2023

2022

gerrit-log June 2024