Attention is currently required from: daniel, laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37192?usp=email )
Change subject: jenkins-common: Treat -asan builds the same as -master
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37192?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Ibf93880345f38668f8dc812d1523b985d368dfcc
Gerrit-Change-Number: 37192
Gerrit-PatchSet: 3
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 12 Jun 2024 18:15:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/36915?usp=email )
Change subject: trxcon/l1sched: refactor prim management in tx_tch[fh]_fn()
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Patchset:
PS3:
I agree the way the gotos and labels are used in those functions is not nice at all, since they are not used as ordered return paths (catch/except style).
So I'm in favour of removing those. I cannot say the patch is fine, but I guess Vadim himself is the one knowing this the best, so +1 from my side.
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/36915?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I5292abf6fcd308c9f7f12c7145d004103c9c7675
Gerrit-Change-Number: 36915
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 12 Jun 2024 18:15:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37218?usp=email )
Change subject: sctp_server: fix state in catch-all handle_call()
......................................................................
sctp_server: fix state in catch-all handle_call()
Sending an unexpected call breaks the server, because the third member
of a returned tuple (not_implemented) becomes the new state. It was
actually meant to be part of the Reply - fix this.
https://www.erlang.org/doc/apps/stdlib/gen_server.html#c:handle_call/3
{reply, Reply :: term(), NewState :: term()}
Change-Id: I1cc683e549c3bb61e3e4c45bb3d244202d61be53
---
M src/sctp_server.erl
1 file changed, 18 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/18/37218/1
diff --git a/src/sctp_server.erl b/src/sctp_server.erl
index e93dd9f..806c559 100644
--- a/src/sctp_server.erl
+++ b/src/sctp_server.erl
@@ -95,7 +95,7 @@
handle_call(Info, _From, State) ->
error_logger:error_report(["unknown handle_call()",
{module, ?MODULE}, {info, Info}, {state, State}]),
- {reply, error, not_implemented}.
+ {reply, {error, not_implemented}, State}.
handle_cast({send_data, Aid, Data}, State) ->
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37218?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I1cc683e549c3bb61e3e4c45bb3d244202d61be53
Gerrit-Change-Number: 37218
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newchange
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37216?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: logging: use ?LOG macros instead of calling logger:level()
......................................................................
logging: use ?LOG macros instead of calling logger:level()
The difference between using these macros and the exported functions
is that macros add location (originator) information to the metadata,
and perform lazy evaluation by wrapping the logger call in a case
statement, so it is only evaluated if the log level of the event
passes the primary log level check.
https://www.erlang.org/doc/apps/kernel/logger_chapter.html#logger-api
Change-Id: I3b6e4296f736f9c87d2706ef5fb75146fd9f1239
---
M src/s1ap_proxy.erl
M src/sctp_client.erl
M src/sctp_proxy.erl
M src/sctp_server.erl
4 files changed, 63 insertions(+), 41 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/16/37216/2
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37216?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I3b6e4296f736f9c87d2706ef5fb75146fd9f1239
Gerrit-Change-Number: 37216
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/36914?usp=email )
Change subject: trxcon/l1sched: make l1sched_lchan_emit_data_cnf() NULL-safe
......................................................................
trxcon/l1sched: make l1sched_lchan_emit_data_cnf() NULL-safe
Passing NULL to l1sched_lchan_emit_data_cnf() is not normal and
generally not expected, but definitely not fatal enough to abort
the process completely (due to assertion failure).
Change-Id: Ie64c176265f66a6c1515c66eb465d7e60f6768db
---
M src/host/trxcon/src/sched_prim.c
1 file changed, 15 insertions(+), 1 deletion(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
osmith: Looks good to me, but someone else must approve
diff --git a/src/host/trxcon/src/sched_prim.c b/src/host/trxcon/src/sched_prim.c
index 67be75e..4974557 100644
--- a/src/host/trxcon/src/sched_prim.c
+++ b/src/host/trxcon/src/sched_prim.c
@@ -337,7 +337,8 @@
{
struct l1sched_prim *prim;
- OSMO_ASSERT(msg != NULL);
+ if (msg == NULL)
+ return -ENODEV;
/* convert from DATA.req to DATA.cnf */
prim = l1sched_prim_from_msgb(msg);
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/36914?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ie64c176265f66a6c1515c66eb465d7e60f6768db
Gerrit-Change-Number: 36914
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: merged
Attention is currently required from: daniel, laforge, pespin.
Hello Jenkins Builder, laforge, osmith, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/docker-playground/+/37192?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Code-Review+1 by pespin, Verified+1 by Jenkins Builder
Change subject: jenkins-common: Treat -asan builds the same as -master
......................................................................
jenkins-common: Treat -asan builds the same as -master
This fixes the jenkins test failures seen in ttcn3-stp-test-asan. TTCN3
tries to connect to stp via TCP, but since the jenkins.sh script doesn't
consider this a build from master the corresponding config is not added
to osmo-stp.cfg.
Also change the function names from image_suffix_is_* to osmo_repo_is_*
to better reflect what they are doing (instead of how).
Related: OS#6486
Change-Id: Ibf93880345f38668f8dc812d1523b985d368dfcc
---
M jenkins-common.sh
M ttcn3-bts-test/jenkins.sh
M ttcn3-pcu-test/jenkins-sns.sh
M ttcn3-pcu-test/jenkins.sh
M ttcn3-stp-test/jenkins.sh
5 files changed, 29 insertions(+), 10 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/92/37192/3
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37192?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Ibf93880345f38668f8dc812d1523b985d368dfcc
Gerrit-Change-Number: 37192
Gerrit-PatchSet: 3
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: fixeria.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/36915?usp=email )
Change subject: trxcon/l1sched: refactor prim management in tx_tch[fh]_fn()
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS2:
> Code duplication is the price I am ready to pay for cleaner / more predictable code flow. […]
nobody else has provided review or opinions on this topic. It's your program/project and I don't want to veto you. So if we'd get at least one other +1, feel free to +2 yourself.
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/36915?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I5292abf6fcd308c9f7f12c7145d004103c9c7675
Gerrit-Change-Number: 36915
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 12 Jun 2024 17:00:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
