Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37270?usp=email )
Change subject: ttcn3-s1gw-test: fix using unassigned addr for osmo-s1gw
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
File ttcn3-s1gw-test/jenkins.sh:
https://gerrit.osmocom.org/c/docker-playground/+/37270/comment/e6fb16f4_11e…
PS2, Line 28: -e "ERL_FLAGS=-config /data/osmo-s1gw.config" \
You can probably simply move this inside the s1gw.sh since you only need it really to run the erlang eunit, but ok.
File ttcn3-s1gw-test/s1gw.sh:
https://gerrit.osmocom.org/c/docker-playground/+/37270/comment/1707fd51_a43…
PS2, Line 8: su build -c "/tmp/osmo-s1gw/_build/default/bin/osmo-s1gw"
is the env inherited here when running through su?
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37270?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I109a5feaca5acf050008e883cc8b4e1e28beebab
Gerrit-Change-Number: 37270
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 22 Jun 2024 17:41:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: fixeria, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37270?usp=email )
Change subject: ttcn3-s1gw-test: fix using unassigned addr for osmo-s1gw
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37270?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I109a5feaca5acf050008e883cc8b4e1e28beebab
Gerrit-Change-Number: 37270
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 21 Jun 2024 20:59:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: pespin.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/37272?usp=email )
Change subject: do not invoke two Assignments (fixup for re-assignment)
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> This patch may actually be more clear if you spit it into 2 steps (no need to really the change the […]
i would have added just a bool to indicate whether an assignment is pending.
But that would introduce a potentially lingering blockage of all future Assignments, if it stays set "forever". So here I add a bool with a timeout.
I think we can't really split this patch, because the first half of the patch would add that plain bool without a timeout, which I don't want to have that way because it is "dangerous".
Adding a timeout to all Assignments is just a side-effect...
(I wish we had a proper osmo_fsm for assignment like in osmo-bsc, but introducing one now seems a lot of effort for "cosmetic" code changes, maybe avalanching to a huge refactoring... We should do that at some point, because we probably still have a bunch of corner cases now -- but it seems now is not the time to start that. I have too many patches pending for SDP, fmtp and AMR rates. Instead I want this "quick fix" because the re-assignment feature is already merged, and I uncovered this problem only now; so far the ttcn3 test was always just succeeding for me, and now it suddenly flipped over to uncover the race condition. My bad...)
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/37272?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I0f1e1a551aed545b555b9f236fc5967b1e4cc940
Gerrit-Change-Number: 37272
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 21 Jun 2024 19:24:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
