Attention is currently required from: daniel.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37307?usp=email )
Change subject: asterisk: Fix events in between unregistration procedure
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37307?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I3c9cffa1756a87334e609e85a32509ed11f026c1
Gerrit-Change-Number: 37307
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 28 Jun 2024 15:52:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37303?usp=email )
Change subject: asterisk: SIP UA: Fix seq_nr transmitting ACK for MO call
......................................................................
asterisk: SIP UA: Fix seq_nr transmitting ACK for MO call
RFC 3261 17.1.1.3:
"The CSeq header field in the ACK MUST contain the same value for
the sequence number as was present in the original request"
Change-Id: I3d584d234b11ef9d21f203fbf18d63a5602775f0
---
M asterisk/SIP_ConnectionHandler.ttcn
1 file changed, 13 insertions(+), 1 deletion(-)
Approvals:
daniel: Looks good to me, but someone else must approve
Jenkins Builder: Verified
pespin: Looks good to me, approved
diff --git a/asterisk/SIP_ConnectionHandler.ttcn b/asterisk/SIP_ConnectionHandler.ttcn
index 696be8a..52290fd 100644
--- a/asterisk/SIP_ConnectionHandler.ttcn
+++ b/asterisk/SIP_ConnectionHandler.ttcn
@@ -482,7 +482,6 @@
g_pars.cp.to_addr := g_rx_sip_resp.msgHeader.toField;
/* Transmit ACK */
- g_pars.cp.sip_seq_nr := g_pars.cp.sip_seq_nr + 1;
req := ts_SIP_ACK(g_pars.cp.sip_call_id,
g_pars.cp.from_addr,
g_pars.cp.to_addr,
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37303?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I3d584d234b11ef9d21f203fbf18d63a5602775f0
Gerrit-Change-Number: 37303
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged